New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cwd_enoent.t fails on DragonFly BSD #16525
Comments
From @xenuOn the latest blead: % ./perl -I ../lib ../dist/PathTools/t/cwd_enoent.t The problem is similar to #132733, getcwd() doesn't fail on non-existent I'm sure it's a bug in DragonFly, but I think we should skip failing |
From @xenuThe patch is attached. |
From @xenu0001-getcwd-doesn-t-fail-on-non-existent-directories-on-D.patchFrom 0db64c5b2058a7a3c33e2e9a58ff4bda04a30833 Mon Sep 17 00:00:00 2001
From: Tomasz Konojacki <me@xenu.pl>
Date: Sun, 22 Apr 2018 23:49:59 +0200
Subject: [PATCH 1/1] getcwd() doesn't fail on non-existent directories on
DragonFly BSD.
Until it's fixed upstream, we should skip tests that don't expect
this behaviour.
[RT #133141]
---
dist/PathTools/t/cwd_enoent.t | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/dist/PathTools/t/cwd_enoent.t b/dist/PathTools/t/cwd_enoent.t
index ee99423cbb..b9adddeab7 100644
--- a/dist/PathTools/t/cwd_enoent.t
+++ b/dist/PathTools/t/cwd_enoent.t
@@ -24,6 +24,10 @@ foreach my $type (qw(regular perl)) {
skip "_perl_abs_path() not expected to work", 4
if $type eq "perl" &&
!(($Config{prefix} =~ m/\//) && $^O ne "cygwin");
+
+ skip "getcwd() doesn't fail on non-existent directories on this platform", 4
+ if $type eq 'regular' && $^O eq 'dragonfly';
+
no warnings "redefine";
local *Cwd::abs_path = \&Cwd::_perl_abs_path if $type eq "perl";
local *Cwd::getcwd = \&Cwd::_perl_getcwd if $type eq "perl";
--
2.17.0
|
From @jkeenanOn Sun, 22 Apr 2018 22:07:52 GMT, me@xenu.pl wrote:
Available for smoke-testing in: -- |
The RT System itself - Status changed from 'new' to 'open' |
From @khwilliamsonOn 04/24/2018 12:37 PM, James E Keenan via RT wrote:
I support adding skips to tests during the freeze which fix failing But I'm thinking that skips for OS bugs, like this, should have be |
From @jkeenanOn Tue, 24 Apr 2018 18:37:20 GMT, jkeenan wrote:
Xenu: It appears that you are the only person smoking on Dragonfly at the moment. Could you please test this branch on those rigs? Thank you very much. -- |
From @xenuOn Fri, 27 Apr 2018 11:38:17 -0700
Looks good: http://perl5.test-smoke.org/report/65465 |
From @iabynOn Tue, Apr 24, 2018 at 02:18:15PM -0600, Karl Williamson wrote:
While agree in principle, this late in code freeze, I'm happy for that The skip condition can always be softened later. -- |
From @xsawyerxOn 04/30/2018 03:27 PM, Dave Mitchell wrote:
Go for it. |
From @iabynOn Mon, Apr 30, 2018 at 11:53:43PM +0300, Sawyer X wrote:
Now applied as v5.27.11-25-g02bf4969b4 -- |
In May 2018, we applied this patch from you to skip 4 tests in PathTools t/cwd_enoent.t on DragonflyBSD. Discussion suggested that at some point we might be able to relax that skip condition. Can we remove the 'skip'? And, while we're talking about Dragonfly -- are you in a position to submit smoke-test reports on blead on this platform? Thank you very much. |
It doesn't look like it:
The test passes with the skip in place. Carlos started smokng dragonfly at some point, which is showing other errors, which I'm following up. Unfortunately getting a dragonfly bug reporting account isn't a simple web sign-up :-( |
I think those failures are filesystem-related. On my UFS VM tests are 100% passing, so it's probably due to Carlos using HAMMER1 or HAMMER2. |
To the extent that we are getting smoke-test results from Dragonfly BSD, they are running green. So I believe this ticket is closable. Anyone disagree? Thank you very much. |
I'll PR some checks to only skip on the broken releases |
There hasn't been a release number bump yet, so we can't differentiate between the fixed and unfixed versions |
@tonycoz, has there been a release such that this is now closable? |
yes, I'll check the for the release it ended up in and update the test |
That fix is producing a warning on OSes that don't have exactly two numeric components. It's fixed it up with v5.37.2-10-gf9757a510d |
The fixup in blead is provided by f9757a5 |
Would it be possible to provide URLs to smoke-test reports that (i) show the warning and then (ii) show that the warning is no longer being generated? |
Does this still need to be open? |
We haven't heard anything from the OP warranting keeping the ticket open, so I'm closing it now. Thanks. |
Migrated from rt.perl.org#133141 (status was 'open')
Searchable as RT133141$
The text was updated successfully, but these errors were encountered: