New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PathTools: test descriptions; makefile updates; etc. #16414
Comments
From @jkeenanPathTools falls under dist/, so it's "blead-upstream." It hasn't had a Please review. It would be nice if we could merge these into blead Thank you very much. |
From @jkeenan0001-Provide-.gitignore-for-PathTools-distribution.patchFrom 01fdf3bd78f424bd4622ad0f77dc30bcbcafa53e Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Sun, 11 Feb 2018 11:36:45 -0500
Subject: [PATCH 1/3] Provide .gitignore for PathTools distribution.
---
dist/PathTools/.gitignore | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 dist/PathTools/.gitignore
diff --git a/dist/PathTools/.gitignore b/dist/PathTools/.gitignore
new file mode 100644
index 0000000..a87d516
--- /dev/null
+++ b/dist/PathTools/.gitignore
@@ -0,0 +1,2 @@
+/Cwd.c
+/Cwd.bs
--
2.7.4
|
From @jkeenan0002-Ensure-that-all-tests-in-t-cwd.t-have-descriptions.patchFrom 346aca5cf3d5ac5b7829bba94ba0ce5cbd1d3626 Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Sun, 11 Feb 2018 11:44:21 -0500
Subject: [PATCH 2/3] Ensure that all tests in t/cwd.t have descriptions.
---
dist/PathTools/t/cwd.t | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/dist/PathTools/t/cwd.t b/dist/PathTools/t/cwd.t
index 8cf3586..483b437 100644
--- a/dist/PathTools/t/cwd.t
+++ b/dist/PathTools/t/cwd.t
@@ -145,7 +145,7 @@ Cwd::chdir $Test_Dir;
foreach my $func (qw(cwd getcwd fastcwd fastgetcwd)) {
my $result = eval "$func()";
- is $@, '';
+ is $@, '', "No exception for ${func}() in string eval";
dir_ends_with( $result, $Test_Dir, "$func()" );
}
@@ -171,7 +171,7 @@ rmtree($test_dirs[0], 0, 0);
my $check = ($vms_mode ? qr|\b((?i)t)\]$| :
qr|\bt$| );
- like($ENV{PWD}, $check);
+ like($ENV{PWD}, $check, "We're in a 't' directory");
}
{
@@ -179,7 +179,7 @@ rmtree($test_dirs[0], 0, 0);
my $start_pwd = $ENV{PWD};
mkpath([$Test_Dir], 0, 0777);
Cwd::abs_path($Test_Dir);
- is $ENV{PWD}, $start_pwd;
+ is $ENV{PWD}, $start_pwd, "abs_path() does not trample \$ENV{PWD}";
rmtree($test_dirs[0], 0, 0);
}
@@ -192,6 +192,7 @@ SKIP: {
my $abs_path = Cwd::abs_path($file);
my $fast_abs_path = Cwd::fast_abs_path($file);
+ my $pas = Cwd::_perl_abs_path($file);
my $want = quotemeta(
File::Spec->rel2abs( $Test_Dir )
);
@@ -205,9 +206,9 @@ SKIP: {
$want = quotemeta($want);
}
- like($abs_path, qr|$want$|i);
- like($fast_abs_path, qr|$want$|i);
- like(Cwd::_perl_abs_path($file), qr|$want$|i) if $EXTRA_ABSPATH_TESTS;
+ like($abs_path, qr|$want$|i, "Cwd::abs_path produced $abs_path");
+ like($fast_abs_path, qr|$want$|i, "Cwd::fast_abs_path produced $fast_abs_path");
+ like($pas, qr|$want$|i, "Cwd::_perl_abs_path produced $pas") if $EXTRA_ABSPATH_TESTS;
rmtree($test_dirs[0], 0, 0);
1 while unlink $file;
--
2.7.4
|
From @jkeenan0003-Add-ABSTRACT-LICENSE-AUTHOR-etc.-elements.patchFrom 9c5d14be6d25b04fac0a946edd23f70ee8b6f563 Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Sun, 11 Feb 2018 11:49:19 -0500
Subject: [PATCH 3/3] Add ABSTRACT, LICENSE, AUTHOR, etc. elements.
Add them conditionally so that CPAN PathTools can accommodate different
versions of ExtUtils::MakeMaker and CPAN metadata protocols.
Styled after Module-CoreList's Makefile.PL for better readability.
---
dist/PathTools/Makefile.PL | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/dist/PathTools/Makefile.PL b/dist/PathTools/Makefile.PL
index 71b9a60..11e04af 100644
--- a/dist/PathTools/Makefile.PL
+++ b/dist/PathTools/Makefile.PL
@@ -9,11 +9,26 @@ BEGIN { @INC = grep { $_ ne "blib/arch" and $_ ne "blib/lib" } @INC }
require 5.005;
use ExtUtils::MakeMaker;
+
+my @extra;
+push @extra, 'LICENSE' => 'perl_5'
+ unless $ExtUtils::MakeMaker::VERSION < 6.31;
+push @extra, 'META_MERGE' => {
+ resources => {
+ repository => 'git://perl5.git.perl.org/perl.git',
+ bugtracker => 'https://rt.perl.org/rt3/',
+ homepage => "http://dev.perl.org/",
+ license => [ 'http://dev.perl.org/licenses/' ],
+ },
+ } unless $ExtUtils::MakeMaker::VERSION < 6.46;
+
WriteMakefile
(
'DISTNAME' => 'PathTools',
'NAME' => 'Cwd',
'VERSION_FROM' => 'Cwd.pm',
+ 'ABSTRACT' => 'Tools for working with directory and file names',
+ 'AUTHOR' => 'Perl 5 Porters',
'DEFINE' => join(" ",
"-DDOUBLE_SLASHES_SPECIAL=@{[$^O eq q(qnx) || $^O eq q(nto) ? 1 : 0]}",
((grep { $_ eq 'PERL_CORE=1' } @ARGV) ? '-DNO_PPPORT_H' : ()),
@@ -27,6 +42,7 @@ WriteMakefile
},
($] > 5.011) ? () : ( INSTALLDIRS => 'perl' ), # CPAN sourced versions should now install to site
'EXE_FILES' => [],
- 'PL_FILES' => {}
+ 'PL_FILES' => {},
+ @extra,
)
;
--
2.7.4
|
From @jkeenanSummary of my perl5 (revision 5 version 27 subversion 9) configuration: Characteristics of this binary (from libperl): |
From @jkeenanOn Sun, 11 Feb 2018 17:09:55 GMT, jkeenan@pobox.com wrote:
Hearing no objection, I merged these into blead. In reverse order: ##### Add ABSTRACT, LICENSE, AUTHOR, etc. elements. commit fb686fb Ensure that all tests in t/cwd.t have descriptions. commit 5f3e133 Provide .gitignore for PathTools distribution. Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
@jkeenan - Status changed from 'open' to 'pending release' |
From @xsawyerxOn 02/17/2018 05:54 PM, James E Keenan via RT wrote:
I'll be working on a new release. |
From @xsawyerxOn Sat, 17 Feb 2018 09:51:12 -0800, xsawyerx@gmail.com wrote:
I've released a new version and it's also available in 5.27.9. |
@xsawyerx - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#132853 (status was 'resolved')
Searchable as RT132853$
The text was updated successfully, but these errors were encountered: