New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t/porting/bench.t uses system perl's /lib during testing #16399
Comments
From @bulk88Created by @bulk88While upgrading blead perl, I ran into a test failure where ----------------------- C:\p527\srcnew\t> This is the same family of bugs from now closed ticket Top of bench.t has ------------------- C:\p527\srcnew\t> A system call log shows the perl proc reached outside its build dir. Perl Info
|
From @jkeenanOn Thu, 01 Feb 2018 00:13:16 GMT, bulk88 wrote:
Please review the patch attached. Thank you very much. |
From @jkeenan0001-Ensure-that-we-don-t-pick-up-any-system-perl-librari.patchFrom 7176369a25e8f19ca42037b34cf29d3ca1c1b533 Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Wed, 31 Jan 2018 21:59:21 -0500
Subject: [PATCH] Ensure that we don't pick up any "system perl" libraries in
@INC.
We need a tightly defined @INC which, for this test file, only needs './lib'
so that we can locate the two pragmata and Config.
For: RT # 132795
---
t/porting/bench.t | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/porting/bench.t b/t/porting/bench.t
index ee4c1c3..7c137c1 100644
--- a/t/porting/bench.t
+++ b/t/porting/bench.t
@@ -7,9 +7,9 @@
# See also t/porting/bench_selftest.pl
BEGIN {
- chdir '..' if -f 'test.pl' && -f 'thread_it.pl';
+ chdir '..' if -f 'test.pl';
+ @INC = ( './lib' );
require './t/test.pl';
- push @INC, 'lib';
}
use warnings;
@@ -22,7 +22,7 @@ use Config;
# Only test on a platform likely to support forking, pipes, cachegrind
# etc. Add other platforms if you think they're safe.
-skip_all "not devel" unless -d ".git";
+skip_all "not devel" unless -d "./.git";
skip_all "not linux" unless $^O eq 'linux';
skip_all "no valgrind" unless -x '/bin/valgrind' || -x '/usr/bin/valgrind';
# Address sanitizer clashes horribly with cachegrind
--
2.7.4
|
The RT System itself - Status changed from 'new' to 'open' |
From @bulk88On Wed, 31 Jan 2018 19:04:02 -0800, jkeenan wrote:
Patch works for me. I have no comment on the other changes in that patch other than @INC assignment vs push. -- |
From @jkeenanOn Thu, 01 Feb 2018 05:14:35 GMT, bulk88 wrote:
Patch pushed to blead in commit 361b6e5. Thank you very much. |
@jkeenan - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been Perl 5.28.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#132795 (status was 'resolved')
Searchable as RT132795$
The text was updated successfully, but these errors were encountered: