New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] missing newline after "Unable to flush stdout: ..." #16151
Comments
From @ntyniAs reported by Jacub Wilk in https://bugs.debian.org/875361 Trivial patch attached. Perl Info
|
From @ntyni0001-Add-missing-newline-to-the-Unable-to-flush-stdout-di.patchFrom 44e580052aabe81c72faa3f8bbc273b6ac574487 Mon Sep 17 00:00:00 2001
From: Niko Tyni <ntyni@debian.org>
Date: Sat, 16 Sep 2017 11:24:18 +0300
Subject: [PATCH] Add missing newline to the "Unable to flush stdout"
diagnostic
Originally reported by Jakub Wilk.
Bug-Debian: https://bugs.debian.org/875361
---
perl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/perl.c b/perl.c
index fd100cc64a..13bbbb07bd 100644
--- a/perl.c
+++ b/perl.c
@@ -674,7 +674,7 @@ perl_destruct(pTHXx)
if (*stdo && PerlIO_flush(stdo)) {
PerlIO_restore_errno(stdo);
if (errno)
- PerlIO_printf(PerlIO_stderr(), "Unable to flush stdout: %s",
+ PerlIO_printf(PerlIO_stderr(), "Unable to flush stdout: %s\n",
Strerror(errno));
if (!STATUS_UNIX)
STATUS_ALL_FAILURE;
--
2.13.3
|
From @jkeenanOn Sat, 16 Sep 2017 12:17:34 GMT, ntyni@debian.org wrote:
1. Is there any way we could compose a regression test from this? ##### 2. The patch itself appears to be correct. Is there any reason (other than lack of test) why it should not be applied? Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Sat, 16 Sep 2017 12:17:34 GMT, ntyni@debian.org wrote:
Similar error messages: ##### -- |
From @cpansproutOn Sat, 16 Sep 2017 07:27:02 -0700, jkeenan wrote:
/dev/full is not portable. Maybe you could check for the existence of /dev/full and skip the test otherwise. On some systems (such as Windows), it may be good to skip it unconditionally, since there is nothing to prevent someone from creating a file with that name.
I think not. -- Father Chrysostomos |
From zefram@fysh.orgNiko Tyni wrote:
Applied as commit 3753712. -zefram |
@xsawyerx - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been Perl 5.28.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#132100 (status was 'resolved')
Searchable as RT132100$
The text was updated successfully, but these errors were encountered: