New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance loss in some commits #6328
Comments
From @zoffixznetRecently, we have had about ~2.7% overall performance loss, when running stresstest/spectest that a couple of devs noticed. Based on stresstest timings I post ( https://irclog.perlgeek.de/perl6-dev/search/?nick=&q=ZOFVM ), the slowdown happened in SHA Stresstest (s) Spectest (s) As you can see, the middle commits is where the slowage appears to occur, with 2500e50 being the most likely culprit, I went and rewrote it in NQP (attached) to see if it drops the numbers at all, and... it didn't really. I gave up with this. I think we need some extensive bench without any random sleeps or delays in it and comprehensive enough to test more than And with such a bench in hand, it might become easier to hunt commits that slow stuff down considerably. |
From @lizmat
Generally, we don’t care about performance once we have an unrecoverable exception that needs to be reported. If the stresstest regression is caused by trying to do Levenstein on method names (which can be a lot on some objects), then maybe the performance of spectest/stresstest can be accounted for by *just* the tests that throw Method Not Found errors? |
The RT System itself - Status changed from 'new' to 'open' |
From @zoffixznetOn Mon, 05 Jun 2017 13:28:00 -0700, elizabeth wrote:
Yeah, I think the nqp version of the exception is proof that's the wrong commit, otherwise Something else was the cause, but I ran out of steam hunting it. |
From @AlexDanielI'll take a look a bit later. It feels like the commit you mentioned is the right one, which makes me think that we can reject this ticket, but at that pace the spectest will get to turtle speeds even though all our changes will be justified. Anyway, I'll bisect it first and then we'll have a look at what can be done to Make the Spectest Fast Again. On 2017-06-05 14:27:28, cpan@zoffix.com wrote:
|
From @zoffixznetSo it *is* the commit originally found, but the Exception.message call was later optimized away to being called only when needed, and not when the exception is thrown, so this don't matter anymore. Commit timing results: https://irclog.perlgeek.de/perl6-dev/2017-10-14#i_15303228 |
@zoffixznet - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#131515 (status was 'resolved')
Searchable as RT131515$
The text was updated successfully, but these errors were encountered: