New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semicolons on *_DIAG_{IGNORE,RESTORE} #15863
Comments
From @hvdsCreated by @hvdsFrom perl.h: % # probably correct Is it worth fixing these wholesale? (Prompted by surprise at d7f10d9 from James Keenan earlier today.) Perl Info
|
From @jkeenanOn Mon, 06 Feb 2017 14:17:33 GMT, hv wrote:
Errrrm ... probably not (yet). I was playing around with the approach being explored by Andy Lester -- compile with clang under '-Weverything'. I came up with exactly one instance of '-Wextra-semi' in the entire core distribution -- the one in threads.xs. A one-character correction, reviewed by threads maintainer Jerry Hedden. Extremely low hanging fruit. But I can tell that many of the other warnings generated under '-Weverything' need more careful thought before we touch them. I don't have much experience in this area. Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @hvdsOn Tue, 07 Feb 2017 09:55:26 -0800, jkeenan wrote:
I'm not talking about wholesale fixes for -Weverything, just about wholesale fixes to the correct usage of these particular 4 macros - correct usage that we've already gone to the bother of documenting in perl.h but apparently mostly ignored for actual use. If avoiding the semicolon is the correct thing to do, then it should be "extremely low-hanging fruit" everywhere - I think due diligence would consist at most in checking that they're preceded and followed by something well-formed. It also feels more sane to fix at least the *.[ch] examples in one commit than in 70-odd separate ones. An alternative approach would be to decide that we don't care - perhaps that we gain more from visual consistency with other statement-type macros in the source than we do from -Weverything-cleanliness - in which case we'd probably be better off changing the perl.h recommendation and consistently having the semicolon everywhere. The mess of a halfway house is what loses us the most. Hugo |
From zefram@fysh.orgWe can't in practice prevent people using semicolons, so -zefram |
From @hvdsOn Fri, 15 Dec 2017 23:16:09 -0800, zefram@fysh.org wrote:
Looks good to me; the only matches now updated versions of my original greps are on the macro declarations themselves. Setting as pending release. Hugo |
@hvds - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been Perl 5.28.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#130726 (status was 'resolved')
Searchable as RT130726$
The text was updated successfully, but these errors were encountered: