Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod config parses colopairs but simply stringifies whatever it matched #5962

Closed
p6rt opened this issue Jan 1, 2017 · 8 comments
Closed

Pod config parses colopairs but simply stringifies whatever it matched #5962

p6rt opened this issue Jan 1, 2017 · 8 comments

Comments

@p6rt
Copy link

p6rt commented Jan 1, 2017

Migrated from rt.perl.org#130477 (status was 'resolved')

Searchable as RT130477$

@p6rt
Copy link
Author

p6rt commented Jan 1, 2017

From @zoffixznet

For example, in the code below, only `​:bar` config var would have the correct value. The rest
all parse OK but the rest simply stringify whatever is inside the `()`​:

  =begin table :foo('meow') :bar<meow> :ber(Q|foos|) :var(join "\n", <a b c>)

  The Bowler Carol Pinnsler Haunted bowling ball

  =end table

  dd $=pod

  # [Pod​::Block​::Table.new(caption => Any, headers => [], config => {​:bar("meow"), :ber("Q|foos|"), :foo("'meow'"), :var("join \"\\n\", <a b c>")}, contents => [["The Bowler", "Carol Pinnsler", "Haunted bowling ball"],])]

I took a look at fixing this, and the problematic code has comments "# This is a cheaty and evil hack." and "# and this is the worst hack of them all."

Need to determine what sort of config values are acceptable (considering right now you can execute arbitrary code via a BEGIN block) and then change how this stuff is actually parsed.

@p6rt
Copy link
Author

p6rt commented Jan 9, 2017

From @zoffixznet

Comments from TimToady​: https://irclog.perlgeek.de/moarvm/2017-01-09#i_13886808

@p6rt
Copy link
Author

p6rt commented Dec 4, 2017

@p6rt
Copy link
Author

p6rt commented Dec 4, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Dec 4, 2017

@p6rt
Copy link
Author

p6rt commented Jan 18, 2018

From @tbrowder

closed by merge of rakudo PR #​1339

@p6rt
Copy link
Author

p6rt commented Jan 18, 2018

@tbrowder - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Jan 18, 2018
@p6rt
Copy link
Author

p6rt commented Jan 19, 2018

From @tbrowder

closed also with tests in merged roast PR #​371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant