New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.25.3-266-g1d7e644 breaks VPIT/Variable-Magic-0.59.tar.gz #15528
Comments
From @andkbisect commit 1d7e644 av_fetch(): use AvFILLp rather than AvFILL diagnostics http://www.cpantesters.org/cpan/report/4145b580-64b0-11e6-a8a1-60d858b9f28c perl -V Summary of my perl5 (revision 5 version 25 subversion 4) configuration: Characteristics of this binary (from libperl): -- |
From perl@profvince.comLe 18/08/2016 à 19:22, (Andreas J. Koenig) (via RT) a écrit :
Thanks for the bisect. I had seen the report, but I did not know exactly I'm too busy right now to check this and cut out a release, but I'll try Maybe it should be documented somewhere that len magic is practically Vincent |
The RT System itself - Status changed from 'new' to 'open' |
From @iabynOn Thu, Aug 18, 2016 at 07:42:25PM -0300, Vincent Pit (VPIT) wrote:
That particular commit changed the code path in av_fetch() which handles av_fetch() uses AvFILLp() unless both the RMG flag is set and it can find -- |
From @iabynOn Fri, Aug 19, 2016 at 12:12:14PM +0100, Dave Mitchell wrote:
Indeed, changing $val[-1] to $val[2] in t/22-len.t (which should be So len magic on arrays has never worked for Variable::Magic, except for I'd suggest that Variable::Magic is updated to reflect this reality, -- |
From @iabynOn Mon, Aug 22, 2016 at 09:41:43AM +0100, Dave Mitchell wrote:
Interestingly, if I change av_fetch() so that it does AvFILL() (rather # Failed test 'array: assign element to triggers magic correctly' I strongly suspect that that the correct fix is to update V::M's tests and commit 8d168aa tmp fix for Bleadperl breaks Variable-Magic Affected files ... Differences ... Inline Patchdiff --git a/av.c b/av.c
index 21828a9..e3c6d5a 100644
--- a/av.c
+++ b/av.c
@@ -272,7 +272,8 @@ Perl_av_fetch(pTHX_ AV *av, SSize_t key, I32 lval)
}
neg = (key < 0);
- size = AvFILLp(av) + 1;
+ /* XXX tmp restore old behaviour to make Variable::Magic pass */
+ size = (neg ? AvFILL(av): AvFILLp(av)) + 1;
key += neg * size; /* handle negative index without using branch */
/* the cast from SSize_t to Size_t allows both (key < 0) and (key >= size)
-- "But Sidley Park is already a picture, and a most amiable picture too. |
From perl@profvince.com
I've released version 0.60 that skips the test, so you can revert your Vincent |
From @iabynOn Tue, Sep 06, 2016 at 07:36:20PM -0300, Vincent Pit (VPIT) wrote:
Ok thanks. Now unreverted. -- |
@iabyn - Status changed from 'open' to 'rejected' |
Migrated from rt.perl.org#128989 (status was 'rejected')
Searchable as RT128989$
The text was updated successfully, but these errors were encountered: