New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MoarVM) chdir does not respect group reading privilege #5294
Comments
From @molecules# This is on 64-bit CentOS 7, but I have also observed this behavior on # First we see that "chdir" works when permissions are liberal
# "chdir" doesn't work after removing "other" read/execute privileges
# But the "test" user does belong to its own "test" group # This is using Rakudo-Star 2016.04 on MoarVM 2016.04 |
From @geekosaurOn Tue, May 3, 2016 at 12:01 PM, Christopher Bottoms <
Urgh. Please tell me it is not testing permissions before changing (And I can't wait to see this fail on a network filesystem which doesn't -- |
The RT System itself - Status changed from 'new' to 'open' |
From @molecules
Yes, it is doing such checks. I was tempted to work on them myself, until I found out that the functions actually doing the checking are implemented in the virtual machines themselves (e.g. MoarVM, JVM). Related pages: https://github.com/rakudo/rakudo/blob/nom/src/core/IO/Path.pm#L269 |
From @moleculesOne more related page: https://github.com/perl6/nqp/blob/master/src/vm/moar/QAST/QASTOperationsMAST.nqp#L2026 |
From @moleculesFile numbers change, so some of the previous links aren't pointing to the desired lines anymore. Try these "search" links should be helpful: https://github.com/rakudo/rakudo/search?q="did+not+pass+'d+"&type=Code |
From @moleculesI found that this is not a problem on Perl 6 with a JVM backend. So this is MoarVM-specific. On Tue May 03 09:01:15 2016, molecules wrote:
|
From @moleculesThis doesn't seem to be a problem with Rakudo 2017.04, so was probably fixed by Zoffix's I/O work (see http://blogs.perl.org/users/zoffix_znet/2017/04/perl-6-io-tpf-grant-monthly-report-april-2017.html). Thanks! I think that the only thing lacking is a good regression test in roast. I could easily write a Unix-specific test, but I think we want something more general. On Mon, 31 Oct 2016 08:08:15 -0700, molecules wrote:
|
From @zoffixznetOn Mon, 17 Jul 2017 10:26:43 -0700, molecules wrote:
What was "fixed" is chdir by default only does the `.d` test now (it used to do `.r` test too). But I suspect the old behaviour is still there when doing `chdir :d, :r, 'some dir'`, so it does the `.r` too. [1] https://github.com/perl6/roast/blob/9b51341b6c77bfe6f0ce045431942eadc4301d78/S32-io/chdir.t#L61-L140 |
From @geekosaurIt should not be testing, it should just try to do the operation and On Mon, Jul 17, 2017 at 6:02 PM, Zoffix Znet via RT <
-- |
From @zoffixznetOn Mon, 17 Jul 2017 16:12:05 -0700, allbery.b@gmail.com wrote:
We're talking about &chdir() not &*chdir(). Aside from setting $*CWD, testing is all it does and without testing, it'll never fail. |
Migrated from rt.perl.org#128062 (status was 'open')
Searchable as RT128062$
The text was updated successfully, but these errors were encountered: