New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-DDEBUGGING -Dusequadmath -Dusethreads builds crash early #15274
Comments
From @tonycoztony@mars:.../git/perl$ git describe movaps requires 16-byte aligned pointers: tony@mars:.../git/perl$ grep alignbytes config.sh Oops. The alignbytes check in Configure doesn't appear to take usequadmath into account. Tony |
From @tonycozOn Wed Apr 13 21:02:19 2016, tonyc wrote:
Patch. Tony |
From @tonycoz0001-perl-127894-take-usequadmath-into-account-for-alignb.patchFrom 001d4714f4564d74f3af9ce05470c698f534d0a8 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 14 Apr 2016 14:30:50 +1000
Subject: [PATCH] (perl #127894) take usequadmath into account for alignbytes
---
Configure | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Configure b/Configure
index ff864b0..94fb17e 100755
--- a/Configure
+++ b/Configure
@@ -20168,6 +20168,10 @@ case "$alignbytes" in
$cat >try.c <<'EOCP'
typedef long double NV;
EOCP
+ elif $test "X$usequadmath" = Xdefine -a "X$i_quadmath" = Xdefine; then
+ $cat >try.c <<'EOCP'
+typedef __float128 NV;
+EOCP
else
$cat >try.c <<'EOCP'
typedef double NV;
--
2.1.4
|
From @TuxOn Wed, 13 Apr 2016 21:33:10 -0700, "Tony Cook via RT"
So close before 5.24? Is Rugby (#QAH) soon enough?
-- |
The RT System itself - Status changed from 'new' to 'open' |
From @ilmari"Tony Cook via RT" <perlbug-followup@perl.org> writes:
Instead of having to modify this every time a new NV type comes along, Inline Patchdiff --git a/Configure b/Configure
index ff864b0..2f4ffcc 100755
--- a/Configure
+++ b/Configure
@@ -20164,20 +20164,11 @@ eval $inlibc
echo " "
case "$alignbytes" in
'') echo "Checking alignment constraints..." >&4
- if $test "X$uselongdouble" = Xdefine -a "X$d_longdbl" = Xdefine; then
- $cat >try.c <<'EOCP'
-typedef long double NV;
-EOCP
- else
- $cat >try.c <<'EOCP'
-typedef double NV;
-EOCP
- fi
- $cat >>try.c <<'EOCP'
+ $cat >try.c <<EOCP
#include <stdio.h>
struct foobar {
char foo;
- NV bar;
+ $nvtype bar;
} try_algn;
int main()
{
-- "I use RMS as a guide in the same way that a boat captain would use |
From @tonycozOn Thu Apr 14 12:33:04 2016, ilmari wrote:
Good point, applied as ab462c7. Tony |
@tonycoz - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for submitting this report. You have helped make Perl better. Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0 |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
From @dcollinsnThis bug exists in 5.22.2, so this fix should probably be backported to 5.22.3 if we're still supporting that? |
Migrated from rt.perl.org#127894 (status was 'resolved')
Searchable as RT127894$
The text was updated successfully, but these errors were encountered: