Bleadperl v5.23.7-331-g000814d breaks NEILB/Module-Info-0.37.tar.gz #15165

p5pRT · 2016-02-09T05:19:24Z

Migrated from rt.perl.org#127494 (status was 'resolved')

Searchable as RT127494$

p5pRT · 2016-02-09T05:19:24Z

From @andk

bisect

commit 000814d
Author: Tony Cook <tony@develop-help.com>
Date: Tue Jan 19 11:42:21 2016 +1100

[perl #124387] call AUTOLOAD when DESTROY isn't defined

diagnostics

The test t/Module-Info.t hangs after this output:

% make test TEST_FILES=t/Module-Info.t
Skip blib/lib/Module/Info.pm (unchanged)
Skip blib/lib/B/Module/Info.pm (unchanged)
cp bin/module_info blib/script/module_info
"/home/sand/src/perl/repoperls/installed-perls/perl/v5.23.7-331-g000814d/79cc/bin/perl" -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/module_info
cp bin/pfunc blib/script/pfunc
"/home/sand/src/perl/repoperls/installed-perls/perl/v5.23.7-331-g000814d/79cc/bin/perl" -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/pfunc
PERL_DL_NONLAZY=1 "/home/sand/src/perl/repoperls/installed-perls/perl/v5.23.7-331-g000814d/79cc/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/Module-Info.t
t/Module-Info.t .. 16/59 Use of uninitialized value in eval "string" at /tmp/loop_over_bdir-bQg7EB/Module-Info-0.37-dnMvCp/blib/lib/Module/Info.pm line 827.
Use of uninitialized value in eval "string" at /tmp/loop_over_bdir-bQg7EB/Module-Info-0.37-dnMvCp/blib/lib/Module/Info.pm line 827.
Use of uninitialized value in eval "string" at /tmp/loop_over_bdir-bQg7EB/Module-Info-0.37-dnMvCp/blib/lib/Module/Info.pm line 827.
t/Module-Info.t .. 56/59 Use of uninitialized value $args in concatenation (.) or string at /tmp/loop_over_bdir-bQg7EB/Module-Info-0.37-dnMvCp/blib/lib/Module/Info.pm line 841.

perl -V

Summary of my perl5 (revision 5 version 23 subversion 8) configuration:
Commit id: 000814d
Platform:
osname=linux, osvers=4.3.0-1-amd64, archname=x86_64-linux
uname='linux k83 4.3.0-1-amd64 #1 smp debian 4.3.3-7 (2016-01-19) x86_64 gnulinux '
config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.23.7-331-g000814d/79cc -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Uuseithreads -Uuselongdouble -DDEBUGGING=-g'
hint=recommended, useposix=true, d_sigaction=define
useithreads=undef, usemultiplicity=undef
use64bitint=define, use64bitall=define, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2',
optimize='-O2 -g',
cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
ccversion='', gccversion='5.3.1 20160121', gccosandvers=''
intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='cc', ldflags =' -fstack-protector-strong -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
libs=-lpthread -lnsl -lgdbm -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
libc=libc-2.21.so, so=so, useshrplib=false, libperl=libperl.a
gnulibc_version='2.21'
Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl):
Compile-time options: HAS_TIMES PERLIO_LAYERS PERL_COPY_ON_WRITE
PERL_DONT_CREATE_GVSV
PERL_HASH_FUNC_ONE_AT_A_TIME_HARD PERL_MALLOC_WRAP
PERL_PRESERVE_IVUV PERL_USE_DEVEL USE_64_BIT_ALL
USE_64_BIT_INT USE_LARGE_FILES USE_LOCALE
USE_LOCALE_COLLATE USE_LOCALE_CTYPE
USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_PERLIO
USE_PERL_ATOF
Built under linux
Compiled at Feb 9 2016 05:52:51
%ENV:
PERL5LIB=""
PERL5OPT=""
PERL5_CPANPLUS_IS_RUNNING="3300"
PERL5_CPAN_IS_RUNNING="3300"
@INC:
/home/sand/src/perl/repoperls/installed-perls/perl/v5.23.7-331-g000814d/79cc/lib/site_perl/5.23.8/x86_64-linux
/home/sand/src/perl/repoperls/installed-perls/perl/v5.23.7-331-g000814d/79cc/lib/site_perl/5.23.8
/home/sand/src/perl/repoperls/installed-perls/perl/v5.23.7-331-g000814d/79cc/lib/5.23.8/x86_64-linux
/home/sand/src/perl/repoperls/installed-perls/perl/v5.23.7-331-g000814d/79cc/lib/5.23.8
.

--
andreas

p5pRT · 2016-02-10T03:38:57Z

From @tonycoz

On Mon Feb 08 21:19:24 2016, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:

bisect
------
commit 000814d
Author: Tony Cook <tony@develop-help.com>
Date: Tue Jan 19 11:42:21 2016 +1100

[perl #124387] call AUTOLOAD when DESTROY isn't defined

Should be fixed by 7db8c4f (TODO test) and 958cdea.

I was caching the AUTOLOAD sub as the DESTROY sub, but then not setting $AUTOLOAD.

The first call to AUTOLOAD would have $AUTOLOAD set correctly but then the following calls using the cached CV wouldn't if any other subs needed AUTOLOADing before then.

Modifying to not cache the AUTOLOAD, so gv_autoload_pvn() always gets a chance to set things up correctly.

Tested with Module::Info and Pod::POM, which ribasushi pointed out to me in #p5p.

Tony

p5pRT · 2016-02-10T03:38:57Z

The RT System itself - Status changed from 'new' to 'open'

p5pRT · 2016-02-10T03:38:59Z

@tonycoz - Status changed from 'open' to 'pending release'

p5pRT · 2016-02-27T03:40:53Z

From @andk

On Tue, 9 Feb 2016 19:38:58 -0800, "Tony Cook via RT" <perlbug-followup@perl.org> said:

> Modifying to not cache the AUTOLOAD, so gv_autoload_pvn() always gets a chance to set things up correctly.

> Tested with Module::Info and Pod::POM, which ribasushi pointed out to me in #p5p.

Slaven sent me another one that broke on v5.23.7-331-g000814d:
IVANWILLS/WebService-SonarQube-0.06.tar.gz also reported as
https://rt.cpan.org/Ticket/Display.html?id=112436

--
andreas

p5pRT · 2016-03-13T21:12:14Z

From @andk

Also affected: PERLJEDI/Test-Mock-Wrapper-0.17.tar.gz
Matrix: http://matrix.cpantesters.org/?dist=Test-Mock-Wrapper%200.17
rt-cpan: https://rt.cpan.org/Ticket/Display.html?id=112965&results=407ec9b027c55d3a59399c046419306d

Note that both Test-Mock-Wrapper-0.17 and WebService-SonarQube-0.06 fail
with recent blead.

--
andreas

p5pRT · 2016-03-13T22:32:21Z

@tonycoz - Status changed from 'pending release' to 'open'

p5pRT · 2016-03-13T22:56:22Z

From @tonycoz

On Sun Mar 13 14:12:14 2016, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:

Also affected: PERLJEDI/Test-Mock-Wrapper-0.17.tar.gz
Matrix: http://matrix.cpantesters.org/?dist=Test-Mock-
Wrapper%200.17
rt-cpan:
https://rt.cpan.org/Ticket/Display.html?id=112965&results=407ec9b027c55d3a59399c046419306d

Note that both Test-Mock-Wrapper-0.17 and WebService-SonarQube-0.06
fail
with recent blead.

Thanks, I've re-opened this ticket and I'm looking into it.

Tony

p5pRT · 2016-03-14T03:46:59Z

From @tonycoz

On Sun Mar 13 14:12:14 2016, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:

Also affected: PERLJEDI/Test-Mock-Wrapper-0.17.tar.gz
Matrix: http://matrix.cpantesters.org/?dist=Test-Mock-
Wrapper%200.17
rt-cpan:
https://rt.cpan.org/Ticket/Display.html?id=112965&results=407ec9b027c55d3a59399c046419306d

Note that both Test-Mock-Wrapper-0.17 and WebService-SonarQube-0.06
fail
with recent blead.

I believe this is a bug in each of those modules.

Neither handles DESTROY as the method name in their AUTOLOAD method.

Adding an early exit to Test::Mock::Wrapped::AUTOLOAD allows it to pass its tests. The latest version of Test::Mock::Wrapper

WebService-SonarQube fails in 5.16 and earlier with the same errors as it does in blead, and since the regression this bug fixed was introduced in 5.18, its again the same problem - not handling DESTROY in AUTOLOAD.

Tony

p5pRT · 2016-03-14T21:09:31Z

From @andk

Thanks, Tony, for looking into those BBCs, highly appreciated! I've
forwarded your assessment to the respective rt-cpan tickets.

--
andreas

p5pRT · 2016-04-21T01:47:04Z

From @jkeenan

On Mon Mar 14 14:09:31 2016, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:

Thanks, Tony, for looking into those BBCs, highly appreciated! I've
forwarded your assessment to the respective rt-cpan tickets.

Tony, andreas: Is this ticket closable?

Thank you very much.

--
James E Keenan (jkeenan@cpan.org)

p5pRT · 2016-08-06T20:32:07Z

From @khwilliamson

On Wed Apr 20 18:47:04 2016, jkeenan wrote:

On Mon Mar 14 14:09:31 2016, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:

Thanks, Tony, for looking into those BBCs, highly appreciated! I've
forwarded your assessment to the respective rt-cpan tickets.

Tony, andreas: Is this ticket closable?

Thank you very much.

Bumping. Is this ticket closable?
--
Karl Williamson

p5pRT · 2016-08-07T08:23:44Z

From @andk

On Sat, 06 Aug 2016 13:32:07 -0700, "Karl Williamson via RT" <perlbug-followup@perl.org> said:

> On Wed Apr 20 18:47:04 2016, jkeenan wrote:

On Mon Mar 14 14:09:31 2016, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:

Thanks, Tony, for looking into those BBCs, highly appreciated! I've
forwarded your assessment to the respective rt-cpan tickets.

Tony, andreas: Is this ticket closable?

Thank you very much.

> Bumping. Is this ticket closable?

Yes. Bycatches have also got new releases and could be closed.

Thanks,
--
andreas

p5pRT · 2016-12-06T21:23:58Z

From @jkeenan

On Sun, 07 Aug 2016 08:23:44 GMT, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:

On Sat, 06 Aug 2016 13:32:07 -0700, "Karl Williamson via RT"
<perlbug-followup@perl.org> said:

On Wed Apr 20 18:47:04 2016, jkeenan wrote:

On Mon Mar 14 14:09:31 2016,
andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:

Thanks, Tony, for looking into those BBCs, highly appreciated!
I've
forwarded your assessment to the respective rt-cpan tickets.

Tony, andreas: Is this ticket closable?

Thank you very much.

Bumping. Is this ticket closable?

Yes. Bycatches have also got new releases and could be closed.

| IVANWILLS/WebService-SonarQube-0.06.tar.gz |
https://rt.cpan.org/Ticket/Display.html?id=112436 | 0.08 |
| PERLJEDI/Test-Mock-Wrapper-0.17.tar.gz |
https://rt.cpan.org/Ticket/Display.html?id=112965 | 0.18 |

Thanks,

Closing per recommendation from Andreas.

--
James E Keenan (jkeenan@cpan.org)

p5pRT · 2016-12-06T21:23:58Z

@jkeenan - Status changed from 'open' to 'resolved'

p5pRT closed this as completed Dec 6, 2016

p5pRT added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Severity Low labels Oct 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bleadperl v5.23.7-331-g000814d breaks NEILB/Module-Info-0.37.tar.gz #15165

Bleadperl v5.23.7-331-g000814d breaks NEILB/Module-Info-0.37.tar.gz #15165

p5pRT commented Feb 9, 2016

p5pRT commented Feb 9, 2016

p5pRT commented Feb 10, 2016

p5pRT commented Feb 10, 2016

p5pRT commented Feb 10, 2016

p5pRT commented Feb 27, 2016

p5pRT commented Mar 13, 2016

p5pRT commented Mar 13, 2016

p5pRT commented Mar 13, 2016

p5pRT commented Mar 14, 2016

p5pRT commented Mar 14, 2016

p5pRT commented Apr 21, 2016

p5pRT commented Aug 6, 2016

p5pRT commented Aug 7, 2016

p5pRT commented Dec 6, 2016

p5pRT commented Dec 6, 2016

Bleadperl v5.23.7-331-g000814d breaks NEILB/Module-Info-0.37.tar.gz #15165

Bleadperl v5.23.7-331-g000814d breaks NEILB/Module-Info-0.37.tar.gz #15165

Comments

p5pRT commented Feb 9, 2016

p5pRT commented Feb 9, 2016

From @andk

p5pRT commented Feb 10, 2016

From @tonycoz

p5pRT commented Feb 10, 2016

p5pRT commented Feb 10, 2016

p5pRT commented Feb 27, 2016

From @andk

p5pRT commented Mar 13, 2016

From @andk

p5pRT commented Mar 13, 2016

p5pRT commented Mar 13, 2016

From @tonycoz

p5pRT commented Mar 14, 2016

From @tonycoz

p5pRT commented Mar 14, 2016

From @andk

p5pRT commented Apr 21, 2016

From @jkeenan

p5pRT commented Aug 6, 2016

From @khwilliamson

p5pRT commented Aug 7, 2016

From @andk

p5pRT commented Dec 6, 2016

From @jkeenan

p5pRT commented Dec 6, 2016