Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH 7/11] Configure: support non-perl5 package, and use its installstyle #14586

Open
p5pRT opened this issue Mar 14, 2015 · 3 comments
Open

Comments

@p5pRT
Copy link

p5pRT commented Mar 14, 2015

Migrated from rt.perl.org#124067 (status was 'new')

Searchable as RT124067$

@p5pRT
Copy link
Author

p5pRT commented Mar 14, 2015

From @rurban

This is a bug report for perl from rurban@​cpanel.net,
generated with the help of perlbug 1.40 running under perl 5.21.9.


Configure​: support non-perl5 package, and use its installstyle
 
There are inconsistencies in various places for lib/perl5 vs
lib/$package.
The perl -V test also needs to check against $Config{package}
in t/run/switches.t
 
The package is not guaranteed to be called perl5, it can be overridden.
Tux​: This needs to go into metaconfig also.

Perl Info
-----------------------------------------------------------------
---
Flags:
category=core
severity=medium
Type=Patch
PatchStatus=HasPatch
---
Site configuration information for perl 5.21.9:

Configured by rurban at Sun Feb 22 17:14:55 CET 2015.

Summary of my perl5 (revision 5 version 21 subversion 9) configuration:

Platform:
osname=linux, osvers=3.16.0-4-amd64, archname=x86_64-linux-debug
uname='linux reini 3.16.0-4-amd64 #1 smp debian 3.16.7-ckt2-1 (2014-12-08) x86_64 gnulinux '
config_args='-de -Dusedevel -Uversiononly -Dinstallman1dir=none -Dinstallman3dir=none -Dinstallsiteman1dir=none -Dinstallsiteman3dir=none -DEBUGGING -Doptimize='-g3' -Uuseithreads -D'cc=gcc-5.0' -Accflags=''-msse4.2'' -Accflags=''-march=corei7'' -Dcf_email=''rurban@cpanel.net'' -Dperladmin=''rurban@cpanel.net'''
hint=recommended, useposix=true, d_sigaction=define
useithreads=undef, usemultiplicity=undef
use64bitint=define, use64bitall=define, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='gcc-5.0', ccflags ='-msse4.2 -march=corei7 -fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
optimize='-g3',
cppflags='-msse4.2 -march=corei7 -fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
ccversion='', gccversion='5.0.0 20150103 (experimental)', gccosandvers=''
intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='gcc-5.0', ldflags =' -fstack-protector-strong -L/usr/local/lib'
libpth=/usr/local/lib /usr/local/lib/gcc/x86_64-unknown-linux-gnu/5.0.0/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64 /usr/local/lib64
libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a
gnulibc_version='2.19'
Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
cccdlflags='-fPIC', lddlflags='-shared -g3 -L/usr/local/lib -fstack-protector-strong'

Locally applied patches:
Devel::PatchPerl 1.30

---
@INC for perl 5.21.9:
/usr/local/lib/perl5/site_perl/5.21.9/x86_64-linux-debug
/usr/local/lib/perl5/site_perl/5.21.9
/usr/local/lib/perl5/5.21.9/x86_64-linux-debug
/usr/local/lib/perl5/5.21.9
/usr/local/lib/perl5/site_perl/5.21.8
/usr/local/lib/perl5/site_perl/5.21.7
/usr/local/lib/perl5/site_perl/5.21.4
/usr/local/lib/perl5/site_perl/5.21.3
/usr/local/lib/perl5/site_perl/5.21.2
/usr/local/lib/perl5/site_perl/5.21.1
/usr/local/lib/perl5/site_perl/5.21.0
/usr/local/lib/perl5/site_perl/5.20.1
/usr/local/lib/perl5/site_perl/5.20.0
/usr/local/lib/perl5/site_perl/5.19.11
/usr/local/lib/perl5/site_perl/5.19.10
/usr/local/lib/perl5/site_perl/5.19.9
/usr/local/lib/perl5/site_perl/5.19.8
/usr/local/lib/perl5/site_perl/5.19.7
/usr/local/lib/perl5/site_perl/5.19.6
/usr/local/lib/perl5/site_perl/5.19.5
/usr/local/lib/perl5/site_perl/5.19.4
/usr/local/lib/perl5/site_perl/5.19.3
/usr/local/lib/perl5/site_perl/5.19.2
/usr/local/lib/perl5/site_perl/5.19.1
/usr/local/lib/perl5/site_perl/5.19.0
/usr/local/lib/perl5/site_perl/5.18.4
/usr/local/lib/perl5/site_perl/5.18.2
/usr/local/lib/perl5/site_perl/5.18.1
/usr/local/lib/perl5/site_perl/5.18.0
/usr/local/lib/perl5/site_perl/5.17.11
/usr/local/lib/perl5/site_perl/5.17.10
/usr/local/lib/perl5/site_perl/5.17.8
/usr/local/lib/perl5/site_perl/5.17.7
/usr/local/lib/perl5/site_perl/5.17.6
/usr/local/lib/perl5/site_perl/5.17.5
/usr/local/lib/perl5/site_perl/5.17.4
/usr/local/lib/perl5/site_perl/5.17.3
/usr/local/lib/perl5/site_perl/5.17.2
/usr/local/lib/perl5/site_perl/5.17.1
/usr/local/lib/perl5/site_perl/5.17.0
/usr/local/lib/perl5/site_perl/5.17
/usr/local/lib/perl5/site_perl/5.16.3
/usr/local/lib/perl5/site_perl/5.16.2
/usr/local/lib/perl5/site_perl/5.16.1
/usr/local/lib/perl5/site_perl/5.16.0
/usr/local/lib/perl5/site_perl/5.15.9
/usr/local/lib/perl5/site_perl/5.15.8
/usr/local/lib/perl5/site_perl/5.15.7
/usr/local/lib/perl5/site_perl/5.15.6
/usr/local/lib/perl5/site_perl/5.15.5
/usr/local/lib/perl5/site_perl/5.15.4
/usr/local/lib/perl5/site_perl/5.15.3
/usr/local/lib/perl5/site_perl/5.15.2
/usr/local/lib/perl5/site_perl/5.14.4
/usr/local/lib/perl5/site_perl/5.14.3
/usr/local/lib/perl5/site_perl/5.14.2
/usr/local/lib/perl5/site_perl/5.14.1
/usr/local/lib/perl5/site_perl/5.12.5
/usr/local/lib/perl5/site_perl/5.12.4
/usr/local/lib/perl5/site_perl/5.10.1
/usr/local/lib/perl5/site_perl/5.8.9
/usr/local/lib/perl5/site_perl/5.8.8
/usr/local/lib/perl5/site_perl/5.8.7
/usr/local/lib/perl5/site_perl/5.8.6
/usr/local/lib/perl5/site_perl/5.8.5
/usr/local/lib/perl5/site_perl/5.8.4
/usr/local/lib/perl5/site_perl/5.8.3
/usr/local/lib/perl5/site_perl/5.8.2
/usr/local/lib/perl5/site_perl/5.8.1
/usr/local/lib/perl5/site_perl/5.6.2
/usr/local/lib/perl5/site_perl
.

---
Environment for perl 5.21.9:
HOME=/home/rurban
LANG=en_US.utf8
LANGUAGE (unset)
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH=/home/rurban/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
PERL_BADLANG (unset)
SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Mar 14, 2015

From @rurban

0001-Configure-support-non-perl5-package-and-use-its-inst.patch
From e82caf38d083a00b829f154bd6d83b1dd5a43081 Mon Sep 17 00:00:00 2001
From: Reini Urban <rurban@cpanel.net>
Date: Fri, 13 Mar 2015 23:34:47 +0100
Subject: [PATCH] Configure: support non-perl5 package, and use its
 installstyle

There are inconsistencies in various places for lib/perl5 vs
lib/$package.
The perl -V test also needs to check against $Config{package}
in t/run/switches.t

The package is not guaranteed to be called perl5, it can be overridden.
---
 Configure        | 11 ++++++-----
 t/run/switches.t |  2 +-
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git Configure Configure
index 0a405d3..10902f8 100755
--- Configure
+++ Configure
@@ -7156,9 +7156,9 @@ esac'
 case "$installstyle" in
 '')	case "$prefix" in
 		*perl*) dflt='lib';;
-		*) dflt='lib/perl5' ;;
+		*) dflt="lib/$package" ;;
 	esac
-	;;
+        ;;
 *)	dflt="$installstyle" ;;
 esac
 : Probably not worth prompting for this since we prompt for all
@@ -7222,7 +7222,8 @@ esac
 : /opt/perl/lib/perl5... would be redundant.
 : The default "style" setting is made in installstyle.U
 case "$installstyle" in
-*lib/perl5*) set dflt privlib lib/$package/$version ;;
+*lib/perl5*)    set dflt privlib lib/$package/$version ;;
+*lib/$package*) set dflt privlib lib/$package/$version ;;
 *)	 set dflt privlib lib/$version ;;
 esac
 eval $prefixit
@@ -7470,7 +7471,7 @@ siteprefixexp="$ansexp"
 prog=`echo $package | $sed 's/-*[0-9.]*$//'`
 case "$sitelib" in
 '') case "$installstyle" in
-	*lib/perl5*) dflt=$siteprefix/lib/$package/site_$prog/$version ;;
+	*lib/$package*) dflt=$siteprefix/lib/$package/site_$prog/$version ;;
 	*)	 dflt=$siteprefix/lib/site_$prog/$version ;;
 	esac
 	;;
@@ -7888,7 +7889,7 @@ case "$vendorprefix" in
 	'')
 		prog=`echo $package | $sed 's/-*[0-9.]*$//'`
 		case "$installstyle" in
-		*lib/perl5*) dflt=$vendorprefix/lib/$package/vendor_$prog/$version ;;
+		*lib/$package*) dflt=$vendorprefix/lib/$package/vendor_$prog/$version ;;
 		*)	     dflt=$vendorprefix/lib/vendor_$prog/$version ;;
 		esac
 		;;
diff --git t/run/switches.t t/run/switches.t
index 78915e0..bda2ca9 100644
--- t/run/switches.t
+++ t/run/switches.t
@@ -269,7 +269,7 @@ is runperl(stderr => 1, prog => '#!perl -M'),
           '-V generates 20+ lines' );
 
     like( runperl( switches => ['-V'] ),
-	  qr/\ASummary of my perl5 .*configuration:/,
+	  qr/\ASummary of my $Config{package} .*configuration:/,
           '-V looks okay' );
 
     # lookup a known config var
-- 
2.1.4

@toddr
Copy link
Member

toddr commented Jan 31, 2020

@Tux merge or close?

@xenu xenu removed the Severity Low label Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants