Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/op/exp.t: add description to test #12587

Closed
p5pRT opened this issue Nov 18, 2012 · 7 comments
Closed

t/op/exp.t: add description to test #12587

p5pRT opened this issue Nov 18, 2012 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 18, 2012

Migrated from rt.perl.org#115798 (status was 'resolved')

Searchable as RT115798$

@p5pRT
Copy link
Author

p5pRT commented Nov 18, 2012

From bobernststl@gmail.com

Created at the St. Louis Perl Monger Hackathon, please review.

@p5pRT
Copy link
Author

p5pRT commented Nov 18, 2012

From bobernststl@gmail.com

0004-Add-descriptions-to-tests-for-exp.t.patch
From dcfe34b5ae387ad290a913732b3ed8f234e98225 Mon Sep 17 00:00:00 2001
From: Bob Ernst <bobernst@cpan.org>
Date: Sun, 18 Nov 2012 00:03:58 +0000
Subject: [PATCH 4/4] Add descriptions to tests for exp.t

---
 t/op/exp.t |   32 ++++++++++++++++----------------
 1 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/t/op/exp.t b/t/op/exp.t
index 9bc44b4..d132b1f 100644
--- a/t/op/exp.t
+++ b/t/op/exp.t
@@ -11,24 +11,24 @@ plan tests => 16;
 # compile time evaluation
 
 $s = sqrt(2);
-is(substr($s,0,5), '1.414');
+is(substr($s,0,5), '1.414', 'compile time sqrt(2) == 1.414');
 
 $s = exp(1);
-is(substr($s,0,7), '2.71828');
+is(substr($s,0,7), '2.71828', 'compile time exp(1) == e');
 
-cmp_ok(exp(log(1)), '==', 1);
+cmp_ok(exp(log(1)), '==', 1, 'compile time exp(log(1)) == 1');
 
 # run time evaluation
 
 $x1 = 1;
 $x2 = 2;
 $s = sqrt($x2);
-is(substr($s,0,5), '1.414');
+is(substr($s,0,5), '1.414', 'run time sqrt(2) == 1.414');
 
 $s = exp($x1);
-is(substr($s,0,7), '2.71828');
+is(substr($s,0,7), '2.71828', 'run time exp(1) = e');
 
-cmp_ok(exp(log($x1)), '==', 1);
+cmp_ok(exp(log($x1)), '==', 1, 'run time exp(log(1)) == 1');
 
 # tests for transcendental functions
 
@@ -41,18 +41,18 @@ sub round {
 }
 
 # sin() tests
-cmp_ok(sin(0), '==', 0.0);
-cmp_ok(round(sin($pi)), '==', 0.0);
-cmp_ok(round(sin(-1 * $pi)), '==', 0.0);
-cmp_ok(round(sin($pi_2)), '==', 1.0);
-cmp_ok(round(sin(-1 * $pi_2)), '==', -1.0);
+cmp_ok(sin(0), '==', 0.0, 'sin(0) == 0');
+cmp_ok(round(sin($pi)), '==', 0.0, 'sin(pi) == 0');
+cmp_ok(round(sin(-1 * $pi)), '==', 0.0, 'sin(-pi) == 0');
+cmp_ok(round(sin($pi_2)), '==', 1.0, 'sin(pi/2) == 1');
+cmp_ok(round(sin(-1 * $pi_2)), '==', -1.0, 'sin(-pi/2) == -1');
 
 # cos() tests
-cmp_ok(cos(0), '==', 1.0);
-cmp_ok(round(cos($pi)), '==', -1.0);
-cmp_ok(round(cos(-1 * $pi)), '==', -1.0);
-cmp_ok(round(cos($pi_2)), '==', 0.0);
-cmp_ok(round(cos(-1 * $pi_2)), '==', 0.0);
+cmp_ok(cos(0), '==', 1.0, 'cos(0) == 1');
+cmp_ok(round(cos($pi)), '==', -1.0, 'cos(pi) == -1');
+cmp_ok(round(cos(-1 * $pi)), '==', -1.0, 'cos(-pi) == -1');
+cmp_ok(round(cos($pi_2)), '==', 0.0, 'cos(pi/2) == 0');
+cmp_ok(round(cos(-1 * $pi_2)), '==', 0.0, 'cos(-pi/2) == 0');
 
 # atan2() tests were removed due to differing results from calls to
 # atan2() on various OS's and architectures.  See perlport.pod for
-- 
1.7.2.5

@p5pRT
Copy link
Author

p5pRT commented Nov 20, 2012

From @jkeenan

On Sat Nov 17 16​:09​:13 2012, bobernststl@​gmail.com wrote​:

Created at the St. Louis Perl Monger Hackathon, please review.

I have reviewed this patch and believe it should be applied. I have
taken the ticket for that purpose and will apply it in seven days unless
someone beats me to it or objects to the patch.

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Nov 20, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2012

From @jkeenan

Patch committed to blead in commit e759bc3

Closing ticket. Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2012

From [Unknown Contact. See original ticket]

Patch committed to blead in commit e759bc3

Closing ticket. Thank you very much.
Jim Keenan

@p5pRT p5pRT closed this as completed Nov 26, 2012
@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2012

@jkeenan - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant