Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/op/fh.t: add description to test #12585

Closed
p5pRT opened this issue Nov 17, 2012 · 7 comments
Closed

t/op/fh.t: add description to test #12585

p5pRT opened this issue Nov 17, 2012 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 17, 2012

Migrated from rt.perl.org#115794 (status was 'resolved')

Searchable as RT115794$

@p5pRT
Copy link
Author

p5pRT commented Nov 17, 2012

From bobernststl@gmail.com

Created at the St. Louis Perl Monger Hackathon, please review.

@p5pRT
Copy link
Author

p5pRT commented Nov 17, 2012

From bobernststl@gmail.com

0003-Add-descriptions-to-tests-for-fh.t.patch
From 0faf8125ea7c48543515946a668a4e08c7edf112 Mon Sep 17 00:00:00 2001
From: Bob Ernst <bobernst@cpan.org>
Date: Sat, 17 Nov 2012 22:14:53 +0000
Subject: [PATCH 3/3] Add descriptions to tests for fh.t

---
 t/op/fh.t |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/t/op/fh.t b/t/op/fh.t
index 16ba186..1e29d47 100644
--- a/t/op/fh.t
+++ b/t/op/fh.t
@@ -12,18 +12,18 @@ plan tests => 8;
 
 $|=1;
 my $a = "SYM000";
-ok(!defined(fileno($a)));
-ok(!defined *{$a});
+ok(!defined(fileno($a)), 'initial file handle is undefined');
+ok(!defined *{$a}, 'initiall typeglob of file handle is undefined');
 
 select select $a;
-ok(defined *{$a});
+ok(defined *{$a}, 'typeglob of file handle defined after select');
 
 $a++;
-ok(!close $a);
-ok(!defined *{$a});
+ok(!close $a, 'close does not succeed with incremented file handle');
+ok(!defined *{$a}, 'typeglob of file handle not defined after increment');
 
-ok(open($a, ">&STDOUT"));
-ok(defined *{$a});
+ok(open($a, ">&STDOUT"), 'file handle used with open of standard output');
+ok(defined *{$a}, 'typeglob of file handle defined after opening standard output');
 
-ok(close $a);
+ok(close $a, 'close standard output via file handle;');
 
-- 
1.7.2.5

@p5pRT
Copy link
Author

p5pRT commented Nov 20, 2012

From @jkeenan

On Sat Nov 17 14​:18​:30 2012, bobernststl@​gmail.com wrote​:

Created at the St. Louis Perl Monger Hackathon, please review.

I have reviewed this patch and believe it should be applied. I have
taken the ticket for that purpose and will apply it in seven days unless
someone beats me to it or objects to the patch.

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Nov 20, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2012

From @jkeenan

Patch committed to blead in commit 66745c0

Closing ticket. Thank you very much.

Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2012

From [Unknown Contact. See original ticket]

Patch committed to blead in commit 66745c0

Closing ticket. Thank you very much.

Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2012

@jkeenan - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant