New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carp is missing a dot #11814
Comments
From @cpansproutThis was brought up in #96672 but needs its own ticket: $ perl -e 'die' Where did my dot go? The hard part is deciding what to do about cluck(). Flags: Site configuration information for perl 5.15.5: Configured by sprout at Sun Dec 18 11:26:14 PST 2011. Summary of my perl5 (revision 5 version 15 subversion 5) configuration: Locally applied patches: @INC for perl 5.15.5: Environment for perl 5.15.5: |
From @cpansproutOn Sun Dec 18 19:56:10 2011, sprout wrote:
In commit 879b0ca, Zefram has solved this by adding the dot to -- Father Chrysostomos |
From [Unknown Contact. See original ticket]On Sun Dec 18 19:56:10 2011, sprout wrote:
In commit 879b0ca, Zefram has solved this by adding the dot to -- Father Chrysostomos |
@cpansprout - Status changed from 'new' to 'resolved' |
From zefram@fysh.orgFather Chrysostomos wrote:
Added to Carp as 879b0ca. This required
I added the dot only to the base message, and left the stack trace -zefram |
From @LeontOn Thu, Feb 2, 2012 at 5:39 PM, Father Chrysostomos via RT
I'm worried this will break tests of CPAN modules that rely a little Leon |
From zefram@fysh.orgLeon Timmermans wrote:
There presumably will be a few. It's an easy fix for each. I think it's -zefram |
From @LeontOn Thu, Feb 2, 2012 at 6:00 PM, Zefram <zefram@fysh.org> wrote:
I'm fine with updating my module, it's trivial indeed. I'm worried Leon |
From @toddrOn Thu Feb 02 09:17:06 2012, LeonT wrote:
So far, I've found needed test fixes in: autodie, Error, Log4perl and counting. |
From zefram@fysh.orgTodd Rinaldo via RT wrote:
Not very many, then. This is looking viable. -zefram |
From @hvds"Todd Rinaldo via RT" <perlbug-followup@perl.org> wrote: One thing worth mentioning: along the lines of Nick's recent patch to Maybe the presence or absence of a trailing full-stop is not the ideal Hugo |
From @tseeOn 02/10/2012 05:01 PM, Zefram wrote:
If somebody supplies me with two commits to run a CPAN smoke for, then I --Steffen |
From zefram@fysh.orgSteffen Mueller wrote:
Obvious choice is 62e9075 (before) -zefram |
From @demerphqOn 11 February 2012 11:15, <hv@crypt.org> wrote:
I agree. I'm pretty sure at least one port of perl adds error codes to cheers, -- |
From @tseeOn 02/11/2012 11:42 AM, Zefram wrote:
Running at http://users.perl5.git.perl.org/~tsee/progress.html Result to be at http://users.perl5.git.perl.org/~tsee/carp_errmsg/ Best regards, |
From @rurbanOn Sat, Feb 11, 2012 at 7:30 AM, Steffen Mueller <smueller@cpan.org> wrote:
Excellent. Muchas gracias! We provided patches for all but Sub-Uplevel-0.22 |
From @rjbs* demerphq <demerphq@gmail.com> [2012-02-11T06:28:21]
This is something I'd hoped to see quite a while ago, as part of a "exceptions We had talked about giving exceptions tags as well, at the time. -- |
From zefram@fysh.orgSteffen Mueller wrote:
Not yet complete, but now showing 28 distros that passed before and fail -zefram |
From @rurbanOn Wed, Feb 15, 2012 at 5:42 AM, Zefram <zefram@fysh.org> wrote:
This made a lot of people angry, not only people who had their CPAN modules Carp's only API is the string return value. Changing the API would have required an API bump, like Carp2 or use Carp (-dot). |
From zefram@fysh.orgReini Urban wrote:
Anything you can point at? Blogs?
It's not a done deal. The dot change only exists in blead. I've In five days we'll have a 5.15.8 release, and whatever version of Carp it
By "CPAN" do you mean "all of the affected modules on CPAN"? I believe -zefram |
From @rurbanOn Wed, Feb 15, 2012 at 11:07 AM, Zefram <zefram@fysh.org> wrote:
Not publicly. Normal people do not blog or complain
"All of CPAN" we use, that is 652 of 29916 packages. The most common fraction. |
From @doyOn Wed, Feb 15, 2012 at 11:27:01AM -0600, Reini Urban wrote:
So how are we to know that they exist? We can't really go around asking -doy |
From @rurbanOn Wed, Feb 15, 2012 at 11:36 AM, Jesse Luehrs <doy@tozt.net> wrote:
Make the right decisions. |
From @doyOn Wed, Feb 15, 2012 at 12:38:39PM -0600, Reini Urban wrote:
Oh, is it really that easy? -doy |
From @rurbanOn Wed, Feb 15, 2012 at 12:40 PM, Jesse Luehrs <doy@tozt.net> wrote:
Sorry, I forgot: marketing. Persuade people why they must change their code. |
From @doyOn Wed, Feb 15, 2012 at 12:42:02PM -0600, Reini Urban wrote:
Which people? The only method of communication we have with the majority -doy |
From @rjbs* Zefram <zefram@fysh.org> [2012-02-15T06:42:56]
It's a bummer that, if released, this will be the second change to this I think this should be corrected. Hopefully the next changes we have to make I had a quick glance over the smoke changes looking for core modules and the Reini suggested on IRC, today, that he had already been in touch with all the -- |
From @tseeOn 02/16/2012 02:03 AM, Ricardo Signes wrote:
Now up to ~30-35 degradations. Reini qualified his statement as "the I expect that at least a handful of the modules would require taking --Steffen |
From zefram@fysh.orgRicardo Signes wrote:
My commit to modify Carp did edit the autodie test in core. But not in -zefram |
From @rjbs* "Andreas J. Koenig" [2012-02-29T02:18:50]
Steffen's smoke setup *was* involved, and the output was compared, and we There were some problems with this assumption, some of which have been * "Andreas J. Koenig" [2012-02-29T02:18:50]
For example, I didn't realize that the smoke reporting toolchain was affected * "Andreas J. Koenig" [2012-02-29T02:18:50]
With hindsight, I would have done things differently. I don't agree that ...as long as it doesn't break smoke reports. As for it being February: yes, it was pretty late in the game. As Zefram What I overlooked as that they changed the error message in a *much* smaller * demerphq [2012-02-29T03:17:05]
I'm not really happy with this counter-argument. The problem is that yes, I thought about this, too, and hoped that by the next time we wanted to talk This was only a very minor consideration, though. * demerphq [2012-02-29T03:17:05]
In a nutshell: many did. For example, they only looked at the first line, * Chris Prather [2012-02-29T05:32:57]
Certainly, many more of them should than now do. More of them should have a * Zefram [2012-02-29T06:40:12]
Well, we *did* run it through a CPAN smoke. The problem was not looking at As I said much earlier, I thought we'd be able to revert the change if we $pattern .= $Carp::VERSION gt "1.24" ? "." :""; ...which means that a reversion in 1.30 would require all the libraries that * Zefram [2012-02-29T06:40:12]
I agree wholeheartedly. It's a lot of work to make this happen, but it would * Zefram [2012-02-29T06:40:12]
This is my feeling, too. I made a judgment call, and in hindsight, I would But I don't plan to fall on my sword over this. I just plan to keep it in -- |
From @demerphqOn 29 February 2012 15:26, Ricardo Signes <perl.p5p@rjbs.manxome.org> wrote:
That focuses too much on the details of the instant case. You need to On the other hand, I agree with your point. When I dealt with the
I like the general idea. But again, it does not address my core point
How about ok($@= Anyway, the core point here is that if we have not made a promise I mean consider the massive list of things that we might have to worry Anyway, all this aside, my view is that our default choice of action Yves -- |
From @rjbs* demerphq <demerphq@gmail.com> [2012-02-29T09:52:01]
I totally agree with you on this general point. -- |
From @greergaOn Wed, 29 Feb 2012, Nicholas Clark wrote:
I had a script that did CPAN testers smoking against blead/maint-X that I 1) updated a minicpan I had wanted to make it smarter so it kept state of the modules but When I get home I'll see if I still have that around, at least. It -- |
From @greergaOn Wed, 29 Feb 2012, Nicholas Clark wrote:
If I can get a copy of the "build all of CPAN" script that the comparisons
What's on your wishlist? -- |
From alex.hartmaier@gmail.comMaybe I wasn't clear enough: if blead breaks some module on CPAN that's I don't see how a blead smoke prevents that from happening for a dual-lifed -Alex (abraxxa) On Wed, Feb 29, 2012 at 4:46 PM, George Greer <perl@greerga.m-l.org> wrote:
|
From zefram@fysh.orgAlexander Hartmaier wrote:
Interesting. It doesn't break *all* installations, but only those that Some of the recent dual-life Carp versions have had more or less subtle
A smoke test of blead *against CPAN* (not just against the blead test
The change was noted, but not explicitly marked as significant. Would a -zefram |
From @tseeOn 02/29/2012 11:57 AM, Nicholas Clark wrote:
It's not just that. While I did expend the effort to write tools for I suppose I could fill the gap between "run the following couple of
Yes, but requires a fair amount of effort to set up and maintain. That's --Steffen |
From @tseeOn 02/29/2012 03:26 PM, Ricardo Signes wrote:
The CPAN smoke report has this data. In all fairness, it doesn't scream
I think I'd estimate this automation to be two full days of work to get Doesn't take a rocket scientist, but a fair bit of toolchain clue,
Agreed. --Steffen |
From @tseeOn 02/29/2012 12:11 PM, Chris Prather wrote:
It takes a Google-alike infrastructure to do that. Not just a couple of So no, not going to get there. It'll need a bit of a judgement call. Also, we'd not only want to smoke each commit against its predecessor, --Steffen |
From @doyOn Wed, Feb 29, 2012 at 09:41:40PM +0100, Steffen Mueller wrote:
How much effort would it be to set this up on another machine? How much -doy |
From @tseeOn 02/29/2012 09:44 PM, Jesse Luehrs wrote:
Effort: It's a bit fiddly, but I'd say setting up another takes no more CPU? However much you can throw at it. Disk? Proportional to how much The current CPAN smoker runs for a couple of days (not quite a week, This all being said, I'm perfectly willing to spend some time with you Cheers, |
From @tseeOn 02/29/2012 09:44 PM, Jesse Luehrs wrote:
Rats, forgot the link: https://github.com/tsee/cpan_perl_branch_smoke --Steffen |
From nick@nickandperla.netOn Wed, 29 Feb 2012 11:27:46 +0000
Color me interest-piqued. I am not familiar enough with the entire
-- Nicholas Perez |
From @nwc10On Wed, Feb 29, 2012 at 10:46:43AM -0500, George Greer wrote:
I think you'd need to ask Steffen where that is
I fear that this isn't complete, as I think I've forgotten something. It's partly that (as best I can tell) the code you're running locally has In particular, I'd like everyone else to run your code, because of a couple of * the subject using the branch name is terser * the smoke-me code mails me directly if the branch fails but also I'd like a couple of visibility bugs in your setup to be fixed: X X O X X X O X -Uusenm -Duseithreads -Dmad 8 results vs 6 annotations, or 4 results vs 2 annotations: O F F F after which I guess that there are more general skimming issues with the First off, I'm not sure whether the line "Summary: PASS" (or FAIL...) should Nicholas Clark |
From @nwc10On Mon, Mar 26, 2012 at 05:12:55PM +0100, Nicholas Clark wrote:
Oops, I don't have an alias for Steffen as "steffen". Correct cc now there. Clearly "spell checker" is not the only check I need before hitting "send" Nicholas Clark |
From @nwc10On Wed, Feb 29, 2012 at 09:26:37AM -0500, Ricardo Signes wrote:
Sigh. Yes, encoding a new golden result is the short-term easiest fix.
Including being in-your-face clear about what the right and wrong way to It can be really quite frustrating how our maneuverability can be thwarted Nicholas Clark |
From @tseeOn 03/26/2012 06:15 PM, Nicholas Clark wrote:
It's here: https://github.com/tsee/cpan_perl_branch_smoke The README should mostly have step-by-step instructions. There's a whole Let me know if you have questions. Best regards, |
From @doyOn Mon, Mar 26, 2012 at 05:12:55PM +0100, Nicholas Clark wrote:
Then wouldn't it be even more useful to have the PASS(...)/FAIL(...) bit -doy |
From @TuxOn Mon, 26 Mar 2012 17:12:55 +0100, Nicholas Clark <nick@ccl4.org>
We can change that (too)
That might be amongst several new options
That will probably be possible too in the new setup. The QAH is just a -- |
From @nwc10On Mon, Mar 26, 2012 at 11:39:52AM -0500, Jesse Luehrs wrote:
I thought about that, but forgot to say that that makes it hard to sort by Nicholas Clark |
From @nwc10On Mon, Mar 26, 2012 at 06:52:12PM +0200, H.Merijn Brand wrote:
This would all be cool. Its your valuable Parisian drinking time I care for. Honest :-) Nicholas Clark |
From @greerga(due to an ADSL outage this is copy/pasted from the web archives)
My Test::Smoke customizations are: 1. Run 'make minitest' in addition to other tests. (Although I never did 2. I moved the "user_note" to the very top of the reports instead of the 3. Also allow ".config" suffix on configurations. (Previously "_config".) 4. Get version (what is between the brackets in smoke email subject line)
I thought that was rather silly too. I didn't add that to Test::Smoke
That's a function of the 'smoke-me' script, not Test::Smoke, although I My configuration for that is: driver/smoke-me_clang_quick.config.template: and the 'smoke-me' script does some variable replacements before making (For those who may not know, the smoke-me script:
True, that's necessary for any 'smoke-me' service, Although the dashboard I wonder if he has that on github...
Yes, my adding 'minitest' to all runs did that. I do need to fix that.
I agree. My biggest wishlist for Test::Smoke is (automatically) keeping
There was a paucity of replies to this particular thread so we may never -- |
From @TuxOn Wed, 4 Apr 2012 21:02:07 -0400 (EDT), George Greer
If others find that useful too, we should make that optional.
That should have been solved in the new setup
That is in a template in the new version, moving it to other places is
Abe?
As no mails will be send, this is moot
In the new setup, logs are being sent to the database is the final
The new setup registers start time of every smoke-configuration subset
Sporadic failures should now be detectable, as we store failures per
We will be on #smoke in irc.perl.org to discuss wishes (when possible) -- |
From @nwc10On Thu, Apr 05, 2012 at 09:38:15AM +0200, H.Merijn Brand wrote:
Well, I find it useful that at least one smoker is running it.
Not totally. I'd still like to be getting mails for my failed smoke-me
oooh. nice.
Good question.
Yes, please magically find time to fix it :-) Although it might be better to spend that same time migrating to the new
Nice
I suspect we (also)(for some value of we) need to be more systematic in Easiest way to make that happen seems to be to make a question about smoke Nicholas Clark |
From @greergaOn Thu, 5 Apr 2012, H.Merijn Brand wrote:
It does keep track of the git branch in the database though, correct?
Is there functionality to ignore certain tests failing on particular -- |
Migrated from rt.perl.org#106538 (status was 'resolved')
Searchable as RT106538$
The text was updated successfully, but these errors were encountered: