Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‘Perl folding rules...’ is in the deprecated category #11291

Closed
p5pRT opened this issue May 1, 2011 · 11 comments
Closed

‘Perl folding rules...’ is in the deprecated category #11291

p5pRT opened this issue May 1, 2011 · 11 comments

Comments

@p5pRT
Copy link

p5pRT commented May 1, 2011

Migrated from rt.perl.org#89648 (status was 'resolved')

Searchable as RT89648$

@p5pRT
Copy link
Author

p5pRT commented May 1, 2011

From @cpansprout

This warning message​:

  Perl folding rules are not up-to-date for 0x%x; please use the perlbug utility to report;

is in both �regexp� and �deprecated� warning categories. It is under deprecated warnings so that it has a better chance of showing up.

I think this logic is faulty, because it�s not the deprecatedness that makes a warning show up by default, but its defaultness; i.e., whether Perl_ck_warner_d is used instead of Perl_ck_warner. The wide character warning, for instance, is not under �deprecated�, but only �utf8�. Yet it�s a default warning marked as S in perldiag. I think this message should be treated similarly (and listed with (S regex)).


Flags​:
  category=core
  severity=low


Site configuration information for perl 5.14.0​:

Configured by sprout at Wed Apr 20 14​:02​:52 PDT 2011.

Summary of my perl5 (revision 5 version 14 subversion 0) configuration​:
  Snapshot of​: 476c37e
  Platform​:
  osname=darwin, osvers=10.5.0, archname=darwin-thread-multi-2level
  uname='darwin pint.local 10.5.0 darwin kernel version 10.5.0​: fri nov 5 23​:20​:39 pdt 2010; root​:xnu-1504.9.17~1release_i386 i386 '
  config_args='-Dusedevel -de -Duseithreads -Doptimize=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=undef, use64bitall=undef, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
  optimize='-g',
  cppflags='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.2.1 (Apple Inc. build 5664)', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib
  libs=-ldbm -ldl -lm -lutil -lc
  perllibs=-ldl -lm -lutil -lc
  libc=/usr/lib/libc.dylib, so=dylib, useshrplib=false, libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib -fstack-protector'

Locally applied patches​:
  RC1


@​INC for perl 5.14.0​:
  /usr/local/lib/perl5/site_perl/5.14.0/darwin-thread-multi-2level
  /usr/local/lib/perl5/site_perl/5.14.0
  /usr/local/lib/perl5/5.14.0/darwin-thread-multi-2level
  /usr/local/lib/perl5/5.14.0
  /usr/local/lib/perl5/site_perl
  .


Environment for perl 5.14.0​:
  DYLD_LIBRARY_PATH (unset)
  HOME=/Users/sprout
  LANG=en_US.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/usr/bin​:/bin​:/usr/sbin​:/sbin​:/usr/local/bin​:/usr/X11/bin​:/usr/local/bin
  PERL_BADLANG (unset)
  SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2013

From @jkeenan

On Sun May 01 14​:06​:15 2011, sprout wrote​:

This warning message​:

Perl folding rules are not up\-to\-date for 0x%x; please use the

perlbug utility to report;

is in both �regexp� and �deprecated� warning categories. It is under
deprecated warnings so that it has a better chance of showing up.

I think this logic is faulty, because it�s not the deprecatedness that
makes a warning show up by default, but its defaultness; i.e.,
whether Perl_ck_warner_d is used instead of Perl_ck_warner. The
wide character warning, for instance, is not under �deprecated�,
but only �utf8�. Yet it�s a default warning marked as S in
perldiag. I think this message should be treated similarly (and
listed with (S regex)).

Please review the patch attached.

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2013

From @jkeenan

0001-Move-folding-rules-warning-from-D-to-S.patch
From 89d2296fecd95190a76188c7e886eaafb0b1010f Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Sat, 16 Feb 2013 19:58:26 -0500
Subject: [PATCH] Move folding rules warning from 'D' to 'S'.

For RT #89648
---
 pod/perldiag.pod |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/pod/perldiag.pod b/pod/perldiag.pod
index c5fdbb6..8c710bd 100644
--- a/pod/perldiag.pod
+++ b/pod/perldiag.pod
@@ -3871,12 +3871,10 @@ that a method requires a package that has not been loaded.
 =item Perl folding rules are not up-to-date for 0x%X; please use the perlbug 
 utility to report; in regex; marked by <-- HERE in m/%s/
 
-(D regexp, deprecated) You used a regular expression with
-case-insensitive matching, and there is a bug in Perl in which the
-built-in regular expression folding rules are not accurate.  This may
-lead to incorrect results.  Please report this as a bug using the
-"perlbug" utility.  (This message is marked deprecated, so that it by
-default will be turned-on.)
+(S regexp) You used a regular expression with case-insensitive matching,
+and there is a bug in Perl in which the built-in regular expression
+folding rules are not accurate.  This may lead to incorrect results.
+Please report this as a bug using the "perlbug" utility.
 
 =item Perl_my_%s() not available
 
-- 
1.6.3.2

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2013

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2013

From @cpansprout

On Sat Feb 16 17​:21​:06 2013, jkeenan wrote​:

On Sun May 01 14​:06​:15 2011, sprout wrote​:

This warning message​:

Perl folding rules are not up\-to\-date for 0x%x; please use the

perlbug utility to report;

is in both �regexp� and �deprecated� warning categories. It is under
deprecated warnings so that it has a better chance of showing up.

I think this logic is faulty, because it�s not the deprecatedness that
makes a warning show up by default, but its defaultness; i.e.,
whether Perl_ck_warner_d is used instead of Perl_ck_warner. The
wide character warning, for instance, is not under �deprecated�,
but only �utf8�. Yet it�s a default warning marked as S in
perldiag. I think this message should be treated similarly (and
listed with (S regex)).

Please review the patch attached.

Thank you. But it only changes the entry in perldiag.pod. The warning
would still be triggered under �use warnings 'deprecated'; no warnings
'regexp';�, due to the use of ckWARN2regdep in regcomp.c (currently the
only use of that macro).

If nobody objects, I can easily change that part. When I submitted this
report, I was hoping this would be discussed.

Are there any objections?

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2013

From [Unknown Contact. See original ticket]

On Sat Feb 16 17​:21​:06 2013, jkeenan wrote​:

On Sun May 01 14​:06​:15 2011, sprout wrote​:

This warning message​:

Perl folding rules are not up\-to\-date for 0x%x; please use the

perlbug utility to report;

is in both �regexp� and �deprecated� warning categories. It is under
deprecated warnings so that it has a better chance of showing up.

I think this logic is faulty, because it�s not the deprecatedness that
makes a warning show up by default, but its defaultness; i.e.,
whether Perl_ck_warner_d is used instead of Perl_ck_warner. The
wide character warning, for instance, is not under �deprecated�,
but only �utf8�. Yet it�s a default warning marked as S in
perldiag. I think this message should be treated similarly (and
listed with (S regex)).

Please review the patch attached.

Thank you. But it only changes the entry in perldiag.pod. The warning
would still be triggered under �use warnings 'deprecated'; no warnings
'regexp';�, due to the use of ckWARN2regdep in regcomp.c (currently the
only use of that macro).

If nobody objects, I can easily change that part. When I submitted this
report, I was hoping this would be discussed.

Are there any objections?

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Feb 23, 2013

From @iabyn

On Sun, Feb 17, 2013 at 01​:49​:57PM -0800, Father Chrysostomos via RT wrote​:

This warning message​:

Perl folding rules are not up\-to\-date for 0x%x; please use the

perlbug utility to report;

is in both �regexp� and �deprecated� warning categories. It is under
deprecated warnings so that it has a better chance of showing up.

I think this logic is faulty, because it�s not the deprecatedness that
makes a warning show up by default, but its defaultness; i.e.,
whether Perl_ck_warner_d is used instead of Perl_ck_warner. The
wide character warning, for instance, is not under �deprecated�,
but only �utf8�. Yet it�s a default warning marked as S in
perldiag. I think this message should be treated similarly (and
listed with (S regex)).

Please review the patch attached.

Thank you. But it only changes the entry in perldiag.pod. The warning
would still be triggered under �use warnings 'deprecated'; no warnings
'regexp';�, due to the use of ckWARN2regdep in regcomp.c (currently the
only use of that macro).

If nobody objects, I can easily change that part. When I submitted this
report, I was hoping this would be discussed.

Are there any objections?

Not from me; seems sensible.

--
Never work with children, animals, or actors.

@p5pRT
Copy link
Author

p5pRT commented Jul 13, 2013

From @jkeenan

On Sun Feb 17 13​:49​:56 2013, sprout wrote​:

On Sat Feb 16 17​:21​:06 2013, jkeenan wrote​:

On Sun May 01 14​:06​:15 2011, sprout wrote​:

This warning message​:

Perl folding rules are not up\-to\-date for 0x%x; please use the

perlbug utility to report;

is in both �regexp� and �deprecated� warning categories. It is under
deprecated warnings so that it has a better chance of showing up.

I think this logic is faulty, because it�s not the deprecatedness that
makes a warning show up by default, but its defaultness; i.e.,
whether Perl_ck_warner_d is used instead of Perl_ck_warner. The
wide character warning, for instance, is not under �deprecated�,
but only �utf8�. Yet it�s a default warning marked as S in
perldiag. I think this message should be treated similarly (and
listed with (S regex)).

Please review the patch attached.

Thank you. But it only changes the entry in perldiag.pod. The warning
would still be triggered under �use warnings 'deprecated'; no warnings
'regexp';�, due to the use of ckWARN2regdep in regcomp.c (currently the
only use of that macro).

If nobody objects, I can easily change that part. When I submitted this
report, I was hoping this would be discussed.

Are there any objections?

Father C​: No objections were received. Would it be possible to pick up
on the code changes you had in mind?

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Jul 13, 2013

From @cpansprout

On Fri Jul 12 18​:12​:59 2013, jkeenan wrote​:

On Sun Feb 17 13​:49​:56 2013, sprout wrote​:

On Sat Feb 16 17​:21​:06 2013, jkeenan wrote​:

On Sun May 01 14​:06​:15 2011, sprout wrote​:

This warning message​:

Perl folding rules are not up\-to\-date for 0x%x; please use the

perlbug utility to report;

is in both �regexp� and �deprecated� warning categories. It is under
deprecated warnings so that it has a better chance of showing up.

I think this logic is faulty, because it�s not the
deprecatedness that
makes a warning show up by default, but its defaultness; i.e.,
whether Perl_ck_warner_d is used instead of Perl_ck_warner. The
wide character warning, for instance, is not under �deprecated�,
but only �utf8�. Yet it�s a default warning marked as S in
perldiag. I think this message should be treated similarly (and
listed with (S regex)).

Please review the patch attached.

Thank you. But it only changes the entry in perldiag.pod. The warning
would still be triggered under �use warnings 'deprecated'; no warnings
'regexp';�, due to the use of ckWARN2regdep in regcomp.c (currently the
only use of that macro).

If nobody objects, I can easily change that part. When I submitted this
report, I was hoping this would be discussed.

Are there any objections?

Father C​: No objections were received. Would it be possible to pick up
on the code changes you had in mind?

I have made the changes in b23eb18. I applied your patch in 6014bd2.
perldiag needed to be updated to understand the new macro, which I did
in 0008e92. And diagnostics.pm needed to be tweak to look for a
different string, which I did in 80f7813.

Thank you.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Jul 13, 2013

From [Unknown Contact. See original ticket]

On Fri Jul 12 18​:12​:59 2013, jkeenan wrote​:

On Sun Feb 17 13​:49​:56 2013, sprout wrote​:

On Sat Feb 16 17​:21​:06 2013, jkeenan wrote​:

On Sun May 01 14​:06​:15 2011, sprout wrote​:

This warning message​:

Perl folding rules are not up\-to\-date for 0x%x; please use the

perlbug utility to report;

is in both �regexp� and �deprecated� warning categories. It is under
deprecated warnings so that it has a better chance of showing up.

I think this logic is faulty, because it�s not the
deprecatedness that
makes a warning show up by default, but its defaultness; i.e.,
whether Perl_ck_warner_d is used instead of Perl_ck_warner. The
wide character warning, for instance, is not under �deprecated�,
but only �utf8�. Yet it�s a default warning marked as S in
perldiag. I think this message should be treated similarly (and
listed with (S regex)).

Please review the patch attached.

Thank you. But it only changes the entry in perldiag.pod. The warning
would still be triggered under �use warnings 'deprecated'; no warnings
'regexp';�, due to the use of ckWARN2regdep in regcomp.c (currently the
only use of that macro).

If nobody objects, I can easily change that part. When I submitted this
report, I was hoping this would be discussed.

Are there any objections?

Father C​: No objections were received. Would it be possible to pick up
on the code changes you had in mind?

I have made the changes in b23eb18. I applied your patch in 6014bd2.
perldiag needed to be updated to understand the new macro, which I did
in 0008e92. And diagnostics.pm needed to be tweak to look for a
different string, which I did in 80f7813.

Thank you.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Jul 13, 2013

@cpansprout - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant