Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.12.0-110-g7ce0928 breaks JBEVERLY/Memoize-Expire-ByInstance-0.500001.tar.gz #11226

Closed
p5pRT opened this issue Apr 2, 2011 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Apr 2, 2011

Migrated from rt.perl.org#87650 (status was 'resolved')

Searchable as RT87650$

@p5pRT
Copy link
Author

p5pRT commented Apr 2, 2011

From @andk

rt.cpan ticket​:


  https://rt.cpan.org/Ticket/Display.html?id=66988

git bisect​:


  v5.12.0-110-g7ce0928 was written for 5.12 and then merged into blead.
  It is between v5.13.0-158-g99782e3 and v5.13.0-154-g4e2ac26.

  commit 7ce0928
  Author​: Zefram <zefram@​fysh.org>
  Date​: Fri Apr 23 02​:22​:54 2010 +0100

  bring G_KEEPERR back to the realm of sanity
 
  Makes the G_KEEPERR logic more consistent, and in particular make it
  sensibly handle non-string exceptions. An exception in a destructor
  is now always emitted as a warning, and never copied or merged into
  $@​ of the surrounding context. No more clobbering exceptions being
  handled elsewhere, and no more double reporting. This fixes the rest of
  [perl #74538].

perl -V​:


  Summary of my perl5 (revision 5 version 13 subversion 0) configuration​:
  Commit id​: 7ce0928
  Platform​:
  osname=linux, osvers=2.6.32-5-amd64, archname=x86_64-linux
  uname='linux k81 2.6.32-5-amd64 #1 smp wed jan 12 03​:40​:32 utc 2011 x86_64 gnulinux '
  config_args='-Dprefix=/home/src/perl/repoperls/installed-perls/perl/v5.12.0-110-g7ce0928 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Uuseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2 -g',
  cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.5.2', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib /usr/lib /lib64 /usr/lib64
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=/lib/libc-2.11.2.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.11.2'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

  Characteristics of this binary (from libperl)​:
  Compile-time options​: PERL_DONT_CREATE_GVSV PERL_MALLOC_WRAP PERL_USE_DEVEL
  USE_64_BIT_ALL USE_64_BIT_INT USE_LARGE_FILES
  USE_PERLIO USE_PERL_ATOF
  Built under linux
  Compiled at Apr 2 2011 05​:30​:31
  @​INC​:
  /home/src/perl/repoperls/installed-perls/perl/v5.12.0-110-g7ce0928/lib/site_perl/5.13.0/x86_64-linux
  /home/src/perl/repoperls/installed-perls/perl/v5.12.0-110-g7ce0928/lib/site_perl/5.13.0
  /home/src/perl/repoperls/installed-perls/perl/v5.12.0-110-g7ce0928/lib/5.13.0/x86_64-linux
  /home/src/perl/repoperls/installed-perls/perl/v5.12.0-110-g7ce0928/lib/5.13.0
  .

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2011

From @cpansprout

On Sat Apr 02 01​:09​:10 2011, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

rt.cpan ticket​:
---------------

https://rt.cpan.org/Ticket/Display.html?id=66988

git bisect​:
-----------

v5.12.0-110-g7ce0928 was written for 5.12 and then merged into
blead.
It is between v5.13.0-158-g99782e3 and v5.13.0-154-g4e2ac26.

commit 7ce0928
Author​: Zefram <zefram@​fysh.org>
Date​: Fri Apr 23 02​:22​:54 2010 +0100

bring G\_KEEPERR back to the realm of sanity

Makes the G\_KEEPERR logic more consistent\, and in particular make

it
sensibly handle non-string exceptions. An exception in a
destructor
is now always emitted as a warning, and never copied or merged
into
$@​ of the surrounding context. No more clobbering exceptions
being
handled elsewhere, and no more double reporting. This fixes the
rest of
[perl #74538].

This module’s tests are expecting $@​ to contain something immediately
after a successful eval{}. I think the module’s tests need to adjust to
using a $SIG{__WARN__} handler.

Hence, I do not think this needs to be a 5.14 blocker.

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2011

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2011

From @obra

On Sun Apr 10 18​:34​:54 2011, sprout wrote​:

This module’s tests are expecting $@​ to contain something immediately
after a successful eval{}. I think the module’s tests need to adjust to
using a $SIG{__WARN__} handler.

Hence, I do not think this needs to be a 5.14 blocker.

If we have a reasonable description of the change in behavior in the perldelta, I'm +1 for this to be resolved.

@p5pRT
Copy link
Author

p5pRT commented Apr 13, 2011

From @obra

On Sun Apr 10 19​:03​:59 2011, jesse wrote​:

On Sun Apr 10 18​:34​:54 2011, sprout wrote​:

This module’s tests are expecting $@​ to contain something
immediately
after a successful eval{}. I think the module’s tests need to adjust
to
using a $SIG{__WARN__} handler.

Hence, I do not think this needs to be a 5.14 blocker.

If we have a reasonable description of the change in behavior in the
perldelta, I'm +1 for this to be resolved.

Having read the relevant section of perldelta, I think we do have such a
description. Resolving.

@p5pRT
Copy link
Author

p5pRT commented Apr 13, 2011

@obra - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant