New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.13.10-341-gcf34198 breaks NWIGER/CGI-FormBuilder-3.0501.tgz #11189
Comments
From @andkgit bisect: cf34198 is the first bad commit regcomp.c: Change start class init for /l Before /l was added, locale only applied to regular expressions as a example fail report: cpantesters do not have a fail report yet. Excerpt of test output from Note: PERL_TEST_DIFF="diff -u" make test TEST_FILES=t/1a-generate.t # perl -V: Summary of my perl5 (revision 5 version 13 subversion 10) configuration: Characteristics of this binary (from libperl): -- |
From @andk
> http://rt.perl.org/rt3/Ticket/Display.html?id=85964 More candidates affected by this change: VOJ/DAIA-0.31.tar.gz -- |
From @demerphqOn 15 March 2011 08:46, Andreas J. Koenig
This can be reduced to the following one liner in blead $ ./perl -Ilib -Mre=debug -le'$s = For some reason Karls patch has changed the STCLASS to be Also it looks like the class is somehow case insensitive, which doesnt cheers, -- |
The RT System itself - Status changed from 'new' to 'open' |
From @demerphqOn 15 March 2011 09:57, demerphq <demerphq@gmail.com> wrote:
And this is what it used to look like: $ perl -mre=debug -le'$s = Yves -- |
From @demerphqThe offending patch looks like this: commit cf34198 regcomp.c: Change start class init for /l Before /l was added, locale only applied to regular expressions as a Inline Patchdiff --git a/regcomp.c b/regcomp.c
index 53047ee..18079ff 100644
--- a/regcomp.c
+++ b/regcomp.c
@@ -726,9 +726,7 @@ S_cl_anything(const RExC_state_t *pRExC_state,
ANYOF_CLASS_ZERO(cl); /* Can match anything (initialization) */ /* 'And' a given class with another one. Can create false positives */ Unfortunately however it doesnt revert cleanly, and when i try to However some observations: adding ANYOF_LOCALE to this bitmap doesnt Consider that the *meaning* of SPACE/NSPACE under use locale has to be Looking into things, it seems that this code under use locale would cheers, -- |
From @khwilliamsonOn 03/15/2011 03:41 AM, demerphq wrote:
I stayed up late last night, and now have a solution to this, which I |
From @nwc10On Tue, Mar 15, 2011 at 07:17:51AM -0600, Karl Williamson wrote:
This makes me think of: Grumble, grumble. What's with all this sleep and eat stuff? I never (Yitzchak Scott-Thoennes in <20031031163808.GA708@efn.org> and intended to Nicholas Clark |
From @khwilliamsonOn 03/15/2011 07:53 AM, Nicholas Clark wrote:
For me, at my age, staying up late means midnight. Anyway, I chatted |
From @khwilliamsonThe commit message explains this patch, which was delayed from my I haven't tested the other modules that Andreas said might be broken --Karl Williamson |
@khwilliamson - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#85964 (status was 'resolved')
Searchable as RT85964$
The text was updated successfully, but these errors were encountered: