Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.13.7-400-g2786be7 breaks DANKOGAI/Attribute-Constant-0.02.tar.gz #10894

Closed
p5pRT opened this issue Dec 12, 2010 · 5 comments
Closed

Comments

@p5pRT
Copy link

p5pRT commented Dec 12, 2010

Migrated from rt.perl.org#80610 (status was 'resolved')

Searchable as RT80610$

@p5pRT
Copy link
Author

p5pRT commented Dec 12, 2010

From @andk

git bisect​:


  commit 2786be7
  Author​: Karl Williamson <public@​khwilliamson.com>
  Date​: Tue Dec 7 22​:51​:34 2010 -0700

  regcomp.c​: Clean up optimization for 1-char []

example failreport​:


  pasted, since it's not yet on cpantesters​:

  PERL_DL_NONLAZY=1 /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/bin/perl "-MExtUtils​::Command​::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
  t/00-load.t ....... 1/1 # Testing Attribute​::Constant 0.02, Perl 5.013007, /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/bin/perl
  t/00-load.t ....... ok
  t/01-atomic.t ..... Insecure dependency in eval while running with -T switch at /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/5.13.7/Attribute/Handlers.pm line 218.
  # Looks like your test exited with 255 before it could output anything.
  t/01-atomic.t ..... Dubious, test returned 255 (wstat 65280, 0xff00)
  Failed 10/10 subtests
  t/02-avhv.t ....... Insecure dependency in eval while running with -T switch at /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/5.13.7/Attribute/Handlers.pm line 218.
  # Looks like your test exited with 255 before it could output anything.
  t/02-avhv.t ....... Dubious, test returned 255 (wstat 65280, 0xff00)
  Failed 18/18 subtests
  t/03-obj.t ........ Insecure dependency in eval while running with -T switch at /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/5.13.7/Attribute/Handlers.pm line 218.
  # Looks like your test exited with 255 before it could output anything.
  t/03-obj.t ........ Dubious, test returned 255 (wstat 65280, 0xff00)
  Failed 10/10 subtests
  t/04-dlock.t ...... ok
  t/pod-coverage.t .. skipped​: Test​::Pod​::Coverage 1.08 required for testing POD coverage
  t/pod.t ........... skipped​: Test​::Pod 1.22 required for testing POD

  Test Summary Report
  -------------------
  t/01-atomic.t (Wstat​: 65280 Tests​: 0 Failed​: 0)
  Non-zero exit status​: 255
  Parse errors​: Bad plan. You planned 10 tests but ran 0.
  t/02-avhv.t (Wstat​: 65280 Tests​: 0 Failed​: 0)
  Non-zero exit status​: 255
  Parse errors​: Bad plan. You planned 18 tests but ran 0.
  t/03-obj.t (Wstat​: 65280 Tests​: 0 Failed​: 0)
  Non-zero exit status​: 255
  Parse errors​: Bad plan. You planned 10 tests but ran 0.
  Files=7, Tests=11, 0 wallclock secs ( 0.05 usr 0.00 sys + 0.18 cusr 0.04 csys = 0.27 CPU)
  Result​: FAIL
  Failed 3/7 test programs. 0/11 subtests failed.

perl -V​:


  Summary of my perl5 (revision 5 version 13 subversion 7) configuration​:
  Commit id​: 2786be7
  Platform​:
  osname=linux, osvers=2.6.32-5-xen-amd64, archname=x86_64-linux-thread-multi
  uname='linux k81 2.6.32-5-xen-amd64 #1 smp thu nov 25 20​:08​:32 utc 2010 x86_64 gnulinux '
  config_args='-Dprefix=/home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dnoextensions=Encode -Duseithreads -Uuse64bitint'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.4.5', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib /usr/lib /lib64 /usr/lib64
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=/lib/libc-2.11.2.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.11.2'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'

  Characteristics of this binary (from libperl)​:
  Compile-time options​: MULTIPLICITY PERL_DONT_CREATE_GVSV
  PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP PERL_USE_DEVEL
  USE_64_BIT_ALL USE_64_BIT_INT USE_ITHREADS
  USE_LARGE_FILES USE_PERLIO USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Dec 12 2010 10​:58​:32
  @​INC​:
  /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/site_perl/5.13.7/x86_64-linux-thread-multi
  /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/site_perl/5.13.7
  /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/5.13.7/x86_64-linux-thread-multi
  /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/5.13.7
  .

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Dec 12, 2010

From @khwilliamson

(Andreas J. Koenig) (via RT) wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #80610]
# in the subject line of all future correspondence about this issue.
# <URL​: http​://rt.perl.org/rt3/Ticket/Display.html?id=80610 >

git bisect​:
-----------

commit 2786be7
Author​: Karl Williamson <public@​khwilliamson.com>
Date​: Tue Dec 7 22​:51​:34 2010 -0700

regcomp.c​: Clean up optimization for 1-char []

example failreport​:
-------------------

Now fixed. As noted in the commit message, the root cause was that I
conflated two similarly named macros, and I don't know how many times I
looked at the code without realizing it. I was planning to change the
name of one of them anyway, to better reflect its meaning, but I don't
know that that would have helped.

  commit 929fffa
  Author​: Karl Williamson <public@​khwilliamson.com>
  Date​: Sun Dec 12 11​:28​:20 2010 -0700

  blead breaks Attribute​::Constant

  The problem is that I confused FOLD with ANYOF_FOLD, and as a result,
  emitted a locale regnode, which is tainted. Any tests that required
  non-tainting started failing

pasted, since it's not yet on cpantesters​:

PERL_DL_NONLAZY=1 /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/bin/perl "-MExtUtils​::Command​::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/00-load.t ....... 1/1 # Testing Attribute​::Constant 0.02, Perl 5.013007, /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/bin/perl
t/00-load.t ....... ok
t/01-atomic.t ..... Insecure dependency in eval while running with -T switch at /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/5.13.7/Attribute/Handlers.pm line 218.
# Looks like your test exited with 255 before it could output anything.
t/01-atomic.t ..... Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 10/10 subtests
t/02-avhv.t ....... Insecure dependency in eval while running with -T switch at /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/5.13.7/Attribute/Handlers.pm line 218.
# Looks like your test exited with 255 before it could output anything.
t/02-avhv.t ....... Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 18/18 subtests
t/03-obj.t ........ Insecure dependency in eval while running with -T switch at /home/src/perl/repoperls/installed-perls/perl/v5.13.7-400-g2786be7/lib/5.13.7/Attribute/Handlers.pm line 218.
# Looks like your test exited with 255 before it could output anything.
t/03-obj.t ........ Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 10/10 subtests
t/04-dlock.t ...... ok
t/pod-coverage.t .. skipped​: Test​::Pod​::Coverage 1.08 required for testing POD coverage
t/pod.t ........... skipped​: Test​::Pod 1.22 required for testing POD

Test Summary Report
-------------------
t/01-atomic.t (Wstat​: 65280 Tests​: 0 Failed​: 0)
Non-zero exit status​: 255
Parse errors​: Bad plan. You planned 10 tests but ran 0.
t/02-avhv.t (Wstat​: 65280 Tests​: 0 Failed​: 0)
Non-zero exit status​: 255
Parse errors​: Bad plan. You planned 18 tests but ran 0.
t/03-obj.t (Wstat​: 65280 Tests​: 0 Failed​: 0)
Non-zero exit status​: 255
Parse errors​: Bad plan. You planned 10 tests but ran 0.
Files=7, Tests=11, 0 wallclock secs ( 0.05 usr 0.00 sys + 0.18 cusr 0.04 csys = 0.27 CPU)
Result​: FAIL
Failed 3/7 test programs. 0/11 subtests failed.

@p5pRT
Copy link
Author

p5pRT commented Dec 12, 2010

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Dec 12, 2010

From @khwilliamson

commit 929fffa
Author​: Karl Williamson <public@​khwilliamson.com>
Date​: Sun Dec 12 11​:28​:20 2010 -0700

  blead breaks Attribute​::Constant

  The problem is that I confused FOLD with ANYOF_FOLD, and as a result,
  emitted a locale regnode, which is tainted. Any tests that required
  non-tainting started failing

@p5pRT
Copy link
Author

p5pRT commented Dec 12, 2010

@khwilliamson - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant