Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: [PATCH] APIify scope() and mod() #10805

Closed
p5pRT opened this issue Nov 7, 2010 · 11 comments
Closed

Re: [PATCH] APIify scope() and mod() #10805

p5pRT opened this issue Nov 7, 2010 · 11 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 7, 2010

Migrated from rt.perl.org#78908 (status was 'resolved')

Searchable as RT78908$

@p5pRT
Copy link
Author

p5pRT commented Nov 7, 2010

From @cpansprout

Forwarding to RT, so it is not forgotten​:

On November 1, 2010 05​:54, Reini Urban wrote​:

2010/10/27 Father Chrysostomos <sprout@​cpan.org>​:

Zefram wrote​:

Attached patch puts two more op manipulation functions that are going
to be required by syntax plugins into the API.

Thank you. Applied as 3ad73ef.

I find the original documentation vastly superior to the new one.
Cannot we have the examples back in?

diff --git a/op.c b/op.c
index cfa9d6b..1502628 100644
--- a/op.c
+++ b/op.c

-/* Propagate lvalue ("modifiable") context to an op and its children.
- * 'type' represents the context type, roughly based on the type of op that
- * would do the modifying, although local() is represented by OP_NULL.
- * It's responsible for detecting things that can't be modified, flag
- * things that need to behave specially in an lvalue context (e.g., "$$x = 5"
- * might have to vivify a reference in $x), and so on.
- *
- * For example, "$a+1 = 2" would cause mod() to be called with o being
- * OP_ADD and type being OP_SASSIGN, and would output an error.
- */
+/*
+=for apidoc Amx|OP *|op_lvalue|OP *o|I32 type
+
+Propagate lvalue ("modifiable") context to an op and its children.
+I<type> represents the context type, roughly based on the type of op that
+would do the modifying, although C<local()> is represented by OP_NULL,
+because it has no op type of its own (it is signalled by a flag on
+the lvalue op). This function detects things that can't be modified,
+such as C<$x+1>, and generates errors for them. It also flags things
+that need to behave specially in an lvalue context, such as C<$$x>
+which might have to vivify a reference in C<$x>.
+
+=cut
+*/

Also, cannot we keep mod as deprecated API for one deprecation cycle?
EXp |OP* |mod |NULLOK OP* o|I32 type
--
Reini Urban
http​://phpwiki.org/ http​://murbreak.at/


Flags​:
  category=core
  severity=low


Site configuration information for perl 5.13.6​:

Configured by sprout at Thu Oct 28 17​:49​:54 PDT 2010.

Summary of my perl5 (revision 5 version 13 subversion 6) configuration​:
  Commit id​: 6911354
  Platform​:
  osname=darwin, osvers=10.4.0, archname=darwin-thread-multi-ld-2level
  uname='darwin pint.local 10.4.0 darwin kernel version 10.4.0​: fri apr 23 18​:28​:53 pdt 2010; root​:xnu-1504.7.4~1release_i386 i386 '
  config_args='-de -Dusedevel -DDEBUGGING -Duseithreads -Duselongdouble'
  hint=previous, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=undef, use64bitall=undef, uselongdouble=define
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-common -DPERL_DARWIN -no-cpp-precomp -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
  optimize='-O3 -g',
  cppflags='-no-cpp-precomp -fno-common -DPERL_DARWIN -no-cpp-precomp -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.2.1 (Apple Inc. build 5664)', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=4, nvtype='long double', nvsize=16, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib
  libs=-ldbm -ldl -lm -lutil -lc
  perllibs=-ldl -lm -lutil -lc
  libc=/usr/lib/libc.dylib, so=dylib, useshrplib=false, libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib -fstack-protector'

Locally applied patches​:
 


@​INC for perl 5.13.6​:
  /usr/local/lib/perl5/site_perl/5.13.5/darwin-thread-multi-ld-2level
  /usr/local/lib/perl5/site_perl/5.13.5
  /usr/local/lib/perl5/5.13.5/darwin-thread-multi-ld-2level
  /usr/local/lib/perl5/5.13.5
  /usr/local/lib/perl5/site_perl
  .


Environment for perl 5.13.6​:
  DYLD_LIBRARY_PATH (unset)
  HOME=/Users/sprout
  LANG=en_US.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/usr/bin​:/bin​:/usr/sbin​:/sbin​:/usr/local/bin​:/usr/X11/bin​:/usr/local/bin
  PERL_BADLANG (unset)
  SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2010

From @cpansprout

Resolved by 001c3c5 and 37fa633.

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2010

From [Unknown Contact. See original ticket]

Resolved by 001c3c5 and 37fa633.

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2010

@cpansprout - Status changed from 'new' to 'resolved'

@p5pRT p5pRT closed this as completed Nov 26, 2010
@p5pRT
Copy link
Author

p5pRT commented Nov 27, 2010

From @cpansprout

On Fri Nov 26 15​:58​:56 2010, sprout wrote​:

Resolved by 001c3c5 and 37fa633.

That should have been 8b47453, not 37fa633.

@p5pRT
Copy link
Author

p5pRT commented Nov 27, 2010

From [Unknown Contact. See original ticket]

On Fri Nov 26 15​:58​:56 2010, sprout wrote​:

Resolved by 001c3c5 and 37fa633.

That should have been 8b47453, not 37fa633.

@p5pRT
Copy link
Author

p5pRT commented Jul 31, 2011

From @cpansprout

On Sun Nov 07 12​:35​:41 2010, sprout wrote​:

Forwarding to RT, so it is not forgotten​:

On November 1, 2010 05​:54, Reini Urban wrote​:

Also, cannot we keep mod as deprecated API for one deprecation
cycle?
EXp |OP* |mod |NULLOK OP* o|I32 type
--
Reini Urban
http​://phpwiki.org/ http​://murbreak.at/

Do you mind if I remove it now?

@p5pRT
Copy link
Author

p5pRT commented Jul 31, 2011

From [Unknown Contact. See original ticket]

On Sun Nov 07 12​:35​:41 2010, sprout wrote​:

Forwarding to RT, so it is not forgotten​:

On November 1, 2010 05​:54, Reini Urban wrote​:

Also, cannot we keep mod as deprecated API for one deprecation
cycle?
EXp |OP* |mod |NULLOK OP* o|I32 type
--
Reini Urban
http​://phpwiki.org/ http​://murbreak.at/

Do you mind if I remove it now?

@p5pRT
Copy link
Author

p5pRT commented Aug 1, 2011

From @rurban

2011/7/31 Father Chrysostomos via RT <perlbug-comment@​perl.org>​:

On Sun Nov 07 12​:35​:41 2010, sprout wrote​:

Forwarding to RT, so it is not forgotten​:

On November 1, 2010 05​:54, Reini Urban wrote​:

Also, cannot we keep mod as deprecated API for one deprecation
   cycle?
EXp |OP*    |mod            |NULLOK OP* o|I32 type
--
Reini Urban
http​://phpwiki.org/           http​://murbreak.at/

Do you mind if I remove it now?

No, go ahead.
..
Reini

@p5pRT
Copy link
Author

p5pRT commented Aug 2, 2011

From @cpansprout

On Sun Jul 31 20​:47​:58 2011, rurban wrote​:

2011/7/31 Father Chrysostomos via RT <perlbug-comment@​perl.org>​:

On Sun Nov 07 12​:35​:41 2010, sprout wrote​:

Forwarding to RT, so it is not forgotten​:

On November 1, 2010 05​:54, Reini Urban wrote​:

Also, cannot we keep mod as deprecated API for one deprecation
� �cycle?
EXp |OP* � �|mod � � � � � �|NULLOK OP* o|I32 type
--
Reini Urban
http​://phpwiki.org/ � � � � � http​://murbreak.at/

Do you mind if I remove it now?

No, go ahead.
..
Reini

Now done with commit 10654d5.

@p5pRT
Copy link
Author

p5pRT commented Aug 2, 2011

From [Unknown Contact. See original ticket]

On Sun Jul 31 20​:47​:58 2011, rurban wrote​:

2011/7/31 Father Chrysostomos via RT <perlbug-comment@​perl.org>​:

On Sun Nov 07 12​:35​:41 2010, sprout wrote​:

Forwarding to RT, so it is not forgotten​:

On November 1, 2010 05​:54, Reini Urban wrote​:

Also, cannot we keep mod as deprecated API for one deprecation
� �cycle?
EXp |OP* � �|mod � � � � � �|NULLOK OP* o|I32 type
--
Reini Urban
http​://phpwiki.org/ � � � � � http​://murbreak.at/

Do you mind if I remove it now?

No, go ahead.
..
Reini

Now done with commit 10654d5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant