New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMS::Filespec and PVLV globs #10586
Comments
From @cpansproutThere are three instances of ‘SvTYPE(mysv) == SVt_PVGV’ in vms/vms.c, one in candelete_fromperl and two in rmscopy_from_perl. I think they should actually be isGV_with_GP(mysv). Without that change, a glob in a PVLV will not be recognised as a glob. Currently, a PVLV will never hold a glob, though that was supposed to be possible as of 5.9.1. Half the perl source code was modified to support them. See bug #77362. Once the patch for #77632 is applied, it should be possible to write failing tests for this. To test these you can put a glob in a PVLV by passing a nonexistent hash element to a subroutine and then assigning a glob to it: my %hash; Not having access to VMS, I am hesitant to write a patch myself, as I have no way of testing it. This perlbug -d output is quite meaningless, as it’s not for the machine on which this bug will occur: Flags: Site configuration information for perl 5.13.4: Configured by sprout at Fri Aug 20 23:24:53 PDT 2010. Summary of my perl5 (revision 5 version 13 subversion 4 patch v5.13.4-16-g16c9153) configuration: Locally applied patches: @INC for perl 5.13.4: Environment for perl 5.13.4: |
From @craigberryOn Sun, Aug 29, 2010 at 4:12 PM, Father Chrysostomos
Thanks for spotting this. The code in question has been there for http://perl5.git.perl.org/perl.git/blobdiff/fb4fc1fa and your suggestion sounds similar to what people have been doing in |
The RT System itself - Status changed from 'new' to 'open' |
From @craigberryOn Sun, Aug 29, 2010 at 10:17 PM, Craig A. Berry
Done in 6d24fbd. I see no new test failures.
I have not added any tests as I don't see quite what I can hang my hat $ type foo.pl sub some_sub { some_sub($hash{'nonexistent_key'}); Before the change, that gives me: $ perl foo.pl after the change: $ perl foo.pl Stepping through in the VMS debugger (the gdb equivalent), I've So I think it's working and the ticket can be closed, but there's more |
From @cpansproutOn Oct 3, 2010, at 5:15 PM, Craig Berry via RT wrote:
What happens if you create a temporary file, open it, and pass the handle to candelete? |
From @craigberryOn Sun, Oct 3, 2010 at 8:12 PM, Father Chrysostomos <sprout@cpan.org> wrote:
That still works. |
From @cpansproutOn Oct 3, 2010, at 7:44 PM, Craig Berry via RT wrote:
Then can you assign that handle to a PVLV and use it for testing? |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#77500 (status was 'resolved')
Searchable as RT77500$
The text was updated successfully, but these errors were encountered: