pod2html output concerns #10290

p5pRT · 2010-04-08T23:48:43Z

Migrated from rt.perl.org#74158 (status was 'resolved')

Searchable as RT74158$

p5pRT · 2010-04-08T23:48:44Z

From choward@indicium.us

Created by choward@indicium.us

I frequently use pod2html to generate HTML reports from POD-based work
documentation. However, I recently noticed that, by default, pod2html
includes the following line in the generated HTML file:

This is not a good default, because pod2html does not also include any
styling code for text color. As I wrote in a recent forum post
<http://linuxprogrammingforums.com/viewtopic.php?f=13&t=31#p53> if web
pages specify background color, they must also specify text color. This
is because often web clients or HTML readers render element color based
on system defaults or theme settings, which can change from system to
system. For example, on a system that uses an "inverted" theme, with
white text on a black background, specifying a white background color in
the style will cause white text to be displayed on a white background.

Obviously, a pod2html user can remove this line after generating the
output HTML, but chances are that he probably is not aware that it is
there, or that its presence could become an issue down the road. My
recommendation is to remove the pod2html code that generates this line,
and leave color choices entirely up to the client.

Perl Info


Flags:
    category=utilities
    severity=medium

Site configuration information for perl v5.8.8:

Configured by Gentoo at Tue Sep 15 15:37:49 Local time zone must be
set--see zic manual page 2009.

Summary of my perl5 (revision 5 version 8 subversion 8) configuration:
  Platform:
    osname=linux, osvers=2.6.28-hardened-r9-infra14, archname=i686-linux
    uname='linux poseidon 2.6.28-hardened-r9-infra14 #1 smp thu jul 16
15:39:45 utc 2009 i686 amd opteron(tm) processor 844 authenticamd gnulinux '
    config_args='-des -Darchname=i686-linux -Dcccdlflags=-fPIC
-Dccdlflags=-rdynamic -Dcc=i686-pc-linux-gnu-gcc -Dprefix=/usr
-Dvendorprefix=/usr -Dsiteprefix=/usr -Dlocincpth=  -Doptimize=-O2
-march=i686 -pipe -Duselargefiles -Dd_semctl_semun -Dscriptdir=/usr/bin
-Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3
-Dinstallman1dir=/usr/share/man/man1
-Dinstallman3dir=/usr/share/man/man3 -Dman1ext=1 -Dman3ext=3pm
-Dinc_version_list=5.8.0 5.8.0/i686-linux 5.8.2 5.8.2/i686-linux 5.8.4
5.8.4/i686-linux 5.8.5 5.8.5/i686-linux 5.8.6 5.8.6/i686-linux 5.8.7
5.8.7/i686-linux  -Dcf_by=Gentoo -Ud_csh -Dusenm -Di_ndbm -Di_gdbm -Di_db'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef use5005threads=undef useithreads=undef
usemultiplicity=undef
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='i686-pc-linux-gnu-gcc', ccflags ='-fno-strict-aliasing -pipe
-Wdeclaration-after-statement -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-I/usr/include/gdbm',
    optimize='-O2 -march=i686 -pipe',
    cppflags='-fno-strict-aliasing -pipe -Wdeclaration-after-statement
-I/usr/include/gdbm'
    ccversion='', gccversion='4.3.2', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='i686-pc-linux-gnu-gcc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=/lib/libc-2.9.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.9'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic'
    cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib'

Locally applied patches:



@INC for perl v5.8.8:
    /etc/perl
    /usr/lib/perl5/vendor_perl/5.8.8/i686-linux
    /usr/lib/perl5/vendor_perl/5.8.8
    /usr/lib/perl5/vendor_perl
    /usr/lib/perl5/site_perl/5.8.8/i686-linux
    /usr/lib/perl5/site_perl/5.8.8
    /usr/lib/perl5/site_perl
    /usr/lib/perl5/5.8.8/i686-linux
    /usr/lib/perl5/5.8.8
    /usr/local/lib/site_perl
    .


Environment for perl v5.8.8:
    HOME=/home/choward
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH=:/usr/local/lib
    LOGDIR (unset)

PATH=/usr/local/ossh/bin:/usr/local/krb5/bin:/usr/local/bin:/usr/bin:/bin:/opt/bin:/usr/i686-pc-linux-gnu/gcc-bin/4.3.2:/usr/kde/3.5/bin:/usr/qt/3/bin:/usr/games/bin
    PERL_BADLANG (unset)
    SHELL=/bin/bash

p5pRT · 2010-04-12T02:58:06Z

From @ap

Fixed by the included patch. (Sorry, couldn’t yet figure out how
to make `git send-email` work with my setup, or how to make mutt
recognise MIME multipart draft messages.)

lib/Pod/Html.pm | 6 ++----
lib/Pod/t/htmlescp.t | 2 +-
lib/Pod/t/htmllink.t | 2 +-
lib/Pod/t/htmlview.t | 2 +-
4 files changed, 5 insertions(+), 7 deletions(-)

Inline Patch

diff --git a/lib/Pod/Html.pm b/lib/Pod/Html.pm
index 6174dd7..8cd981b 100644
--- a/lib/Pod/Html.pm
+++ b/lib/Pod/Html.pm
@@ -455,14 +455,12 @@ sub pod2html {
     $Title = html_escape($Title);

     my $csslink = '';
-    my $bodystyle = ' style="background-color: white"';
-    my $tdstyle = ' style="background-color: #cccccc"';
+    my $tdstyle = ' style="background-color: #ccc; color: #000"';

     if ($Css) {
       $csslink = qq(\n<link rel="stylesheet" href="$Css" type="text/css" />);
       $csslink =~ s,\\,/,g;
       $csslink =~ s,(/.):,$1|,;
-      $bodystyle = '';
       $tdstyle = '';
     }

@@ -484,7 +482,7 @@ END_OF_BLOCK
 <link rev="made" href="mailto:$Config{perladmin}" />
 </head>

-<body$bodystyle>
+<body>
 $block
 END_OF_HEAD

diff --git a/lib/Pod/t/htmlescp.t b/lib/Pod/t/htmlescp.t
index 95942cd..acabf48 100644
--- a/lib/Pod/t/htmlescp.t
+++ b/lib/Pod/t/htmlescp.t
@@ -22,7 +22,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>

-<body style="background-color: white">
+<body>


 <!-- INDEX BEGIN -->
diff --git a/lib/Pod/t/htmllink.t b/lib/Pod/t/htmllink.t
index ab11796..19baa62 100644
--- a/lib/Pod/t/htmllink.t
+++ b/lib/Pod/t/htmllink.t
@@ -22,7 +22,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>

-<body style="background-color: white">
+<body>


 <!-- INDEX BEGIN -->
diff --git a/lib/Pod/t/htmlview.t b/lib/Pod/t/htmlview.t
index 03fe6e5..c445081 100644
--- a/lib/Pod/t/htmlview.t
+++ b/lib/Pod/t/htmlview.t
@@ -22,7 +22,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>

-<body style="background-color: white">
+<body>


 <!-- INDEX BEGIN -->
-- 
1.7.0.2

p5pRT · 2010-04-12T02:58:07Z

The RT System itself - Status changed from 'new' to 'open'

p5pRT · 2012-01-07T09:13:34Z

From @cpansprout

Can Marc Green comment on this?

On Sun Apr 11 19:58:06 2010, aristotle wrote:

Fixed by the included patch. (Sorry, couldn’t yet figure out how
to make `git send-email` work with my setup, or how to make mutt
recognise MIME multipart draft messages.)

---
lib/Pod/Html.pm | 6 ++----
lib/Pod/t/htmlescp.t | 2 +-
lib/Pod/t/htmllink.t | 2 +-
lib/Pod/t/htmlview.t | 2 +-
4 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/lib/Pod/Html.pm b/lib/Pod/Html.pm
index 6174dd7..8cd981b 100644
--- a/lib/Pod/Html.pm
+++ b/lib/Pod/Html.pm
@@ -455,14 +455,12 @@ sub pod2html {
$Title = html_escape($Title);
 my $csslink = '';
- my $bodystyle = ' style="background-color: white"';
- my $tdstyle = ' style="background-color: #cccccc"';
+ my $tdstyle = ' style="background-color: #ccc; color: #000"';
 if $$Css$ \{
   $csslink = qq\(\\n\<link rel="stylesheet" href="$Css"
type="text/css" />);
$csslink =~ s,\\,/,g;
$csslink =~ s,(/.):,$1|,;
- $bodystyle = '';
$tdstyle = '';
}

@@ -484,7 +482,7 @@ END_OF_BLOCK
<link rev="made" href="mailto:$Config{perladmin}" />
</head>

-<body$bodystyle>
+<body>
$block
END_OF_HEAD

diff --git a/lib/Pod/t/htmlescp.t b/lib/Pod/t/htmlescp.t
index 95942cd..acabf48 100644
--- a/lib/Pod/t/htmlescp.t
+++ b/lib/Pod/t/htmlescp.t
@@ -22,7 +22,7 @@ __DATA__
<link rev="made" href="mailto:[PERLADMIN]" />
</head>

-<body style="background-color: white">
+<body>


diff --git a/lib/Pod/t/htmllink.t b/lib/Pod/t/htmllink.t
index ab11796..19baa62 100644
--- a/lib/Pod/t/htmllink.t
+++ b/lib/Pod/t/htmllink.t
@@ -22,7 +22,7 @@ __DATA__
<link rev="made" href="mailto:[PERLADMIN]" />
</head>

-<body style="background-color: white">
+<body>


diff --git a/lib/Pod/t/htmlview.t b/lib/Pod/t/htmlview.t
index 03fe6e5..c445081 100644
--- a/lib/Pod/t/htmlview.t
+++ b/lib/Pod/t/htmlview.t
@@ -22,7 +22,7 @@ __DATA__
<link rev="made" href="mailto:[PERLADMIN]" />
</head>

-<body style="background-color: white">
+<body>

--

Father Chrysostomos

p5pRT · 2012-01-07T15:53:50Z

From ponguile@gmail.com

On Sat, Jan 7, 2012 at 4:13 AM, Father Chrysostomos via RT <
perlbug-followup@perl.org> wrote:

Can Marc Green comment on this?

On Sun Apr 11 19:58:06 2010, aristotle wrote:
Fixed by the included patch. (Sorry, couldn’t yet figure out how
to make `git send-email` work with my setup, or how to make mutt
recognise MIME multipart draft messages.)

---
lib/Pod/Html.pm | 6 ++----
lib/Pod/t/htmlescp.t | 2 +-
lib/Pod/t/htmllink.t | 2 +-
lib/Pod/t/htmlview.t | 2 +-
4 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/lib/Pod/Html.pm b/lib/Pod/Html.pm
index 6174dd7..8cd981b 100644
--- a/lib/Pod/Html.pm
+++ b/lib/Pod/Html.pm
@@ -455,14 +455,12 @@ sub pod2html {
$Title = html_escape($Title);
 my $csslink = '';
- my $bodystyle = ' style="background-color: white"';
- my $tdstyle = ' style="background-color: #cccccc"';
+ my $tdstyle = ' style="background-color: #ccc; color: #000"';
 if $$Css$ \{
   $csslink = qq\(\\n\<link rel="stylesheet" href="$Css"
type="text/css" />);
$csslink =~ s,\\,/,g;
$csslink =~ s,(/.):,$1|,;
- $bodystyle = '';
$tdstyle = '';
}

@@ -484,7 +482,7 @@ END_OF_BLOCK
<link rev="made" href="mailto:$Config{perladmin}" />
</head>

-<body$bodystyle>
+<body>
$block
END_OF_HEAD

diff --git a/lib/Pod/t/htmlescp.t b/lib/Pod/t/htmlescp.t
index 95942cd..acabf48 100644
--- a/lib/Pod/t/htmlescp.t
+++ b/lib/Pod/t/htmlescp.t
@@ -22,7 +22,7 @@ __DATA__
<link rev="made" href="mailto:[PERLADMIN]" />
</head>

-<body style="background-color: white">
+<body>


diff --git a/lib/Pod/t/htmllink.t b/lib/Pod/t/htmllink.t
index ab11796..19baa62 100644
--- a/lib/Pod/t/htmllink.t
+++ b/lib/Pod/t/htmllink.t
@@ -22,7 +22,7 @@ __DATA__
<link rev="made" href="mailto:[PERLADMIN]" />
</head>

-<body style="background-color: white">
+<body>


diff --git a/lib/Pod/t/htmlview.t b/lib/Pod/t/htmlview.t
index 03fe6e5..c445081 100644
--- a/lib/Pod/t/htmlview.t
+++ b/lib/Pod/t/htmlview.t
@@ -22,7 +22,7 @@ __DATA__
<link rev="made" href="mailto:[PERLADMIN]" />
</head>

-<body style="background-color: white">
+<body>

I don't know what the "output concerns" are. Could the submitter describe
the problem and how this patch fixes it? Is it as simple as it looks - just
moving the stylings from <body> to <td>, or is there an underlying fix here?

p5pRT · 2012-01-07T20:36:03Z

From @rjbs

* Marc Green <ponguile@gmail.com> [2012-01-07T10:52:49]

I don't know what the "output concerns" are. Could the submitter describe
the problem and how this patch fixes it? Is it as simple as it looks - just
moving the stylings from <body> to <td>, or is there an underlying fix here?

They are at https://rt-archive.perl.org/perl5/Public/Bug/Display.html?id=74158

--
rjbs

p5pRT · 2012-01-08T07:16:07Z

From @rspier

Wouldn't it be cleaner to just change bodystyle to: background-color:
white; color: black?

Or even better, if we're assuming CSS support, move *all* the styling into
a <style> block. Last definition wins, so users can still provide an
external stylesheet to override any defaults.

-R

p5pRT · 2012-01-08T08:07:39Z

From @ap

* Robert Spier <rspier@pobox.com> [2012-01-08 08:20]:

Wouldn't it be cleaner to just change bodystyle to: background-color:
white; color: black?

Or even better, if we're assuming CSS support, move *all* the styling
into a <style> block. Last definition wins, so users can still
provide an external stylesheet to override any defaults.

That was a bigger patch than I wanted to attempt. I know one thing led
to another back when I looked at this and I soon had a fairly big patch
yet not a really complete. At that point I decided to cut losses and do
a surgical fix for precisely the one thing the ticket was asking for,
and leave the rest alone.

If someone had the ambition to clean up the file – the whole mark-up
could stand to be a lot cleaner, if memory serves. I seem to remember
it produces pre-CSS era HTML3-style output (using a table for trivial
layout, among others (just to set a background colour or some such)).

Regards,
--
Aristotle Pagaltzis // <http://plasmasturm.org/>

p5pRT · 2012-01-08T17:11:31Z

From ponguile@gmail.com

Thank you Ricardo for pointing me to the bug report.

On Sat, Jan 7, 2012 at 4:13 AM, Father Chrysostomos via RT <
perlbug-followup@perl.org> wrote:

Can Marc Green comment on this?

I am in favor of this patch.

Perhaps another patch can be submitted in the future that overhauls the CSS
and/or HTML markup, but this patch fixes the bug that was reported.

p5pRT · 2012-01-08T19:05:56Z

From @cpansprout

On Sun Jan 08 09:11:31 2012, ponguile@gmail.com wrote:

Thank you Ricardo for pointing me to the bug report.

On Sat, Jan 7, 2012 at 4:13 AM, Father Chrysostomos via RT <
perlbug-followup@perl.org> wrote:

Can Marc Green comment on this?

I am in favor of this patch.

But, not suprisingly, it won’t apply any more. :-(

Perhaps another patch can be submitted in the future that overhauls
the CSS
and/or HTML markup, but this patch fixes the bug that was reported.

--

Father Chrysostomos

p5pRT · 2012-01-09T02:47:24Z

From ponguile@gmail.com

On Sun, Jan 8, 2012 at 2:05 PM, Father Chrysostomos via RT <
perlbug-followup@perl.org> wrote:

On Sun Jan 08 09:11:31 2012, ponguile@gmail.com wrote:

Thank you Ricardo for pointing me to the bug report.

On Sat, Jan 7, 2012 at 4:13 AM, Father Chrysostomos via RT <
perlbug-followup@perl.org> wrote:

Can Marc Green comment on this?

I am in favor of this patch.

But, not suprisingly, it won’t apply any more. :-(

Perhaps not, but those few lines of code are almost exactly the same in the
new Pod::Html. Writing a new patch consists of applying the same changes
and sending it in. I think the only difference is that now there is a
$bodyid variable in the <body> tag in addition to the $bodystyle variable.

p5pRT · 2013-07-11T07:05:04Z

From @tonycoz

On Sun Jan 08 18:47:24 2012, ponguile@gmail.com wrote:

Perhaps not, but those few lines of code are almost exactly the same
in the
new Pod::Html. Writing a new patch consists of applying the same changes
and sending it in. I think the only difference is that now there is a
$bodyid variable in the <body> tag in addition to the $bodystyle variable.

I've attached a re-worked version of the original patch, which I'll
apply in a few days.

Tony

p5pRT · 2013-07-11T07:05:04Z

From @tonycoz

0001-perl-74158-pod2html-output-concerns.patch

From 1c30e261892b112d9abb36701463d8769a2a5d06 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 11 Jul 2013 17:03:44 +1000
Subject: [PATCH] [perl #74158] pod2html output concerns

---
 ext/Pod-Html/lib/Pod/Html.pm |    8 +++-----
 ext/Pod-Html/t/crossref.t    |    2 +-
 ext/Pod-Html/t/crossref2.t   |    2 +-
 ext/Pod-Html/t/crossref3.t   |    2 +-
 ext/Pod-Html/t/feature2.t    |    6 +++---
 ext/Pod-Html/t/htmldir1.t    |    2 +-
 ext/Pod-Html/t/htmldir2.t    |    2 +-
 ext/Pod-Html/t/htmldir3.t    |    2 +-
 ext/Pod-Html/t/htmldir4.t    |    2 +-
 ext/Pod-Html/t/htmldir5.t    |    2 +-
 ext/Pod-Html/t/htmlescp.t    |    2 +-
 ext/Pod-Html/t/htmllink.t    |    2 +-
 ext/Pod-Html/t/htmlview.t    |    2 +-
 ext/Pod-Html/t/poderr.t      |    2 +-
 ext/Pod-Html/t/podnoerr.t    |    2 +-
 15 files changed, 19 insertions(+), 21 deletions(-)

diff --git a/ext/Pod-Html/lib/Pod/Html.pm b/ext/Pod-Html/lib/Pod/Html.pm
index 3feb812..4562b4b 100644
--- a/ext/Pod-Html/lib/Pod/Html.pm
+++ b/ext/Pod-Html/lib/Pod/Html.pm
@@ -3,7 +3,7 @@ use strict;
 require Exporter;
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK);
-$VERSION = 1.19;
+$VERSION = 1.20;
 @ISA = qw(Exporter);
 @EXPORT = qw(pod2html htmlify);
 @EXPORT_OK = qw(anchorify);
@@ -369,14 +369,12 @@ sub pod2html {
     my $bodyid = $Backlink ? ' id="_podtop_"' : '';
 
     my $csslink = '';
-    my $bodystyle = ' style="background-color: white"';
-    my $tdstyle = ' style="background-color: #cccccc"';
+    my $tdstyle = ' style="background-color: #cccccc; color: #000"';
 
     if ($Css) {
         $csslink = qq(\n<link rel="stylesheet" href="$Css" type="text/css" />);
         $csslink =~ s,\\,/,g;
         $csslink =~ s,(/.):,$1|,;
-        $bodystyle = '';
         $tdstyle= '';
     }
 
@@ -400,7 +398,7 @@ END_OF_BLOCK
 <link rev="made" href="mailto:$Config{perladmin}" />
 </head>
 
-<body$bodyid$bodystyle>
+<body$bodyid>
 $block
 HTMLHEAD
 
diff --git a/ext/Pod-Html/t/crossref.t b/ext/Pod-Html/t/crossref.t
index 92837ac..30fa6d3 100644
--- a/ext/Pod-Html/t/crossref.t
+++ b/ext/Pod-Html/t/crossref.t
@@ -40,7 +40,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/crossref2.t b/ext/Pod-Html/t/crossref2.t
index 8e18647..536cfbb 100644
--- a/ext/Pod-Html/t/crossref2.t
+++ b/ext/Pod-Html/t/crossref2.t
@@ -36,7 +36,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/crossref3.t b/ext/Pod-Html/t/crossref3.t
index ff190f4..ab8f055 100644
--- a/ext/Pod-Html/t/crossref3.t
+++ b/ext/Pod-Html/t/crossref3.t
@@ -36,7 +36,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/feature2.t b/ext/Pod-Html/t/feature2.t
index 920f310..0cc0072 100644
--- a/ext/Pod-Html/t/feature2.t
+++ b/ext/Pod-Html/t/feature2.t
@@ -41,9 +41,9 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body id="_podtop_" style="background-color: white">
+<body id="_podtop_">
 <table border="0" width="100%" cellspacing="0" cellpadding="3">
-<tr><td class="_podblock_" style="background-color: #cccccc" valign="middle">
+<tr><td class="_podblock_" style="background-color: #cccccc; color: #000" valign="middle">
 <big><strong><span class="_podblock_">&nbsp;</span></strong></big>
 </td></tr>
 </table>
@@ -70,7 +70,7 @@ some html
 <p>some text and a link <a>crossref</a></p>
 
 <table border="0" width="100%" cellspacing="0" cellpadding="3">
-<tr><td class="_podblock_" style="background-color: #cccccc" valign="middle">
+<tr><td class="_podblock_" style="background-color: #cccccc; color: #000" valign="middle">
 <big><strong><span class="_podblock_">&nbsp;</span></strong></big>
 </td></tr>
 </table>
diff --git a/ext/Pod-Html/t/htmldir1.t b/ext/Pod-Html/t/htmldir1.t
index 8dd2854..6a0857b 100644
--- a/ext/Pod-Html/t/htmldir1.t
+++ b/ext/Pod-Html/t/htmldir1.t
@@ -57,7 +57,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/htmldir2.t b/ext/Pod-Html/t/htmldir2.t
index d1add48..d9aab5e 100644
--- a/ext/Pod-Html/t/htmldir2.t
+++ b/ext/Pod-Html/t/htmldir2.t
@@ -44,7 +44,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/htmldir3.t b/ext/Pod-Html/t/htmldir3.t
index 184b5c6..8006bf0 100644
--- a/ext/Pod-Html/t/htmldir3.t
+++ b/ext/Pod-Html/t/htmldir3.t
@@ -53,7 +53,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/htmldir4.t b/ext/Pod-Html/t/htmldir4.t
index 1ebcecd..31e7bde 100644
--- a/ext/Pod-Html/t/htmldir4.t
+++ b/ext/Pod-Html/t/htmldir4.t
@@ -39,7 +39,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/htmldir5.t b/ext/Pod-Html/t/htmldir5.t
index d9b6a6b..820590f 100644
--- a/ext/Pod-Html/t/htmldir5.t
+++ b/ext/Pod-Html/t/htmldir5.t
@@ -42,7 +42,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/htmlescp.t b/ext/Pod-Html/t/htmlescp.t
index 30c75b4..bb85e83 100644
--- a/ext/Pod-Html/t/htmlescp.t
+++ b/ext/Pod-Html/t/htmlescp.t
@@ -19,7 +19,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/htmllink.t b/ext/Pod-Html/t/htmllink.t
index 9c26dbf..b13bf0c 100644
--- a/ext/Pod-Html/t/htmllink.t
+++ b/ext/Pod-Html/t/htmllink.t
@@ -19,7 +19,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/htmlview.t b/ext/Pod-Html/t/htmlview.t
index 0fb36cf..792df93 100644
--- a/ext/Pod-Html/t/htmlview.t
+++ b/ext/Pod-Html/t/htmlview.t
@@ -19,7 +19,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/poderr.t b/ext/Pod-Html/t/poderr.t
index 456810c..f83057e 100644
--- a/ext/Pod-Html/t/poderr.t
+++ b/ext/Pod-Html/t/poderr.t
@@ -19,7 +19,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
diff --git a/ext/Pod-Html/t/podnoerr.t b/ext/Pod-Html/t/podnoerr.t
index cb74812..b49a3ac 100644
--- a/ext/Pod-Html/t/podnoerr.t
+++ b/ext/Pod-Html/t/podnoerr.t
@@ -21,7 +21,7 @@ __DATA__
 <link rev="made" href="mailto:[PERLADMIN]" />
 </head>
 
-<body style="background-color: white">
+<body>
 
 
 
-- 
1.7.10.4

p5pRT · 2013-07-19T01:50:31Z

From @tonycoz

On Thu Jul 11 00:05:04 2013, tonyc wrote:

On Sun Jan 08 18:47:24 2012, ponguile@gmail.com wrote:

Perhaps not, but those few lines of code are almost exactly the same
in the
new Pod::Html. Writing a new patch consists of applying the same changes
and sending it in. I think the only difference is that now there is a
$bodyid variable in the <body> tag in addition to the $bodystyle
variable.

I've attached a re-worked version of the original patch, which I'll
apply in a few days.

Applied as e6afd14.

Tony

p5pRT · 2013-07-19T01:50:32Z

@tonycoz - Status changed from 'open' to 'resolved'

p5pRT closed this as completed Jul 19, 2013

p5pRT added Severity Medium distro-Linux hasPatch type-library type-utilities labels Oct 18, 2019

jkeenan added the ext/Pod-Html issues in the blead-upstream Pod-Html distribution label Mar 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pod2html output concerns #10290

pod2html output concerns #10290

p5pRT commented Apr 8, 2010

p5pRT commented Apr 8, 2010

p5pRT commented Apr 12, 2010

p5pRT commented Apr 12, 2010

p5pRT commented Jan 7, 2012

p5pRT commented Jan 7, 2012

p5pRT commented Jan 7, 2012

p5pRT commented Jan 8, 2012

p5pRT commented Jan 8, 2012

p5pRT commented Jan 8, 2012

p5pRT commented Jan 8, 2012

p5pRT commented Jan 9, 2012

p5pRT commented Jul 11, 2013

p5pRT commented Jul 11, 2013

p5pRT commented Jul 19, 2013

p5pRT commented Jul 19, 2013

pod2html output concerns #10290

pod2html output concerns #10290

Comments

p5pRT commented Apr 8, 2010

p5pRT commented Apr 8, 2010

From choward@indicium.us

Created by choward@indicium.us

p5pRT commented Apr 12, 2010

From @ap

p5pRT commented Apr 12, 2010

p5pRT commented Jan 7, 2012

From @cpansprout

p5pRT commented Jan 7, 2012

From ponguile@gmail.com

p5pRT commented Jan 7, 2012

From @rjbs

p5pRT commented Jan 8, 2012

From @rspier

p5pRT commented Jan 8, 2012

From @ap

p5pRT commented Jan 8, 2012

From ponguile@gmail.com

p5pRT commented Jan 8, 2012

From @cpansprout

p5pRT commented Jan 9, 2012

From ponguile@gmail.com

p5pRT commented Jul 11, 2013

From @tonycoz

p5pRT commented Jul 11, 2013

From @tonycoz

p5pRT commented Jul 19, 2013

From @tonycoz

p5pRT commented Jul 19, 2013