Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pp_formline uses sv_pos_b2u/sv_pos_u2b #10170

Open
p5pRT opened this issue Feb 13, 2010 · 7 comments
Open

pp_formline uses sv_pos_b2u/sv_pos_u2b #10170

p5pRT opened this issue Feb 13, 2010 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented Feb 13, 2010

Migrated from rt.perl.org#72780 (status was 'open')

Searchable as RT72780$

@p5pRT
Copy link
Author

p5pRT commented Feb 13, 2010

From @nwc10

pp_ctl.c
602​: sv_pos_u2b(sv, &itembytes, 0);
616​: sv_pos_b2u(sv, &itemsize);
659​: sv_pos_u2b(sv, &itembytes, 0);
677​: sv_pos_b2u(sv, &itemsize);
877​: /* Mustn't call sv_pos_b2u() as it does a second
882​: sv_pos_b2u(sv, &itemsize);

All in pp_formline.

This means that formats will not work correctly with UTF-8 strings over 2GB.

Nicholas Clark

1 similar comment
@p5pRT
Copy link
Author

p5pRT commented Feb 13, 2010

From @nwc10

pp_ctl.c
602​: sv_pos_u2b(sv, &itembytes, 0);
616​: sv_pos_b2u(sv, &itemsize);
659​: sv_pos_u2b(sv, &itembytes, 0);
677​: sv_pos_b2u(sv, &itemsize);
877​: /* Mustn't call sv_pos_b2u() as it does a second
882​: sv_pos_b2u(sv, &itemsize);

All in pp_formline.

This means that formats will not work correctly with UTF-8 strings over 2GB.

Nicholas Clark

@p5pRT
Copy link
Author

p5pRT commented Feb 13, 2010

From zefram@fysh.org

Nicholas Clark wrote​:

This means that formats will not work correctly with UTF-8 strings over 2GB.

There are going to be an awful lot of standing bugs of this nature.
I think these should be tackled systematically in 5.13. Not piecemeal,
and not in a rush for 5.12.

-zefram

@p5pRT
Copy link
Author

p5pRT commented Feb 13, 2010

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Feb 13, 2010

From @nwc10

On Sat, Feb 13, 2010 at 08​:12​:14PM +0000, Zefram wrote​:

Nicholas Clark wrote​:

This means that formats will not work correctly with UTF-8 strings over 2GB.

There are going to be an awful lot of standing bugs of this nature.
I think these should be tackled systematically in 5.13. Not piecemeal,
and not in a rush for 5.12.

Oh, I quite agree. I was reviewing all uses of sv_pos_b2u/sv_pos_u2b,
effectively triaging them w.r.t. 5.12.0. I don't see any of these other bugs
as "things we should fix before 5.12.0". However, I'm hopeful that most of
the fixes will be low risk and binary compatible, hence the option is there
to merge them to 5.12.1, should the maint pumpking so wish.

Nicholas Clark

@p5pRT
Copy link
Author

p5pRT commented Sep 16, 2010

From @cpansprout

Exact copy of 72780.

@p5pRT
Copy link
Author

p5pRT commented Sep 16, 2010

@cpansprout - Status changed from 'new' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants