B::Deparse fail on "my" with attributes #9946

p5pRT · 2009-11-03T21:14:46Z

Migrated from rt.perl.org#70205 (status was 'open')

Searchable as RT70205$

p5pRT · 2009-11-03T21:14:48Z

From zefram@fysh.org

Created by zefram@fysh.org

Investigating around a B::Deparse problem that Nicholas just reported,
I found this:

$ perl -MO=Deparse -e 'my $pi :shared = 4'
use attributes ();
('attributes'->import('main', \$pi, 'shared'), my $pi) = 4;
-e syntax OK

Note that \$pi is referenced before "my $pi" comes into scope, so the
reference is wrong. Also, the attempt at a comma operator on the LHS
of assignment ends up doing a list assignment, and attempting to assign
4 to the return value of the ->import. Need cleverer code generation.

Perl Info


Flags:
    category=core
    severity=low

Site configuration information for perl 5.10.0:

Configured by Debian Project at Fri Aug 28 22:30:10 UTC 2009.

Summary of my perl5 (revision 5 version 10 subversion 0) configuration:
  Platform:
    osname=linux, osvers=2.6.26-2-amd64, archname=i486-linux-gnu-thread-multi
    uname='linux puccini 2.6.26-2-amd64 #1 smp fri aug 14 07:12:04 utc 2009 i686 gnulinux '
    config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN -Dcccdlflags=-fPIC -Darchname=i486-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.10 -Darchlib=/usr/lib/perl/5.10 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.10.0 -Dsitearch=/usr/local/lib/perl/5.10.0 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -DDEBUGGING=-g -Doptimize=-O2 -Duseshrplib -Dlibperl=libperl.so.5.10.0 -Dd_dosuid -des'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2 -g',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include'
    ccversion='', gccversion='4.3.2', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib /usr/lib64
    libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt
    perllibs=-ldl -lm -lpthread -lc -lcrypt
    libc=/lib/libc-2.7.so, so=so, useshrplib=true, libperl=libperl.so.5.10.0
    gnulibc_version='2.7'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib'

Locally applied patches:
    


@INC for perl 5.10.0:
    /etc/perl
    /usr/local/lib/perl/5.10.0
    /usr/local/share/perl/5.10.0
    /usr/lib/perl5
    /usr/share/perl5
    /usr/lib/perl/5.10
    /usr/share/perl/5.10
    /usr/local/lib/site_perl
    .


Environment for perl 5.10.0:
    HOME=/home/zefram
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/zefram/pub/i686-pc-linux-gnu/bin:/home/zefram/pub/common/bin:/usr/bin:/usr/X11R6/bin:/bin:/usr/local/bin:/usr/games
    PERL_BADLANG (unset)
    SHELL=/usr/bin/zsh

p5pRT · 2009-11-11T08:27:01Z

@pjf - Status changed from 'new' to 'open'

p5pRT · 2010-12-12T20:31:53Z

From @cpansprout

This is even more amusing than what our $foo:shared (#70201) produces:

$ ./perl -Ilib -MO=Deparse -e 'my $x :shared = 4'
use attributes ();
('attributes'->import('main', \$x, 'shared'), my $x) = 4;
-e syntax OK

$ ./perl -Ilib -MO=Deparse -E 'state $x :shared = 4'
use attributes ();
BEGIN {
$^H{'feature_unicode'} = q(1);
$^H{'feature_say'} = q(1);
$^H{'feature_state'} = q(1);
$^H{'feature_switch'} = q(1);
}
('attributes'->import('main', \$x, 'shared'), state $x) = 4;
-e syntax OK

Flags:
category=library
severity=low

Site configuration information for perl 5.13.7:

Configured by sprout at Thu Dec 9 14:53:58 PST 2010.

Summary of my perl5 (revision 5 version 13 subversion 7) configuration:
Snapshot of: 9e9fdd5
Platform:
osname=darwin, osvers=10.4.0, archname=darwin-2level
uname='darwin pint.local 10.4.0 darwin kernel version 10.4.0: fri apr 23 18:28:53 pdt 2010; root:xnu-1504.7.4~1release_i386 i386 '
config_args='-de -Dusedevel -DDEBUGGING'
hint=recommended, useposix=true, d_sigaction=define
useithreads=undef, usemultiplicity=undef
useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
use64bitint=undef, use64bitall=undef, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cc', ccflags ='-fno-common -DPERL_DARWIN -no-cpp-precomp -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
optimize='-O3 -g',
cppflags='-no-cpp-precomp -fno-common -DPERL_DARWIN -no-cpp-precomp -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
ccversion='', gccversion='4.2.1 (Apple Inc. build 5664)', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack-protector -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib
libs=-ldbm -ldl -lm -lutil -lc
perllibs=-ldl -lm -lutil -lc
libc=/usr/lib/libc.dylib, so=dylib, useshrplib=false, libperl=libperl.a
gnulibc_version=''
Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib -fstack-protector'

Locally applied patches:

@INC for perl 5.13.7:
/usr/local/lib/perl5/site_perl/5.13.7/darwin-2level
/usr/local/lib/perl5/site_perl/5.13.7
/usr/local/lib/perl5/5.13.7/darwin-2level
/usr/local/lib/perl5/5.13.7
/usr/local/lib/perl5/site_perl
.

Environment for perl 5.13.7:
DYLD_LIBRARY_PATH (unset)
HOME=/Users/sprout
LANG=en_US.UTF-8
LANGUAGE (unset)
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin:/usr/local/bin
PERL_BADLANG (unset)
SHELL=/bin/bash

p5pRT · 2010-12-12T20:38:35Z

From zefram@fysh.org

Father Chrysostomos wrote:

Subject: [perl #80634] Deparsing my/state with attributes

This is a duplicate of [perl #70205].

-zefram

p5pRT · 2010-12-12T20:38:35Z

The RT System itself - Status changed from 'new' to 'open'

p5pRT · 2010-12-12T20:46:40Z

From @cpansprout

On Sun Dec 12 12:38:35 2010, zefram@fysh.org wrote:

Father Chrysostomos wrote:

Subject: [perl #80634] Deparsing my/state with attributes

This is a duplicate of [perl #70205].

-zefram

So it is. Thank you.

Interestingly, you wrote it that ticket:

Investigating around a B::Deparse problem that Nicholas just reported,
I found this:

That’s exactly what I was doing. :-)

p5pRT · 2010-12-12T20:46:41Z

From [Unknown Contact. See original ticket]

On Sun Dec 12 12:38:35 2010, zefram@fysh.org wrote:

Father Chrysostomos wrote:

Subject: [perl #80634] Deparsing my/state with attributes

This is a duplicate of [perl #70205].

-zefram

So it is. Thank you.

Interestingly, you wrote it that ticket:

Investigating around a B::Deparse problem that Nicholas just reported,
I found this:

That’s exactly what I was doing. :-)

jkeenan · 2023-10-29T22:22:49Z

Back in November 2009, Zefram reported this:

Investigating around a B::Deparse problem that Nicholas just reported, I found this:

$ perl -MO=Deparse -e 'my $pi :shared = 4'
use attributes ();
('attributes'->import('main', \$pi, 'shared'), my $pi) = 4;
-e syntax OK

Note that $pi is referenced before "my $pi" comes into scope, so the reference is wrong. Also, the attempt at a comma operator on the LHS of assignment ends up doing a list assignment, and attempting to assign 4 to the return value of the ->import. Need cleverer code generation.

Running that command in perl-5.38 today, I got:

$ perl -MO=Deparse -e 'my $pi :shared = 4'
use attributes ();
my $pi :shared = 4;
-e syntax OK

Now, I don't know enough about B::Deparse to know whether the current code is correct or not. However, I became curious as to when the output changed. I wrote a test file, tested it with various production releases installed via perlbrew, and used it to bisect the change.

$ cat /tmp/gh-9946-deparse.pl 
my @lines = `$^X -Ilib -MO=Deparse -e 'my \$pi :shared = 4'`;
my $seen = grep { /:shared/ } @lines;
print "Count: $seen\n";
die "Saw ':shared'" if $seen;

$ perl Porting/bisect.pl \
--start=v5.26.0 \
--end=v5.28.0 \
--target=test_prep \
-- ./perl -Ilib /tmp/gh-9946-deparse.pl

Bisection pointed to this commit:

commit 82ab48fa8c6c51b80c9b69419850061640110339
Author:     David Mitchell <davem@iabyn.nospamdeletethisbit.com>
AuthorDate: Fri Feb 24 14:32:28 2017 +0000
Commit:     David Mitchell <davem@iabyn.nospamdeletethisbit.com>
CommitDate: Mon Jun 5 12:52:18 2017 +0100

    Deparse my var attributes correctly

@iabyn, does that make this ticket closable?

Note: Back in 2009, there was a companion ticket created by @nwc10 for the case of our variables: #9944. The output Nick reported there (and found anomalous) is unchanged in perl-5.38.

$ perl -MO=Deparse -e 'our $pi :shared = 4'
use attributes ('main', \undef, 'shared');
our $pi = 4;
-e syntax OK

iabyn · 2023-10-30T11:18:50Z

On Sun, Oct 29, 2023 at 03:23:00PM -0700, James E Keenan wrote: @iabyn, does that make this ticket closable?

Yes.

**Note:** Back in 2009, there was a companion ticket created by @nwc10 for the case of `our` variables: #9944. The output Nick reported there (and found anomalous) is unchanged in perl-5.38. ``` $ perl -MO=Deparse -e 'our $pi :shared = 4' use attributes ('main', \undef, 'shared'); our $pi = 4; -e syntax OK

Yeah, that still needs fixing.

…

-- If life gives you lemons, you'll probably develop a citric acid allergy.

p5pRT added Severity Low distro-Linux type-core labels Oct 18, 2019

xenu removed the affects-5.10 label Nov 19, 2021

xenu removed the Severity Low label Dec 29, 2021

jkeenan added Closable? We might be able to close this ticket, but we need to check with the reporter and removed distro-Linux labels Oct 29, 2023

jkeenan closed this as completed Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

B::Deparse fail on "my" with attributes #9946

B::Deparse fail on "my" with attributes #9946

p5pRT commented Nov 3, 2009

p5pRT commented Nov 3, 2009

p5pRT commented Nov 11, 2009

p5pRT commented Dec 12, 2010

p5pRT commented Dec 12, 2010

p5pRT commented Dec 12, 2010

p5pRT commented Dec 12, 2010

p5pRT commented Dec 12, 2010

jkeenan commented Oct 29, 2023

iabyn commented Oct 30, 2023 via email

B::Deparse fail on "my" with attributes #9946

B::Deparse fail on "my" with attributes #9946

Comments

p5pRT commented Nov 3, 2009

p5pRT commented Nov 3, 2009

From zefram@fysh.org

Created by zefram@fysh.org

p5pRT commented Nov 11, 2009

p5pRT commented Dec 12, 2010

From @cpansprout

p5pRT commented Dec 12, 2010

From zefram@fysh.org

p5pRT commented Dec 12, 2010

p5pRT commented Dec 12, 2010

From @cpansprout

p5pRT commented Dec 12, 2010

From [Unknown Contact. See original ticket]

jkeenan commented Oct 29, 2023

iabyn commented Oct 30, 2023 via email