-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installperl does not delete files before copying #9880
Comments
From @cpansproutIn Snow Leopard, Apple replaced the scripts that come with perl I was trying to install 5.10.1 over the system perl (with -Dprefix=/ Shouldn’t installperl be unlinking files if they already exist? Use of uninitialized value in concatenation (.) or string at /usr/bin/ Flags: Site configuration information for perl 5.10.1: Configured by sprout at Tue Sep 22 08:35:48 PDT 2009. Summary of my perl5 (revision 5 version 10 subversion 1) configuration: Platform: Locally applied patches: @INC for perl 5.10.1: Environment for perl 5.10.1: |
From @obraOn Tue Sep 22 21:31:51 2009, sprout@cpan.org wrote:
So, we talked about "don't do this" in this specific case, but it'd be nice to come |
The RT System itself - Status changed from 'new' to 'open' |
From @cpansproutOn Oct 10, 2009, at 12:27 PM, Jesse via RT wrote:
I actually consider the slight possibility of having to type ‘sudo ln
I think the easiest way is to add ‘unlink’ to installperl. Attached is |
From @cpansproutInline Patchdiff -rup blead/installperl bleadcopy/installperl
--- blead/installperl 2009-10-01 16:57:11.000000000 -0700
+++ bleadcopy/installperl 2009-10-10 17:26:03.000000000 -0700
@@ -692,6 +692,12 @@ sub copy {
unless $opts{silent};
print " creating new version of $xto\n"
if $Is_VMS and -e $to and !$opts{silent};
+ if(!$Is_VMS and $Config{d_link}) {
+ # Some vendors put hard-linked wrapper scripts in their default
+ # perl installations. This would prevent a proper install over the
+ # top of a vendor's perl without the unlink.
+ unlink $to;
+ }
unless ($opts{notify} or File::Copy::copy($from, $to)) {
# Might have been that F::C::c can't overwrite the target
warn "Couldn't copy $from to $to: $!\n" |
From @nwc10On Sun, Oct 18, 2009 at 02:42:15PM -0700, Father Chrysostomos wrote:
I still don't think that we want to do this. Nicholas Clark |
From @jkeenanOn Mon Oct 19 01:14:19 2009, nicholas wrote:
This ticket has generated no correspondence in nearly four years. Can we conclude that we do not want to modify installperl to delete Thank you very much. |
From @cpansproutOn Thu Aug 08 16:38:58 2013, jkeenan wrote:
Well, *I* don’t agree with that! :-) -- Father Chrysostomos |
From [Unknown Contact. See original ticket]On Thu Aug 08 16:38:58 2013, jkeenan wrote:
Well, *I* don’t agree with that! :-) -- Father Chrysostomos |
The patch provided by @cpansprout has not gained any endorsements since it was first proposed in 2009. Two former pumpkings have expressed doubt as to its merits. I no longer have a working Mac, so I can't evaluate this Darwin-specific problem. However, I am very skeptical of the idea that we should be trying to compensate for weird choices made in a "vendor perl" installation by overwriting files in that installation. We have long followed the adage "the system perl is for the system." I'm taking this ticket for the purpose of closing it in 7 days unless someone wants to re-open the discussion (preferably with suggestions tested on Darwin). Thank you very much. |
Closing ticket per previously announced schedule. Thank you very much. |
Migrated from rt.perl.org#69302 (status was 'open')
Searchable as RT69302$
The text was updated successfully, but these errors were encountered: