Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in File::stat man pag #9485

Closed
p5pRT opened this issue Sep 20, 2008 · 5 comments
Closed

Typo in File::stat man pag #9485

p5pRT opened this issue Sep 20, 2008 · 5 comments

Comments

@p5pRT
Copy link

p5pRT commented Sep 20, 2008

Migrated from rt.perl.org#59134 (status was 'resolved')

Searchable as RT59134$

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2008

From @rrthomas

Created by @rrthomas

File​::stat man page bug​: "$st_nlink > 1)" -> "($st_nlink > 1)"

Seems to be a missing paren. Checked against online 5.10 man pages.

Perl Info

Flags:
    category=docs
    severity=low

Site configuration information for perl v5.8.8:

Configured by Debian Project at Tue Nov 27 10:56:10 GMT 2007.

Summary of my perl5 (revision 5 version 8 subversion 8) configuration:
  Platform:
    osname=linux, osvers=2.6.15.7, archname=i486-linux-gnu-thread-multi
    uname='linux palmer 2.6.15.7 #1 smp thu sep 7 19:42:20 utc 2006 i686 gnulinux '
    config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN -Dcccdlflags=-fPIC -Darchname=i486-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.8 -Darchlib=/usr/lib/perl/5.8 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.8.8 -Dsitearch=/usr/local/lib/perl/5.8.8 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Duseshrplib -Dlibperl=libperl.so.5.8.8 -Dd_dosuid -des'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=define use5005threads=undef useithreads=define usemultiplicity=define
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include'
    ccversion='', gccversion='4.2.3 20071123 (prerelease) (Ubuntu 4.2.2-3ubuntu4)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt
    perllibs=-ldl -lm -lpthread -lc -lcrypt
    libc=/lib/libc-2.6.1.so, so=so, useshrplib=true, libperl=libperl.so.5.8.8
    gnulibc_version='2.6.1'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib'

Locally applied patches:
    


@INC for perl v5.8.8:
    /home/rrt/local/share/perl5
    /etc/perl
    /usr/local/lib/perl/5.8.8
    /usr/local/share/perl/5.8.8
    /usr/lib/perl5
    /usr/share/perl5
    /usr/lib/perl/5.8
    /usr/share/perl/5.8
    /usr/local/lib/site_perl
    .


Environment for perl v5.8.8:
    HOME=/home/rrt
    LANG=en_GB.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/usr/local/sbin:/sbin:/usr/sbin:/usr/NX/bin:/usr/local/epocemx/bin:/home/rrt/bin:/home/rrt/local/i686/bin:/home/rrt/local/bin:/home/rrt/.luarocks/bin:/home/rrt/Work/Adsensus/svn/nancy/trunk:/home/rrt/Work/Adsensus/svn/adsensus/trunk:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
    PERL5LIB=/home/rrt/local/share/perl5
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Sep 21, 2008

From @moritz

rrt@​sc3d.org (via RT) wrote​:

# New Ticket Created by rrt@​sc3d.org
# Please include the string​: [perl #59134]
# in the subject line of all future correspondence about this issue.
# <URL​: http​://rt.perl.org/rt3/Ticket/Display.html?id=59134 >

This is a bug report for perl from rrt@​sc3d.org,
generated with the help of perlbug 1.35 running under perl v5.8.8.

-----------------------------------------------------------------
[Please enter your report here]

File​::stat man page bug​: "$st_nlink > 1)" -> "($st_nlink > 1)"

Seems to be a missing paren. Checked against online 5.10 man pages.

The parens are un-balanced, so here's a patch that adds one open paren​:

Inline Patch
diff --git a/lib/File/stat.pm b/lib/File/stat.pm
index 132cbee..22862d7 100644
--- a/lib/File/stat.pm
+++ b/lib/File/stat.pm
@@ -76,7 +76,7 @@ File::stat - by-name interface to Perl's built-in
stat() funct

  use File​::stat qw(​:FIELDS);
  stat($file) or die "No $file​: $!";
- if ( ($st_mode & 0111) && $st_nlink > 1) ) {
+ if ( ($st_mode & 0111) && ($st_nlink > 1) ) {
  print "$file is executable with lotsa links\n";
  }

@p5pRT
Copy link
Author

p5pRT commented Sep 21, 2008

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Sep 21, 2008

From @Tux

On Sun, 21 Sep 2008 17​:50​:04 +0200, Moritz Lenz
<moritz@​casella.verplant.org> wrote​:

rrt@​sc3d.org (via RT) wrote​:

# New Ticket Created by rrt@​sc3d.org
# Please include the string​: [perl #59134]
# in the subject line of all future correspondence about this issue.
# <URL​: http​://rt.perl.org/rt3/Ticket/Display.html?id=59134 >

This is a bug report for perl from rrt@​sc3d.org,
generated with the help of perlbug 1.35 running under perl v5.8.8.

-----------------------------------------------------------------
[Please enter your report here]

File​::stat man page bug​: "$st_nlink > 1)" -> "($st_nlink > 1)"

Seems to be a missing paren. Checked against online 5.10 man pages.

The parens are un-balanced, so here's a patch that adds one open paren​:

Thanks, applied as change #34386

diff --git a/lib/File/stat.pm b/lib/File/stat.pm
index 132cbee..22862d7 100644
--- a/lib/File/stat.pm
+++ b/lib/File/stat.pm
@​@​ -76,7 +76,7 @​@​ File​::stat - by-name interface to Perl's built-in
stat() funct

use File​::stat qw(​:FIELDS);
stat($file) or die "No $file​: $!";
- if ( ($st_mode & 0111) && $st_nlink > 1) ) {
+ if ( ($st_mode & 0111) && ($st_nlink > 1) ) {
print "$file is executable with lotsa links\n";
}

--
H.Merijn Brand Amsterdam Perl Mongers http​://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.
http​://mirrors.develooper.com/hpux/ http​://www.test-smoke.org/
http​://qa.perl.org http​://www.goldmark.org/jeff/stupid-disclaimers/

@p5pRT
Copy link
Author

p5pRT commented Sep 21, 2008

module@renee-baecker.de - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant