Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc_runtime syntax error #9365

Closed
p5pRT opened this issue Jun 4, 2008 · 6 comments
Closed

cc_runtime syntax error #9365

p5pRT opened this issue Jun 4, 2008 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Jun 4, 2008

Migrated from rt.perl.org#55302 (status was 'resolved')

Searchable as RT55302$

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2008

From @rurban

This is a bug report for perl from rurban@​x-ray.at,
generated with the help of perlbug 1.36 running under perl 5.10.0.


Syntax error when using B​::CC with threads and eval.
This exists for some years. Because we never had B​::CC tests.

Patch for blead and 5.10.x and 5.8.9

Inline Patch
diff -u cc_runtime.h.orig cc_runtime.h
--- cc_runtime.h.orig   2007-12-18 11:47:07.000000000 +0100
+++ cc_runtime.h        2008-06-04 22:18:26.625000000 +0200
@@ -54,7 +54,7 @@
        switch (ret) {                          \
        case 0:                                 \
            PL_op = ppaddr(aTHX);               \
-           if (PL_op != nxt) CALLRUNOPS();     \
+           if (PL_op != nxt) CALLRUNOPS(aTHX); \
            JMPENV_POP;                         \
            break;                              \
        case 1: JMPENV_POP; JMPENV_JUMP(1);     \


-----------------------------------------------------------------
---
Flags:   category=core   severity=medium

Site configuration information for perl 5.10.0​:

Configured by rurban at Sun Jun 1 18​:12​:10 WEDT 2008.

Summary of my perl5 (revision 5 version 10 subversion 0) configuration​:
  Platform​:
  osname=cygwin, osvers=1.5.25(0.15642), archname=cygwin-thread-multi-64int
  uname='cygwin_nt-5.1 atgrzwn502840 1.5.25(0.15642) 2008-05-26 20​:37 i686 cygwin '
  config_args='-de -Dmksymlinks -Dusethreads -Dmad=y'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=undef, uselongdouble=undef
  usemymalloc=y, bincompat5005=undef
  Compiler​:
  cc='gcc', ccflags ='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -mms-bitfields -fno-strict-aliasing -pipe -I/usr/local/include',
  optimize='-O3',
  cppflags='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -mms-bitfields -fno-strict-aliasing -pipe -I/usr/local/include'
  ccversion='', gccversion='3.4.4 (cygming special, gdc 0.12, using dmd 0.125)', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
  ivtype='long long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='g++', ldflags =' -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--stack,8388608 -Wl,--enable-auto-image-base -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib /lib
  libs=-lgdbm -ldb -ldl -lcrypt -lgdbm_compat
  perllibs=-ldl -lcrypt -lgdbm_compat
  libc=/usr/lib/libc.a, so=dll, useshrplib=true, libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags=' --shared -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--stack,8388608 -Wl,--enable-auto-image-base -L/usr/local/lib'

Locally applied patches​:
  CYG04 major version
  CYG11 no-bs
  CYG12 no archlib in otherlibdirs
  CYG14 Dynaloader
  CYG15 static-Win32CORE
  CYG18 File​::Spec​::case_tolerant performance fix
  32813 ExtUtils​::Install update
  32891 aassign_common
  32909 smartmatch-deparse
  32933 clone-seen_eval
  32938 refcount-reg_curpm
  33239 unpack-in-scalar-context
  33807 sv_setsv_flags crash with gv
  33937 sort magic crash


@​INC for perl 5.10.0​:
  /usr/lib/perl5/5.10/i686-cygwin
  /usr/lib/perl5/5.10
  /usr/lib/perl5/site_perl/5.10/i686-cygwin
  /usr/lib/perl5/site_perl/5.10
  /usr/lib/perl5/vendor_perl/5.10/i686-cygwin
  /usr/lib/perl5/vendor_perl/5.10
  /usr/lib/perl5/vendor_perl/5.10
  /usr/lib/perl5/site_perl/5.8
  .


Environment for perl 5.10.0​:
  HOME=/home/URBANR
  LANG (unset)
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/usr/local/bin​:/usr/bin​:/bin​:/usr/X11R6/bin​:/cygdrive/c/WINDOWS/System32​:/cygdrive/c/WINDOWS​:/cygdrive/c/WINDOWS/System32/WBEM​:/cygdrive/c/PROGRA1/ATT/Graphviz/bin​:/cygdrive/c/PROGRA1/ATT/Graphviz/bin/tools​:/usr/lib/lapack
  PERL_BADLANG (unset)
  SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2008

From @rurban

cc_runtime patch for 5.8.9, 5.10.x and blead.

Syntax error when using B​::CC with threads and eval.
This exists for some years. Because we never had B​::CC tests.

Inline Patch
diff -u cc_runtime.h.orig cc_runtime.h
--- cc_runtime.h.orig   2007-12-18 11:47:07.000000000 +0100
+++ cc_runtime.h        2008-06-04 22:18:26.625000000 +0200
@@ -54,7 +54,7 @@
        switch (ret) {                          \
        case 0:                                 \
            PL_op = ppaddr(aTHX);               \
-           if (PL_op != nxt) CALLRUNOPS();     \
+           if (PL_op != nxt) CALLRUNOPS(aTHX); \
            JMPENV_POP;                         \
            break;                              \
        case 1: JMPENV_POP; JMPENV_JUMP(1);     \
-- 
Reini Urban

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2008

@rurban - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jun 5, 2008

From @rurban

2008/6/4 Reini Urban via RT <perlbug-followup@​perl.org>​:

cc_runtime patch for 5.8.9, 5.10.x and blead.

Syntax error when using B​::CC with threads and eval.
This exists for some years. Because we never had B​::CC tests.

In fact this bug existed since its infant beginnings,
but only for threaded perls which use eval.

I've fixed it now in B-C-1.04_18 backwards compatible.

And​: I would appreciate if this header file would stay in core for now.

diff -u cc_runtime.h.orig cc_runtime.h
--- cc_runtime.h.orig 2007-12-18 11​:47​:07.000000000 +0100
+++ cc_runtime.h 2008-06-04 22​:18​:26.625000000 +0200
@​@​ -54,7 +54,7 @​@​
switch (ret) { \
case 0​: \
PL_op = ppaddr(aTHX); \
- if (PL_op != nxt) CALLRUNOPS(); \
+ if (PL_op != nxt) CALLRUNOPS(aTHX); \
JMPENV_POP; \
break; \
case 1​: JMPENV_POP; JMPENV_JUMP(1); \
--
Reini Urban

@p5pRT
Copy link
Author

p5pRT commented Jun 5, 2008

From @smpeters

On Wed, Jun 4, 2008 at 3​:53 PM, via RT Reini Urban
<perlbug-followup@​perl.org> wrote​:

# New Ticket Created by Reini Urban
# Please include the string​: [perl #55302]
# in the subject line of all future correspondence about this issue.
# <URL​: http​://rt.perl.org/rt3/Ticket/Display.html?id=55302 >

This is a bug report for perl from rurban@​x-ray.at,
generated with the help of perlbug 1.36 running under perl 5.10.0.

-----------------------------------------------------------------
Syntax error when using B​::CC with threads and eval.
This exists for some years. Because we never had B​::CC tests.

Patch for blead and 5.10.x and 5.8.9

diff -u cc_runtime.h.orig cc_runtime.h
--- cc_runtime.h.orig 2007-12-18 11​:47​:07.000000000 +0100
+++ cc_runtime.h 2008-06-04 22​:18​:26.625000000 +0200
@​@​ -54,7 +54,7 @​@​
switch (ret) { \
case 0​: \
PL_op = ppaddr(aTHX); \
- if (PL_op != nxt) CALLRUNOPS(); \
+ if (PL_op != nxt) CALLRUNOPS(aTHX); \
JMPENV_POP; \
break; \
case 1​: JMPENV_POP; JMPENV_JUMP(1); \

Thanks! This was applied as change #34002.

Steve Peters
steve@​fisharerojo.org

@p5pRT
Copy link
Author

p5pRT commented Jun 5, 2008

@smpeters - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant