Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cygwin mount test #9361

Closed
p5pRT opened this issue Jun 1, 2008 · 6 comments
Closed

Fix cygwin mount test #9361

p5pRT opened this issue Jun 1, 2008 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Jun 1, 2008

Migrated from rt.perl.org#55160 (status was 'resolved')

Searchable as RT55160$

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2008

From @rurban

This is a bug report for perl from rurban@​cpan.org,
generated with the help of perlbug 1.36 running under perl 5.11.0.


t/lib/cygwin.t check / for binmount fails if the mount has the flag exec
also.
$ mount
c​:\cygwin\bin on /usr/bin type system (binmode,exec)

This patch for 5.10 and blead fixes that.

Inline Patch
diff -u perl-current/t/lib/cygwin.t.orig perl-current/t/lib/cygwin.t
--- perl-current/t/lib/cygwin.t.orig    2007-10-02 14:32:44.000000000 +0200
+++ perl-current/t/lib/cygwin.t 2008-06-01 14:33:55.156250000 +0200
@@ -43,7 +43,7 @@
 is(Cygwin::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");

 my $mount = join '', `/usr/bin/mount`;
-$mount =~ m|on /usr/bin type .+ \((\w+mode)\)|m;
+$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
 my $binmode = $1 eq 'binmode';
 is(Cygwin::is_binmount("/"),  $binmode ? 1 : '', "check / for binmount");


-----------------------------------------------------------------
---
Flags:   category=core   severity=low

This perlbug was built using Perl 5.11.0 - Sun Mar 2 15​:14​:10 GMT 2008
It is being executed now by Perl 5.11.0 - Sun Apr 13 19​:53​:41 WEDT 2008.

Site configuration information for perl 5.11.0​:

Configured by rurban at Sun Apr 13 19​:53​:41 WEDT 2008.

Summary of my perl5 (revision 5 version 11 subversion 0 patch 33673)
configuration​:
  Platform​:
  osname=cygwin, osvers=1.5.25(0.15642), archname=cygwin-thread-multi-64int
  uname='cygwin_nt-5.1 atgrzwn502840 1.5.25(0.15642) 2008-03-05
19​:27 i686 cygwin '
  config_args='-de -Dmksymlinks -Duse64bitint -Dusethreads
-Dusemymalloc -Dusedevel -DDEBUGGING -Doptimize=-O0 -g -Dmad=y'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=undef, uselongdouble=undef
  usemymalloc=y, bincompat5005=undef
  Compiler​:
  cc='gcc', ccflags ='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__
-DDEBUGGING -fno-strict-aliasing -pipe -I/usr/local/include',
  optimize='-O0 -g',
  cppflags='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -DDEBUGGING
-fno-strict-aliasing -pipe -I/usr/local/include'
  ccversion='', gccversion='3.4.4 (cygming special, gdc 0.12, using
dmd 0.125)', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
  ivtype='long long', ivsize=8, nvtype='double', nvsize=8,
Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='g++', ldflags =' -Wl,--enable-auto-import
-Wl,--export-all-symbols -Wl,--stack,8388608
-Wl,--enable-auto-image-base -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib /lib
  libs=-lgdbm -ldb -ldl -lcrypt -lgdbm_compat
  perllibs=-ldl -lcrypt -lgdbm_compat
  libc=/usr/lib/libc.a, so=dll, useshrplib=true, libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags=' --shared -Wl,--enable-auto-import
-Wl,--export-all-symbols -Wl,--stack,8388608
-Wl,--enable-auto-image-base -L/usr/local/lib'

Locally applied patches​:
  CYG04 major version
  CYG11 no-bs
  DEVEL


@​INC for perl 5.11.0​:
  /usr/lib/perl5/5.11/i686-debug-cygwin
  /usr/lib/perl5/5.11
  /usr/lib/perl5/site_perl/5.11/i686-debug-cygwin
  /usr/lib/perl5/site_perl/5.11
  /usr/lib/perl5/vendor_perl/5.11/i686-debug-cygwin
  /usr/lib/perl5/vendor_perl/5.11
  /usr/lib/perl5/vendor_perl/5.11
  /usr/lib/perl5/site_perl/5.10
  /usr/lib/perl5/site_perl/5.8
  .


Environment for perl 5.11.0​:
  HOME=/home/URBANR
  LANG (unset)
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/home/URBANR/bin​:/usr/local/bin​:/usr/bin​:/bin​:/usr/X11R6/bin​:/cygdrive/c/WINDOWS/System32​:/cygdrive/c/WINDOWS​:/cygdrive/c/WINDOWS/System32/WBEM​:/cygdrive/c/PROGRA1/ATT/Graphviz/bin​:/cygdrive/c/PROGRA1/ATT/Graphviz/bin/tools​:/usr/lib/lapack
  PERL_BADLANG (unset)
  SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2008

From @rurban

Attached patch fixes bug #55160 for 5.10 and blead
A simple cygwin mount test fix.
--
Reini Urban
http​://phpwiki.org/ http​://murbreak.at/

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2008

From @rurban

pl-CYG19-cygmount.patch
difforig perl-current/t/lib/cygwin.t

diff -u perl-current/t/lib/cygwin.t.orig perl-current/t/lib/cygwin.t
--- perl-current/t/lib/cygwin.t.orig	2007-10-02 14:32:44.000000000 +0200
+++ perl-current/t/lib/cygwin.t	2008-06-01 14:33:55.156250000 +0200
@@ -43,7 +43,7 @@
 is(Cygwin::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");
 
 my $mount = join '', `/usr/bin/mount`;
-$mount =~ m|on /usr/bin type .+ \((\w+mode)\)|m;
+$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
 my $binmode = $1 eq 'binmode';
 is(Cygwin::is_binmount("/"),  $binmode ? 1 : '', "check / for binmount");
 

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2008

From @rgs

2008/6/1 Reini Urban <rurban@​x-ray.at>​:

Attached patch fixes bug #55160 for 5.10 and blead
A simple cygwin mount test fix.

Thanks, applied as #33982.

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2008

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2008

@rgs - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant