Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarification about @ISA declaration in perlboot.pod (with patch) #9043

Closed
p5pRT opened this issue Sep 25, 2007 · 6 comments
Closed

clarification about @ISA declaration in perlboot.pod (with patch) #9043

p5pRT opened this issue Sep 25, 2007 · 6 comments
Labels
distro-Linux documentation

Comments

@p5pRT
Copy link

p5pRT commented Sep 25, 2007

Migrated from rt.perl.org#45733 (status was 'resolved')

Searchable as RT45733$
@p5pRT
Copy link
Author

p5pRT commented Sep 25, 2007

From johnh@isi.edu

Created by johnh@isi.edu

The OO tutorial perlboot.pod omits one of the shorthand ways to declare @​ISA. It should be included (TMTOWTDI, right?).

Patch to fix docs is below.

  -John Heidemann

Inline Patch 
--- perlboot.pod-       2007-09-24 16:42:08.000000000 -0700
+++ perlboot.pod        2007-09-24 16:43:40.000000000 -0700
@@ -253,6 +253,11 @@
 
     @Cow::ISA = qw(Animal);
 
+Or declare it package global variable:
+
+    package Cow;
+    our @ISA = qw(Animal);
+
 Or allow it as an implicitly named package variable:
 
     package Cow;
Perl Info 

Flags:
    category=docs
    severity=medium

This perlbug was built using Perl v5.8.8 in the Red Hat build system.
It is being executed now by Perl v5.8.8 - Sat Aug 18 04:53:05 EDT 2007.

Site configuration information for perl v5.8.8:

Configured by Red Hat, Inc. at Sat Aug 18 04:53:05 EDT 2007.

Summary of my perl5 (revision 5 version 8 subversion 8) configuration:
  Platform:
    osname=linux, osvers=2.6.20-1.2962.fc6xen, archname=i386-linux-thread-multi
    uname='linux xenbuilder2.fedora.redhat.com 2.6.20-1.2962.fc6xen #1 smp tue jun 19 19:10:51 edt 2007 i686 i686 i386 gnulinux '
    config_args='-des -Doptimize=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -Dversion=5.8.8 -Dmyhostname=localhost -Dperladmin=root@localhost -Dcc=gcc -Dcf_by=Red Hat, Inc. -Dinstallprefix=/usr -Dprefix=/usr -Darchname=i386-linux -Dvendorprefix=/usr -Dsiteprefix=/usr -Duseshrplib -Dusethreads -Duseithreads -Duselargefiles -Dd_dosuid -Dd_semctl_semun -Di_db -Ui_ndbm -Di_gdbm -Di_shadow -Di_syslog -Dman3ext=3pm -Duseperlio -Dinstallusrbinperl=n -Ubincompat5005 -Uversiononly -Dpager=/usr/bin/less -isr -Dd_gethostent_r_proto -Ud_endhostent_r_proto -Ud_sethostent_r_proto -Ud_endprotoent_r_proto -Ud_setprotoent_r_proto -Ud_endservent_r_proto -Ud_setservent_r_proto -Dinc_version_list=5.8.7 5.8.6 5.8.5 -Dscriptdir=/usr/bin'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=define use5005threads=undef useithreads=define usemultiplicity=define
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='gcc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -Wdeclaration-after-statement -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm',
    optimize='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -Wdeclaration-after-statement -I/usr/local/include -I/usr/include/gdbm'
    ccversion='', gccversion='4.1.2 20070502 (Red Hat 4.1.2-12)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='gcc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lresolv -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc
    perllibs=-lresolv -lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    libc=/lib/libc-2.6.so, so=so, useshrplib=true, libperl=libperl.so
    gnulibc_version='2.6'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/usr/lib/perl5/5.8.8/i386-linux-thread-multi/CORE'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -L/usr/local/lib'

Locally applied patches:
    


@INC for perl v5.8.8:
    /usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.7/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.6/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.8
    /usr/lib/perl5/site_perl/5.8.7
    /usr/lib/perl5/site_perl/5.8.6
    /usr/lib/perl5/site_perl/5.8.5
    /usr/lib/perl5/site_perl
    /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.7/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.5/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.8
    /usr/lib/perl5/vendor_perl/5.8.7
    /usr/lib/perl5/vendor_perl/5.8.6
    /usr/lib/perl5/vendor_perl/5.8.5
    /usr/lib/perl5/vendor_perl
    /usr/lib/perl5/5.8.8/i386-linux-thread-multi
    /usr/lib/perl5/5.8.8
    .


Environment for perl v5.8.8:
    HOME=/home/johnh
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH=/usr/local/lib
    LOGDIR (unset)
    PATH=/home/johnh/BIN:/home/johnh/BIN/LINUX:/usr/local/bin:/bin:/usr/bin:/home/johnh/BIN/WP:/home/johnh/BIN/HOSTS:/home/johnh/BIN/DB:/usr/X11R6/bin:/usr/local/etc:/usr/local/sbin:/etc:/usr/etc:/sbin:/usr/sbin:/usr/hosts:/usr/local/games:/usr/games
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Apr 27, 2008

From p5p@spam.wizbit.be

On Mon Sep 24 19​:31​:10 2007, johnh@​isi.edu wrote​:

The OO tutorial perlboot.pod omits one of the shorthand ways to
declare @​ISA. It should be included (TMTOWTDI, right?).

Patch to fix docs is below.

-John Heidemann

--- perlboot.pod- 2007-09-24 16​:42​:08.000000000 -0700
+++ perlboot.pod 2007-09-24 16​:43​:40.000000000 -0700
@​@​ -253,6 +253,11 @​@​

 @​Cow​::ISA = qw\(Animal\);

+Or declare it package global variable​:
+
+ package Cow;
+ our @​ISA = qw(Animal);
+
Or allow it as an implicitly named package variable​:

 package Cow;

[Please do not change anything below this line]
-----------------------------------------------------------------

Was there a particular reason why this patch wasn't applied?
(Was it over looked or was it rejected?)

Kind regards,

Bram

@p5pRT
Copy link
Author

p5pRT commented Apr 27, 2008

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2008

From @rgs

2008/4/27 Bram via RT <perlbug-followup@​perl.org>​:

On Mon Sep 24 19​:31​:10 2007, johnh@​isi.edu wrote​:

The OO tutorial perlboot.pod omits one of the shorthand ways to
declare @​ISA. It should be included (TMTOWTDI, right?).

Patch to fix docs is below.

-John Heidemann

--- perlboot.pod- 2007-09-24 16​:42​:08.000000000 -0700
+++ perlboot.pod 2007-09-24 16​:43​:40.000000000 -0700
@​@​ -253,6 +253,11 @​@​

 @&#8203;Cow&#8203;::ISA = qw\(Animal\);

+Or declare it package global variable​:
+
+ package Cow;
+ our @​ISA = qw(Animal);
+
Or allow it as an implicitly named package variable​:

 package Cow;

[Please do not change anything below this line]
-----------------------------------------------------------------

Was there a particular reason why this patch wasn't applied?
(Was it over looked or was it rejected?)

Yes, I never saw it on P5P.
Apparently there are problems relaying perlbug mails currently, this
is not the first case of lost report reported.
CC'ing Robert.

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2008

From @rgs

Thanks, applied to bleadperl.

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2008

@rgs - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Apr 28, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-Linux documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT