Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segfault with binmode ":pop" #8205

Closed
p5pRT opened this issue Nov 11, 2005 · 4 comments
Closed

segfault with binmode ":pop" #8205

p5pRT opened this issue Nov 11, 2005 · 4 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 11, 2005

Migrated from rt.perl.org#37657 (status was 'resolved')

Searchable as RT37657$

@p5pRT
Copy link
Author

p5pRT commented Nov 11, 2005

From Peter.Dintelmann@dresdner-bank.com

This is a bug report for perl from Peter.Dintelmann@​dresdner-bank.com,
generated with the help of perlbug 1.35 running under perl v5.8.7.

Calling binmode() after popping the last IO layer results in a
segmentation fault.

  $ /opt/perl32/bin/perl -e 'binmode STDIN, "​:pop"; \
  > binmode STDIN, "​:stdio"'
  Segmentation Fault

The patch below tries to fix this. The code now runs ok.

  $ /opt/perl32/bin/perl -le 'binmode STDIN, "​:pop"; \
  > binmode STDIN, "​:stdio"; \
  > $,=$/; print PerlIO​::get_layers STDIN'
  stdio

Proposed patch​:

Inline Patch
--- perlio.c    Thu Nov 10 10:38:40 2005
+++ perl-5.8.7/perlio.c Fri Nov 11 14:23:19 2005
@@ -1285,9 +1285,9 @@
 int
 PerlIO_binmode(pTHX_ PerlIO *f, int iotype, int mode, const char *names)
 {
-    PerlIO_debug("PerlIO_binmode f=%p %s %c %x %s\n",
-                (void*)f, PerlIOBase(f)->tab->name, iotype, mode,
-                (names) ? names : "(Null)");
+    PerlIO_debug("PerlIO_binmode f=%p %s %c %x %s\n", (void*)f,
+                (PerlIOBase(f)) ? PerlIOBase(f)->tab->name : "(Null)",
+                iotype, mode, (names) ? names : "(Null)");
     if (names) {
        /* Do not flush etc. if (e.g.) switching encodings.
           if a pushed layer knows it needs to flush lower layers

---
Flags:   category=core   severity=low

Site configuration information for perl v5.8.7​:

Configured by p013176 at Wed Jun 1 15​:12​:46 MEST 2005.

Summary of my perl5 (revision 5 version 8 subversion 7) configuration​:
  Platform​:
  osname=solaris, osvers=2.9, archname=sun4-solaris-thread-multi-64int
  uname='sunos oikbm03 5.9 generic_112233-01 sun4u sparc sunw,ultra-5_10 '
  config_args='-Dprefix=/opt/perl32 -Uinstallusrbinperl -Dcc=gcc
-Doptimize=-O2 -Aldflags=-R/usr/local/lib -Duseshrplib -Duseperlio
-Dusethreads -Duselargefiles -Duse64bitint -des'
  hint=recommended, useposix=true, d_sigaction=define
  usethreads=define use5005threads=undef useithreads=define
usemultiplicity=define
  useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
  use64bitint=define use64bitall=undef uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='gcc', ccflags ='-D_REENTRANT -fno-strict-aliasing -pipe
-I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2',
  cppflags='-D_REENTRANT -fno-strict-aliasing -pipe -I/usr/local/include'
  ccversion='', gccversion='3.4.2', gccosandvers='solaris2.9'
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=87654321
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='gcc', ldflags =' -R/usr/local/lib -L/usr/local/lib '
  libpth=/usr/local/lib /usr/lib /usr/ccs/lib
  libs=-lsocket -lnsl -lgdbm -ldl -lm -lpthread -lc
  perllibs=-lsocket -lnsl -ldl -lm -lpthread -lc
  libc=/lib/libc.so, so=so, useshrplib=true, libperl=libperl.so
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' -R
/opt/perl32/lib/5.8.7/sun4-solaris-thread-multi-64int/CORE'
  cccdlflags='-fPIC', lddlflags='-G -R/usr/local/lib -L/usr/local/lib'

Locally applied patches​:


@​INC for perl v5.8.7​:
  /opt/perl32/lib/5.8.7/sun4-solaris-thread-multi-64int
  /opt/perl32/lib/5.8.7
  /opt/perl32/lib/site_perl/5.8.7/sun4-solaris-thread-multi-64int
  /opt/perl32/lib/site_perl/5.8.7
  /opt/perl32/lib/site_perl
  .


Environment for perl v5.8.7​:
  HOME=/export/home/p013176
  LANG (unset)
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/usr/bin​:/bin​:/usr/sbin​:/sbin​:/usr/local/bin/
  PERL_BADLANG (unset)
  SHELL=/usr/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Nov 12, 2005

From @smpeters

Thanks, patch applied with change #26101.

@p5pRT
Copy link
Author

p5pRT commented Nov 12, 2005

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 12, 2005

@smpeters - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant