Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack Z0 destroys the character before #7785

Closed
p5pRT opened this issue Feb 5, 2005 · 4 comments
Closed

pack Z0 destroys the character before #7785

p5pRT opened this issue Feb 5, 2005 · 4 comments
Labels
distro-Linux type-core

Comments

@p5pRT
Copy link

p5pRT commented Feb 5, 2005

Migrated from rt.perl.org#34062 (status was 'resolved')

Searchable as RT34062$
@p5pRT
Copy link
Author

p5pRT commented Feb 5, 2005

From perl-5.8.0@ton.iguana.be

Created by perl-5.8.0@ton.iguana.be

perl -wle 'print for unpack("C*", pack("CZ0", 1, "b"))'
0

This is because a Z0 goes back one position and writes a \0 there
(a Z0 at the start will happily walk outside the string)

After patching​:
./perl -Ilib -wle 'print for unpack("C*", pack("CZ0", 1, "b"))'
1

Patch (relative to 5.8.6)

Inline Patch 
--- pp_pack.c.old	Sat Jan 29 13:26:27 2005
+++ pp_pack.c	Sat Feb  5 18:25:16 2005
@@ -2030,7 +2030,7 @@
 	    }
 	    if ((I32)fromlen >= len) {
 		sv_catpvn(cat, aptr, len);
-		if (datumtype == 'Z')
+		if (datumtype == 'Z' && len > 0)
 		    *(SvEND(cat)-1) = '\0';
 	    }
 	    else {
Perl Info 

Flags:
    category=core
    severity=low

This perlbug was built using Perl v5.8.6 - Fri Dec 24 19:25:13 CET 2004
It is being executed now by  Perl v5.8.4 - Thu Jun  3 13:28:19 CEST 2004.

Site configuration information for perl v5.8.4:

Configured by ton at Thu Jun  3 13:28:19 CEST 2004.

Summary of my perl5 (revision 5 version 8 subversion 4) configuration:
  Platform:
    osname=linux, osvers=2.6.5, archname=i686-linux-64int-ld
    uname='linux quasar 2.6.5 #8 mon apr 5 05:41:20 cest 2004 i686 gnulinux '
    config_args=''
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=define use64bitall=undef uselongdouble=define
    usemymalloc=y, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2 -fomit-frame-pointer',
    cppflags='-fno-strict-aliasing -I/usr/local/include'
    ccversion='', gccversion='3.4.0 20031231 (experimental)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long long', ivsize=8, nvtype='long double', nvsize=12, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lnsl -ldb -ldl -lm -lcrypt -lutil -lc
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
    libc=/lib/libc-2.3.2.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.3.2'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib'

Locally applied patches:
    


@INC for perl v5.8.4:
    /usr/lib/perl5/5.8.4/i686-linux-64int-ld
    /usr/lib/perl5/5.8.4
    /usr/lib/perl5/site_perl/5.8.4/i686-linux-64int-ld
    /usr/lib/perl5/site_perl/5.8.4
    /usr/lib/perl5/site_perl
    .


Environment for perl v5.8.4:
    HOME=/home/ton
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/ton/bin.Linux:/home/ton/bin:/home/ton/bin.SampleSetup:/usr/local/bin:/usr/local/sbin:/home/oracle/product/9.2/bin:/usr/local/ar/bin:/usr/games/bin:/usr/X11R6/bin:/usr/share/bin:/usr/bin:/usr/sbin:/bin:/sbin:.
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Feb 8, 2005

From @rgs

perl-5.8.0@​ton.iguana.be (via RT) wrote​:

perl -wle 'print for unpack("C*", pack("CZ0", 1, "b"))'
0

This is because a Z0 goes back one position and writes a \0 there
(a Z0 at the start will happily walk outside the string)

After patching​:
./perl -Ilib -wle 'print for unpack("C*", pack("CZ0", 1, "b"))'
1

Patch (relative to 5.8.6)

--- pp_pack.c.old Sat Jan 29 13​:26​:27 2005
+++ pp_pack.c Sat Feb 5 18​:25​:16 2005

Thanks, applied to bleadperl as change #23946 (with your example turned
into a regression test.)

@p5pRT
Copy link
Author

p5pRT commented Feb 8, 2005

The RT System itself - Status changed from 'new' to 'open'

@p5pRT p5pRT closed this as completed Feb 8, 2005
@p5pRT
Copy link
Author

p5pRT commented Feb 8, 2005

@rgs - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-Linux type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT