Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File::CheckTree should list Larry Wall as author, not unknown #6981

Closed
p5pRT opened this issue Dec 12, 2003 · 4 comments
Closed

File::CheckTree should list Larry Wall as author, not unknown #6981

p5pRT opened this issue Dec 12, 2003 · 4 comments

Comments

@p5pRT
Copy link

p5pRT commented Dec 12, 2003

Migrated from rt.perl.org#24650 (status was 'resolved')

Searchable as RT24650$

@p5pRT
Copy link
Author

p5pRT commented Dec 12, 2003

From david.dyck@fluke.com

Created by david.dyck@fluke.com

I noticed that File​::CheckTree lists the author as
unknown, but lib/validate.pl in perl4 lists lwall
as the RCS author, and lib/validate.pl in perl5 is
very similar to the perl4 version.

It appears to me that File​::CheckTree is derived
from lib/validate.pl, so credit should be given
to Larry Wall

Perl Info

Flags:
    category=library
    severity=low

Site configuration information for perl v5.9.0:

Configured by dcd at Wed Dec 10 14:20:27 PST 2003.

Summary of my perl5 (revision 5.0 version 9 subversion 0 patch 21874) configuration:
  Platform:
    osname=linux, osvers=2.4.24-pre1, archname=i686-linux
    uname='linux dd 2.4.24-pre1 #3 wed dec 10 14:13:20 pst 2003 i686 '
    config_args='-Dmksymlinks -Dinstallusrbinperl -Uversiononly -Dusedevel -Doptimize=-O3 -g -de -Dcf_email=david.dyck@fluke.com'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef useithreads=undef usemultiplicity=undef
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-DDEBUGGING -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O3 -g',
    cppflags='-DDEBUGGING -fno-strict-aliasing -I/usr/local/include'
    ccversion='', gccversion='egcs-2.91.66.1 19990314/Linux (egcs-1.1.2 release)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=4
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lgdbm -ldbm -ldb -ldl -lm -lc
    perllibs=-ldl -lm -lc
    libc=/lib/libc.so.5.4.44, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic'
    cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib'

Locally applied patches:
    DEVEL21538


@INC for perl v5.9.0:
    /usr/local/lib/perl5/5.9.0/i686-linux
    /usr/local/lib/perl5/5.9.0
    /usr/local/lib/perl5/site_perl/5.9.0/i686-linux
    /usr/local/lib/perl5/site_perl/5.9.0
    /usr/local/lib/perl5/site_perl
    .


Environment for perl v5.9.0:
    HOME=/home/dcd
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/dcd/bin:/sbin:/usr/local/bin:/bin:/usr/bin:/usr/X11/bin:/usr/games:/usr/local/samba:/home/hobbes/tools/scripts:/home/hobbes/tools/linux:/usr0/hobbes/tools/scripts:/usr0/dcd/bin:/apps/general/bin:/usr/public
    PERL5_CPANPLUS_CONFIG=/home/dcd/.cpanplus/config
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Dec 13, 2003

From david.dyck@fluke.com

On Fri, 12 Dec 2003 at 18​:13 -0000, David Dyck <perlbug-followup@​perl.org>...​:

I noticed that File​::CheckTree lists the author as unknown,
but lib/validate.pl in perl4 lists lwall as the RCS author, and
lib/validate.pl in perl5 is very similar to the perl4 version.

It appears to me that File​::CheckTree is derived from lib/validate.pl,
so credit should be given to Larry Wall

I double checked with Larry, and he confirms authorship of
lib/validate.pl, and recognized his work in File​::CheckTree.

Now all we need is a quick patch to lib/File/CheckTree.pm

: > From​: Larry Wall <larry@​wall.org>
: > Date​: Fri, 12 Dec 2003 15​:52​:16 -0800
: >
: > On Fri, Dec 12, 2003 at 10​:59​:58AM -0800, David Dyck wrote​:
: > : you wrote perl4's lib/validate.pl, right?
: >
: > Yes, I did, though that was a loooong time ago. Had to read the doc
: > for File​::CheckTree before I recognized it...

How about this patch?

Inline Patch
--- lib/File/CheckTree.pm.orig	Thu Apr 11 12:46:13 2002
+++ lib/File/CheckTree.pm	Fri Dec 12 23:59:16 2003
@@ -50,7 +50,9 @@

 =head1 AUTHOR

-Unknown.  Revised by Paul Grassie <F<grassie@perl.com>> in 2002.
+File::CheckTree was derived from lib/validate.pl which was
+written by Larry Wall.
+Revised by Paul Grassie <F<grassie@perl.com>> in 2002.

 =head1 HISTORY

@p5pRT
Copy link
Author

p5pRT commented Dec 13, 2003

From @rgs

David Dyck wrote​:

--- lib/File/CheckTree.pm.orig Thu Apr 11 12​:46​:13 2002
+++ lib/File/CheckTree.pm Fri Dec 12 23​:59​:16 2003

Thanks, applied as #21892

@​@​ -50,7 +50,9 @​@​

=head1 AUTHOR

-Unknown. Revised by Paul Grassie <F<grassie@​perl.com>> in 2002.
+File​::CheckTree was derived from lib/validate.pl which was
+written by Larry Wall.
+Revised by Paul Grassie <F<grassie@​perl.com>> in 2002.

=head1 HISTORY

@p5pRT
Copy link
Author

p5pRT commented Dec 13, 2003

@rgs - Status changed from 'new' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant