Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.31.4-274-g30fc7a2809 breaks INGY/Mousse-0.15.tar.gz #17171

Closed
p5pRT opened this issue Oct 4, 2019 · 9 comments
Closed

Bleadperl v5.31.4-274-g30fc7a2809 breaks INGY/Mousse-0.15.tar.gz #17171

p5pRT opened this issue Oct 4, 2019 · 9 comments
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)

Comments

@p5pRT
Copy link

p5pRT commented Oct 4, 2019

Migrated from rt.perl.org#134476 (status was 'open')

Searchable as RT134476$

@p5pRT
Copy link
Author

p5pRT commented Oct 4, 2019

From @andk

https://rt.cpan.org/Ticket/Display.html?id=130649

commit 30fc7a2
Author​: James E Keenan <jkeenan@​cpan.org>
AuthorDate​: Sat May 25 21​:40​:00 2019 -0400
Commit​: Tony Cook <tony@​develop-help.com>
CommitDate​: Wed Oct 2 14​:59​:31 2019 +1000

  Eliminate modifiable variables in constants
 
  Transform previously deprecated cases into exceptions.
 
  Update diagnostic; change D to F
 
  remove now irrelevant code (TonyC)
 
  For​: RT 134138

--
andreas
PS​: perl,perl,perl

@p5pRT
Copy link
Author

p5pRT commented Oct 5, 2019

From @jkeenan

On Fri, 04 Oct 2019 20​:03​:16 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

https://rt.cpan.org/Ticket/Display.html?id=130649

commit 30fc7a2
Author​: James E Keenan <jkeenan@​cpan.org>
AuthorDate​: Sat May 25 21​:40​:00 2019 -0400
Commit​: Tony Cook <tony@​develop-help.com>
CommitDate​: Wed Oct 2 14​:59​:31 2019 +1000

Eliminate modifiable variables in constants

Transform previously deprecated cases into exceptions\.

Update diagnostic; change D to F

remove now irrelevant code \(TonyC\)

For&#8203;: RT 134138

From a failing CPANtesters report​:

#####
PERL_DL_NONLAZY=1 "/tmp/basesmoker-reloperl-5O4J/bin/perl" "-MExtUtils​::Command​::MM" "-MTest​::Harness" "-e" "undef *Test​::Harness​::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t
Constants from lexical variables potentially modified elsewhere are no longer permitted at /home/sand/.cpan/privbuild/k93msid/Mousse-0.15-0/blib/lib/Mousse.pm line 1118.
BEGIN failed--compilation aborted at /home/sand/.cpan/privbuild/k93msid/Mousse-0.15-0/blib/lib/Mousse.pm line 1171.
Compilation failed in require at /home/sand/.cpan/privbuild/k93msid/Mousse-0.15-0/blib/lib/Mousse/Maker.pm line 24.
Can't locate Foo/Mousse.pm in @​INC (you may need to install the Foo​::Mousse module) (@​INC contains​: t/lib /home/sand/.cpan/privbuild/k93msid/Mousse-0.15-0/blib/lib /home/sand/.cpan/privbuild/k93msid/Mousse-0.15-0/blib/arch /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.31.4-275-g7fd0eed3dd/af11/lib/site_perl/5.31.5/x86_64-linux-ld /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.31.4-275-g7fd0eed3dd/af11/lib/site_perl/5.31.5 /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.31.4-275-g7fd0eed3dd/af11/lib/5.31.5/x86_64-linux-ld /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.31.4-275-g7fd0eed3dd/af11/lib/5.31.5 .) at t/lib/Foo.pm line 2.
BEGIN failed--compilation aborted at t/lib/Foo.pm line 2.
Compilation failed in require at t/module-install.t line 19.
BEGIN failed--compilation aborted at t/module-install.t line 19.
# Looks like your test exited with 2 before it could output anything.
t/module-install.t .....
#####

As in #17175, the breaking commit implemented the scheduled fatalization in perl-5.32 of a situation which was previously deprecated. So, other things being equal, the CPAN code should be updated to adapt to the changes in core.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 5, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Oct 6, 2019

From @andk

Also affected​: INGY/Scalar-Random-PP-0.11.tar.gz https://rt.cpan.org/Ticket/Display.html?id=130657

--
andreas

@p5pRT p5pRT added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Severity Low labels Oct 19, 2019
@toddr toddr added this to the 5.32.0 milestone Oct 25, 2019
@toddr toddr removed the 5.32.0 label Oct 25, 2019
@xsawyerx
Copy link
Member

xsawyerx commented Apr 1, 2020

I don't consider this a blocker for 5.32. I want to keep the ticket though.

Any strong objections?

@jkeenan
Copy link
Contributor

jkeenan commented Apr 1, 2020

I don't consider this a blocker for 5.32. I want to keep the ticket though.

Any strong objections?

No. Keep open but not a blocker. The reason for the BBC was a deprecation announced two production releases ago, so maintainers have had plenty of time to adapt.

Thank you very much.
Jim Keenan

@xsawyerx xsawyerx removed this from the 5.32.0 milestone Apr 5, 2020
@xenu xenu removed the Severity Low label Dec 29, 2021
@hvds
Copy link
Contributor

hvds commented Mar 17, 2022

Last update to this module was over 10 years ago, it appears to have been abandoned by its author (though activity continues in some of his other modules). Is there any remaining value from keeping this ticket open?

@jkeenan
Copy link
Contributor

jkeenan commented Mar 17, 2022

Last update to this module was over 10 years ago, it appears to have been abandoned by its author (though activity continues in some of his other modules). Is there any remaining value from keeping this ticket open?

Two years ago I agreed to keep this open at the request of the former pumpking, but I think this ticket is now safely closable. I will self-assign it for the purpose of closing it in 7 days unless someone (in authority) provides a compelling argument otherwise.

@jkeenan jkeenan self-assigned this Mar 17, 2022
@jkeenan jkeenan added the Closable? We might be able to close this ticket, but we need to check with the reporter label Mar 17, 2022
@jkeenan
Copy link
Contributor

jkeenan commented Apr 1, 2022

Last update to this module was over 10 years ago, it appears to have been abandoned by its author (though activity continues in some of his other modules). Is there any remaining value from keeping this ticket open?

Two years ago I agreed to keep this open at the request of the former pumpking, but I think this ticket is now safely closable. I will self-assign it for the purpose of closing it in 7 days unless someone (in authority) provides a compelling argument otherwise.

Closing ticket as per schedule.

@jkeenan jkeenan closed this as completed Apr 1, 2022
@jkeenan jkeenan removed the Closable? We might be able to close this ticket, but we need to check with the reporter label Apr 2, 2022
@jkeenan jkeenan removed their assignment Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)
Projects
None yet
Development

No branches or pull requests

6 participants