Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDBM test fails on Debian 10 #17141

Closed
p5pRT opened this issue Aug 30, 2019 · 8 comments
Closed

GDBM test fails on Debian 10 #17141

p5pRT opened this issue Aug 30, 2019 · 8 comments

Comments

@p5pRT
Copy link

p5pRT commented Aug 30, 2019

Migrated from rt.perl.org#134393 (status was 'rejected')

Searchable as RT134393$

@p5pRT
Copy link
Author

p5pRT commented Aug 30, 2019

From @djerius

Created by @djerius

After compiling perl5.28.1 on a fresh install of Debian 10, a single
test, 'ext/GDBM_File/t/fatal.t' fails. Here's the error​:

export LD_LIBRARY_PATH=`pwd`
./perl -Ilib ext/GDBM_File/t/fatal.t
1..8
ok 1 - use GDBM_File;
ok 2 - Can find next available file descriptor
ok 3 - Check that we cannot open fileno 3. $! is Bad file descriptor
ok 4 - An object of class 'GDBM_File' isa 'GDBM_File'
ok 5 - dup fileno 3
ok 6 - close fileno 3, out from underneath the GDBM_File
not ok 7 - Trapped error when attempting to write to knobbled GDBM_File
# Failed test 'Trapped error when attempting to write to knobbled GDBM_File'
# at ext/GDBM_File/t/fatal.t line 37.
# got​: '1'
# expected​: undef
not ok 8 - expected error message from GDBM_File
# Failed test 'expected error message from GDBM_File'
# at ext/GDBM_File/t/fatal.t line 46.
# ''
# doesn't match '(?^​: at .*\bfatal\.t line \d+\.\n\z)'
# Looks like you failed 2 tests of 8.

and here's what's installed for gdbm​:

gdbm-l10n 1.18.1-4
libgdbm-compat4​:amd64 1.18.1-4
libgdbm-dev​:amd64 1.18.1-4
libgdbm6​:amd64 1.18.1-4

Perl Info

Flags:
    category=library
    severity=medium
    module=GDBM_File

Site configuration information for perl 5.28.1:

Configured by dj at Fri Aug 30 14:46:26 EDT 2019.

Summary of my perl5 (revision 5 version 28 subversion 1) configuration:
   
  Platform:
    osname=linux
    osvers=4.19.0-5-amd64
    archname=x86_64-linux_debian-10-thread-multi
    uname='linux macabre 4.19.0-5-amd64 #1 smp debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 gnulinux '
    config_args='-de -Dprefix=/proj/axaf/ots/x86_64-linux_debian-10 -Uinstallusrbinperl -Dperladmin=none -Dlocincpth=/proj/axaf/ots/include -Darchname=x86_64-linux_debian-10 -Dusethreads -Dotherlibdirs=/proj/axaf/simul/lib/perl5:/proj/axaf/simul/x86_64-linux_debian-10/lib/perl5'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/proj/axaf/ots/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
    optimize='-O2'
    cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/proj/axaf/ots/include'
    ccversion=''
    gccversion='8.3.0'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64
    libs=-lpthread -lnsl -lgdbm -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.28.so
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.28'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'



@INC for perl 5.28.1:
    lib
    /proj/axaf/ots/x86_64-linux_debian-10/lib/perl5/site_perl/5.28.1/x86_64-linux_debian-10-thread-multi
    /proj/axaf/ots/x86_64-linux_debian-10/lib/perl5/site_perl/5.28.1
    /proj/axaf/ots/x86_64-linux_debian-10/lib/perl5/5.28.1/x86_64-linux_debian-10-thread-multi
    /proj/axaf/ots/x86_64-linux_debian-10/lib/perl5/5.28.1
    /proj/axaf/simul/lib/perl5
    /proj/axaf/simul/x86_64-linux_debian-10/lib/perl5


Environment for perl 5.28.1:
    HOME=/home/axafbin
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH=/tmp/axafbin/perl-5.28.1
    LOGDIR (unset)
    PATH=/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Aug 30, 2019

From @csjewell

I KNOW this is a duplicate, let me go and find...

Here it is​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133295

Specifically, perl was updated between when 5.28.0 was released and when 5.30.0 was released in order to fix this issue.

@p5pRT
Copy link
Author

p5pRT commented Aug 30, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 30, 2019

From @jkeenan

On Fri, 30 Aug 2019 20​:53​:03 GMT, csjewell wrote​:

I KNOW this is a duplicate, let me go and find...

Here it is​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133295

Specifically, perl was updated between when 5.28.0 was released and
when 5.30.0 was released in order to fix this issue.

Curtis, thanks for that research!

Closing this ticket.
Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Aug 30, 2019

@jkeenan - Status changed from 'open' to 'rejected'

@p5pRT p5pRT closed this as completed Aug 30, 2019
@p5pRT
Copy link
Author

p5pRT commented Aug 30, 2019

From @djerius

Yes. thanks much for that! For some reason I missed that in my search of
rt.perl.org.

Apologies for the noise.

On Fri, Aug 30, 2019 at 5​:02 PM James E Keenan via RT <
perlbug-followup@​perl.org> wrote​:

On Fri, 30 Aug 2019 20​:53​:03 GMT, csjewell wrote​:

I KNOW this is a duplicate, let me go and find...

Here it is​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133295

Specifically, perl was updated between when 5.28.0 was released and
when 5.30.0 was released in order to fix this issue.

Curtis, thanks for that research!

Closing this ticket.
Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 2, 2019

From @tomhukins

On Fri, Aug 30, 2019 at 02​:02​:13PM -0700, James E Keenan via RT wrote​:

On Fri, 30 Aug 2019 20​:53​:03 GMT, csjewell wrote​:

Here it is​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133295

Curtis, thanks for that research!

Closing this ticket.

So, perl users have now reported this issue against 5.28.x twice. We've
fixed the problem in 5.30, but left if unaddressed in 5.28.

What's the advantage of taking no action and closing this ticket instead
of backporting the fix to origin/maint-5.28? I don't know the
backporting policy well, but this strikes me as a missed opportunity.

Tom

@p5pRT
Copy link
Author

p5pRT commented Sep 2, 2019

From @craigberry

On Mon, Sep 2, 2019 at 7​:07 AM Tom Hukins <tom@​eborcom.com> wrote​:

On Fri, Aug 30, 2019 at 02​:02​:13PM -0700, James E Keenan via RT wrote​:

On Fri, 30 Aug 2019 20​:53​:03 GMT, csjewell wrote​:

Here it is​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133295

Curtis, thanks for that research!

Closing this ticket.

So, perl users have now reported this issue against 5.28.x twice. We've
fixed the problem in 5.30, but left if unaddressed in 5.28.

What's the advantage of taking no action and closing this ticket instead
of backporting the fix to origin/maint-5.28? I don't know the
backporting policy well, but this strikes me as a missed opportunity.

I think we often assume that all modules are dual-life because most of
the ones included in core are, and dual-life modules are explicitly
excluded from what's eligible for backport in L<perlpolicy/MAINTENANCE
BRANCHES>. However, as far as I can find, GDBM_File is core-only, so
you are right, this seems like a reasonable candidate for a backport,
and Steve Hay already added it to the 5.28 voting file months ago​:

<https://perl5.git.perl.org/perl.git/commitdiff/afa340664e8ce4c80cf4be87e92aab06ab9d7b70>

<https://perl5.git.perl.org/perl.git/blob/refs/heads/maint-votes:/votes-5.28.xml#l54>

It looks like it needs one more vote to make into the next maint release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant