Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in a Test2::API::Breakage warning #17137

Closed
p5pRT opened this issue Aug 26, 2019 · 7 comments
Closed

Typo in a Test2::API::Breakage warning #17137

p5pRT opened this issue Aug 26, 2019 · 7 comments
Labels
distro-All sendToCPAN type-library

Comments

@p5pRT
Copy link

p5pRT commented Aug 26, 2019

Migrated from rt.perl.org#134381 (status was 'pending release')

Searchable as RT134381$
@p5pRT
Copy link
Author

p5pRT commented Aug 26, 2019

From choroba@matfyz.cz

Created by choroba@matfyz.cz

Test2 "recommeds" to update related test modules instead of
"recommending" to update them. See the attached patch.

Ch.

Perl Info 

Flags:
     category=library
     severity=low

Site configuration information for perl 5.31.4:

Configured by choroba at Mon Aug 26 16:15:05 CEST 2019.

Summary of my perl5 (revision 5 version 31 subversion 4) configuration:
   Commit id: 6e404ab585deadc1c32d50513f13b50ae395c00d
   Platform:
     osname=linux
     osvers=4.12.14-lp151.28.13-default
     archname=x86_64-linux-thread-multi
     uname='linux lenonovo 4.12.14-lp151.28.13-default #1 smp wed aug 7 07:20:16 utc 2019 (0c09ad2) x86_64 x86_64 x86_64 gnulinux '
     config_args='-rdes -Dusethreads -Dpthread -Dprefix=~/blead -Dusedevel'
     hint=recommended
     useposix=true
     d_sigaction=define
     useithreads=define
     usemultiplicity=define
     use64bitint=define
     use64bitall=define
     uselongdouble=undef
     usemymalloc=n
     default_inc_excludes_dot=define
     bincompat5005=undef
   Compiler:
     cc='cc'
     ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
     optimize='-O2'
     cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
     ccversion=''
     gccversion='7.4.1 20190424 [gcc-7-branch revision 270538]'
     gccosandvers=''
     intsize=4
     longsize=8
     ptrsize=8
     doublesize=8
     byteorder=12345678
     doublekind=3
     d_longlong=define
     longlongsize=8
     d_longdbl=define
     longdblsize=16
     longdblkind=3
     ivtype='long'
     ivsize=8
     nvtype='double'
     nvsize=8
     Off_t='off_t'
     lseeksize=8
     alignbytes=8
     prototype=define
   Linker and Libraries:
     ld='cc'
     ldflags =' -fstack-protector-strong -L/usr/local/lib'
     libpth=/usr/local/lib /usr/lib64/gcc/x86_64-suse-linux/7/include-fixed /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib /lib64 /usr/lib64 /usr/local/lib64
     libs=-lpthread -lgdbm -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
     perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
     libc=libc-2.26.so
     so=so
     useshrplib=false
     libperl=libperl.a
     gnulibc_version='2.26'
   Dynamic Linking:
     dlsrc=dl_dlopen.xs
     dlext=so
     d_dlsymun=undef
     ccdlflags='-Wl,-E'
     cccdlflags='-fPIC'
     lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'



@INC for perl 5.31.4:
     /home/choroba/blead/lib/perl5/site_perl/5.31.4/x86_64-linux-thread-multi
     /home/choroba/blead/lib/perl5/site_perl/5.31.4
     /home/choroba/blead/lib/perl5/5.31.4/x86_64-linux-thread-multi
     /home/choroba/blead/lib/perl5/5.31.4


Environment for perl 5.31.4:
     HOME=/home/choroba
     LANG=en_US.utf8
     LANGUAGE (unset)
     LC_CTYPE=en_US.UTF-8
     LD_LIBRARY_PATH (unset)
     LOGDIR (unset)
     PATH=/home/choroba/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/home/choroba/perl5/bin:/home/choroba/opensource/worktime/bin:.
     PERL_BADLANG (unset)
     SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Aug 26, 2019

From choroba@matfyz.cz

0001-Fix-a-typo-in-a-Test2-API-Breakage-warning.patch 
From 8682e2afe6daee5169de8b1e68c85ebbab3635a2 Mon Sep 17 00:00:00 2001
From: "E.Choroba" <choroba@matfyz.cz>
Date: Mon, 26 Aug 2019 17:42:48 +0200
Subject: [PATCH] Fix a typo in a Test2::API::Breakage warning

---
 cpan/Test-Simple/lib/Test2/API/Breakage.pm      | 2 +-
 cpan/Test-Simple/t/Test2/modules/API/Breakage.t | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpan/Test-Simple/lib/Test2/API/Breakage.pm b/cpan/Test-Simple/lib/Test2/API/Breakage.pm
index 106748a513..77b97c31ac 100644
--- a/cpan/Test-Simple/lib/Test2/API/Breakage.pm
+++ b/cpan/Test-Simple/lib/Test2/API/Breakage.pm
@@ -73,7 +73,7 @@ sub report {
         next unless $INC{$file} || ($require && eval { require $file; 1 });
         my $want = $suggest{$mod};
         next if eval { $mod->VERSION($want); 1 };
-        push @warn => " * Module '$mod' is outdated, we recommed updating above $want.";
+        push @warn => " * Module '$mod' is outdated, we recommend updating above $want.";
     }
 
     for my $mod (keys %required) {
diff --git a/cpan/Test-Simple/t/Test2/modules/API/Breakage.t b/cpan/Test-Simple/t/Test2/modules/API/Breakage.t
index e2932469f3..f5af6c59a6 100644
--- a/cpan/Test-Simple/t/Test2/modules/API/Breakage.t
+++ b/cpan/Test-Simple/t/Test2/modules/API/Breakage.t
@@ -53,7 +53,7 @@ for my $meth (qw/upgrade_suggested upgrade_required known_broken/) {
             [sort @report],
             [
                 sort
-                " * Module 'T2Test::UG1' is outdated, we recommed updating above 1.0.",
+                " * Module 'T2Test::UG1' is outdated, we recommend updating above 1.0.",
                 " * Module 'T2Test::UR1' is outdated and known to be broken, please update to 1.0 or higher.",
                 " * Module 'T2Test::KB1' is known to be broken in version 1.0 and below, newer versions have not been tested. You have: 0.9",
                 " * Module 'T2Test::KB2' is known to be broken in version 0.5 and below, newer versions have not been tested. You have: 0.9",
-- 
2.16.4

@p5pRT
Copy link
Author

p5pRT commented Aug 26, 2019

From @Grinnz

On Mon, 26 Aug 2019 08​:45​:22 -0700, choroba@​matfyz.cz wrote​:

This is a bug report for perl from choroba@​matfyz.cz,
generated with the help of perlbug 1.41 running under perl 5.31.4.

-----------------------------------------------------------------
[Please describe your issue here]

Test2 "recommeds" to update related test modules instead of
"recommending" to update them. See the attached patch.

Ch.

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags​:
category=library
severity=low
---
Site configuration information for perl 5.31.4​:

Configured by choroba at Mon Aug 26 16​:15​:05 CEST 2019.

Summary of my perl5 (revision 5 version 31 subversion 4)
configuration​:
Commit id​: 6e404ab
Platform​:
osname=linux
osvers=4.12.14-lp151.28.13-default
archname=x86_64-linux-thread-multi
uname='linux lenonovo 4.12.14-lp151.28.13-default #1 smp wed aug
7 07​:20​:16 utc 2019 (0c09ad2) x86_64 x86_64 x86_64 gnulinux '
config_args='-rdes -Dusethreads -Dpthread -Dprefix=~/blead
-Dusedevel'
hint=recommended
useposix=true
d_sigaction=define
useithreads=define
usemultiplicity=define
use64bitint=define
use64bitall=define
uselongdouble=undef
usemymalloc=n
default_inc_excludes_dot=define
bincompat5005=undef
Compiler​:
cc='cc'
ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing
-pipe -fstack-protector-strong -I/usr/local/include
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
optimize='-O2'
cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing
-pipe -fstack-protector-strong -I/usr/local/include'
ccversion=''
gccversion='7.4.1 20190424 [gcc-7-branch revision 270538]'
gccosandvers=''
intsize=4
longsize=8
ptrsize=8
doublesize=8
byteorder=12345678
doublekind=3
d_longlong=define
longlongsize=8
d_longdbl=define
longdblsize=16
longdblkind=3
ivtype='long'
ivsize=8
nvtype='double'
nvsize=8
Off_t='off_t'
lseeksize=8
alignbytes=8
prototype=define
Linker and Libraries​:
ld='cc'
ldflags =' -fstack-protector-strong -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib64/gcc/x86_64-suse-linux/7/include-
fixed /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-
linux/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib /lib64
/usr/lib64 /usr/local/lib64
libs=-lpthread -lgdbm -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
libc=libc-2.26.so
so=so
useshrplib=false
libperl=libperl.a
gnulibc_version='2.26'
Dynamic Linking​:
dlsrc=dl_dlopen.xs
dlext=so
d_dlsymun=undef
ccdlflags='-Wl,-E'
cccdlflags='-fPIC'
lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

---
@​INC for perl 5.31.4​:
/home/choroba/blead/lib/perl5/site_perl/5.31.4/x86_64-linux-
thread-multi
/home/choroba/blead/lib/perl5/site_perl/5.31.4
/home/choroba/blead/lib/perl5/5.31.4/x86_64-linux-thread-multi
/home/choroba/blead/lib/perl5/5.31.4

---
Environment for perl 5.31.4​:
HOME=/home/choroba
LANG=en_US.utf8
LANGUAGE (unset)
LC_CTYPE=en_US.UTF-8
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH=/home/choroba/bin​:/usr/local/bin​:/usr/bin​:/bin​:/usr/bin/X11​:/home/choroba/perl5/bin​:/home/choroba/opensource/worktime/bin​:.
PERL_BADLANG (unset)
SHELL=/bin/bash

FYI, Test2 is maintained on CPAN​: https://github.com/Test-More/test-more

-Dan

@p5pRT
Copy link
Author

p5pRT commented Aug 26, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 26, 2019

From @exodist

Patch applied to the cpan module source code​: Test-More/test-more@9b595a6

Next time I mint a release this will go out, and we can then close this ticket.

@p5pRT
Copy link
Author

p5pRT commented Oct 13, 2019

From @jkeenan

On Mon, 26 Aug 2019 21​:09​:15 GMT, exodist7@​gmail.com wrote​:

Patch applied to the cpan module source code​: https://github.com/Test-
More/test-more/commit/9b595a698bb4b83febb4421be7edd665a926a30a

Next time I mint a release this will go out, and we can then close
this ticket.

This was fixed in commit 00ea29f (Chad Granum 2019-09-13).

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 13, 2019

@jkeenan - Status changed from 'open' to 'pending release'

@p5pRT p5pRT closed this as completed Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-All sendToCPAN type-library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT