Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] "--sysroot X" should be "--sysroot=X" in Configure #17126

Closed
p5pRT opened this issue Aug 13, 2019 · 6 comments
Closed

[PATCH] "--sysroot X" should be "--sysroot=X" in Configure #17126

p5pRT opened this issue Aug 13, 2019 · 6 comments
Labels

Comments

@p5pRT
Copy link

p5pRT commented Aug 13, 2019

Migrated from rt.perl.org#134360 (status was 'pending release')

Searchable as RT134360$

@p5pRT
Copy link
Author

p5pRT commented Aug 13, 2019

From @haukex

Hi,

As the subject says​: --sysroot is mentioned three times in Configure,
twice as "--sysroot=something", and once as "--sysroot something", and
the latter caused problems in one of my builds. Patch attached.

Best,
-- Hauke D

@p5pRT
Copy link
Author

p5pRT commented Aug 13, 2019

From @haukex

0001-Change-sysroot-X-to-sysroot-X-in-Configure.patch
From f9caeea72985f90cbcf505dd18bd77feba87cea5 Mon Sep 17 00:00:00 2001
From: Hauke D <haukex@zero-g.net>
Date: Tue, 13 Aug 2019 22:05:47 +0200
Subject: [PATCH] Change "--sysroot X" to "--sysroot=X" in Configure

---
 Configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Configure b/Configure
index 76ab5b3230..fe162b1ad8 100755
--- a/Configure
+++ b/Configure
@@ -8554,7 +8554,7 @@ EOM
 	if $test "X$sysroot" != X; then
 	    case "$gccversion" in
 		'') ;;
-		*)  dflt="$dflt --sysroot $sysroot" ;;
+		*)  dflt="$dflt --sysroot=$sysroot" ;;
 	    esac
 	fi
 
-- 
2.22.0

@p5pRT
Copy link
Author

p5pRT commented Aug 26, 2019

From @tonycoz

On Tue, 13 Aug 2019 13​:14​:26 -0700, haukex@​zero-g.net wrote​:

Hi,

As the subject says​: --sysroot is mentioned three times in Configure,
twice as "--sysroot=something", and once as "--sysroot something", and
the latter caused problems in one of my builds. Patch attached.

Best,
-- Hauke D

Thanks, applied as 6e404ab.

Posted to what I believe is the upstream metaconfig as Perl/metaconfig#58

Tony

@p5pRT
Copy link
Author

p5pRT commented Aug 26, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 26, 2019

@tonycoz - Status changed from 'open' to 'pending release'

@p5pRT p5pRT closed this as completed Aug 26, 2019
@p5pRT
Copy link
Author

p5pRT commented Aug 26, 2019

From @haukex

Hi,

Thank you!

Best,
-- Hauke D

On 26.08.19 06​:56, Tony Cook via RT wrote​:

On Tue, 13 Aug 2019 13​:14​:26 -0700, haukex@​zero-g.net wrote​:

As the subject says​: --sysroot is mentioned three times in Configure,
twice as "--sysroot=something", and once as "--sysroot something", and
the latter caused problems in one of my builds. Patch attached.

Thanks, applied as 6e404ab.

Posted to what I believe is the upstream metaconfig as Perl/metaconfig#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant