Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New build-time warning: autodoc.pl #17124

Closed
p5pRT opened this issue Aug 13, 2019 · 4 comments
Closed

New build-time warning: autodoc.pl #17124

p5pRT opened this issue Aug 13, 2019 · 4 comments
Labels
build-time-warnings Replaces [META] Build-time warnings RT #133556

Comments

@p5pRT
Copy link

p5pRT commented Aug 13, 2019

Migrated from rt.perl.org#134357 (status was 'resolved')

Searchable as RT134357$

@p5pRT
Copy link
Author

p5pRT commented Aug 13, 2019

From @jkeenan

When building perl in my customary manner on Linux, I am getting the
following new build-time warning​:

#####
./miniperl -Ilib autodoc.pl
embed.fnc entry 'sv_utf8_upgrade_flags_grow' missing 'd' flag at
autodoc.pl line 135, <F> line 3479.
#####

The relevant code in autodoc.pl​:

#####
131 if ($embed_docref and %$embed_docref) {
132 warn "embed.fnc entry overrides redundant
information in"
133 . " '$proto_in_file' in $file" if $flags || $ret
|| @​args;
134 $flags = $embed_docref->{'flags'};
135 warn "embed.fnc entry '$name' missing 'd' flag"
136 unless
$flags =~ /d/;
137 $ret = $embed_docref->{'retval'};
138 @​args = @​{$embed_docref->{args}};
139 } elsif ($flags !~ /m/) { # Not in embed.fnc, is
missing if not a
#####

On the basis of when embed.fnc has most recently, I suspect a commit
more recent than 03b7d27 (applied to
blead July 22).

perl perl perl

@p5pRT
Copy link
Author

p5pRT commented Aug 13, 2019

From @khwilliamson

Fixed by

commit defad34
Author​: Karl Williamson <khw@​cpan.org>
Date​: Mon Aug 12 19​:14​:30 2019 -0600

  PATCH​: [perl #134357] embed.fnc missing flag for docs
 
  A check was recently added if a function had documentation that
  embed.fnc accurately reflected that. Commit
  c1a02cc missed this function

--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Aug 13, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 13, 2019

@khwilliamson - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Aug 13, 2019
@jkeenan jkeenan added the build-time-warnings Replaces [META] Build-time warnings RT #133556 label Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-time-warnings Replaces [META] Build-time warnings RT #133556
Projects
None yet
Development

No branches or pull requests

2 participants