-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core taint tests should be skipped instead of failing when SILENT_NO_TAINT_SUPPORT is set #17095
Comments
From burak.gursoy@booking.comCreated by burak.gursoy@booking.comSILENT_NO_TAINT_SUPPORT causes all taint tests spread over lots of places in the Perl Info
|
From burak.gursoy@booking.comBuild log attached. I've previously tried to reply to the email with the attachment, but apparently that failed. |
From @jkeenanOn Mon, 15 Jul 2019 12:19:45 GMT, burak.gursoy@booking.com wrote:
Would you be able to provide a list of the test files in the core distribution which fail in this situation? (Yes, I concede that anyone can run this, but if there are lots of files failing we should have more than one list of failures for QA purposes.) Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Sat, 20 Jul 2019 13:09:18 GMT, jkeenan wrote:
Okay, I can confirm that with a configuration like this: ##### ... the following tests fail: ##### However, before we embark on fixes to these files -- which implies bug tickets for the 4 upstream CPAN distros -- we should decide what is the best way to write a SKIP condition for this situation. The patch attached "works" on one selected file, but seems verbose and inflexible. Thank you very much. |
From @jkeenan0001-Skip-all-if-built-with-DSILENT_NO_TAINT_SUPPORT.patchFrom 5d4811b7d3f9d02cec0a6abeb9ca3937eba3c62d Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Sun, 21 Jul 2019 10:58:53 -0400
Subject: [PATCH] Skip all if built with -DSILENT_NO_TAINT_SUPPORT
For: RT # 134287
---
t/op/taint.t | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/t/op/taint.t b/t/op/taint.t
index dd9f2edd97..ac987acbc5 100644
--- a/t/op/taint.t
+++ b/t/op/taint.t
@@ -12,10 +12,17 @@ BEGIN {
require './test.pl';
set_up_inc('../lib');
require './loc_tools.pl';
+ use Config;
+ skip_all("perl built with SILENT_NO_TAINT_SUPPORT") if (
+ $Config{ccflags} =~ m/-DSILENT_NO_TAINT_SUPPORT/
+ or
+ $Config{cppflags} =~ m/-DSILENT_NO_TAINT_SUPPORT/
+ or
+ $Config{ccflags_nolargefiles} =~ m/-DSILENT_NO_TAINT_SUPPORT/
+ );
}
use strict;
-use Config;
plan tests => 1042;
--
2.17.1
|
From burak.gursoy@booking.comOn Sun, 21 Jul 2019 08:01:20 -0700, jkeenan wrote:
Hi, I see that you ran it yourself, but the attached log also includes the test phase and the failures.
Cool :)
|
What formerly was bug ticket RT # 134287 is now GH issue Perl#17095.
Today I built a perl at HEAD of blead with
All tests PASSed. I logged
Then I re-ran tests for 6 files named earlier in this ticket not found in the list above.
I think that means that everything cited as problematic in the original post back in 2019 has been addressed, but I'd appreciate additional eyeballs. |
Migrated from rt.perl.org#134287 (status was 'open')
Searchable as RT134287$
The text was updated successfully, but these errors were encountered: