Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBC: f23e1643 breaks Data::Alias #17072

Closed
p5pRT opened this issue Jul 2, 2019 · 11 comments
Closed

BBC: f23e1643 breaks Data::Alias #17072

p5pRT opened this issue Jul 2, 2019 · 11 comments
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)

Comments

@p5pRT
Copy link

p5pRT commented Jul 2, 2019

Migrated from rt.perl.org#134252 (status was 'open')

Searchable as RT134252$

@p5pRT
Copy link
Author

p5pRT commented Jul 2, 2019

From @jkeenan

This was first reported to me off list by Carlos Guevara, based on his
smoke testing rigs.

http://matrix.cpantesters.org/?dist=Data-Alias

http://matrix.cpantesters.org/?dist=Syntax-Keyword-Try

Carlos also reported that test(s) in the latter distro hung. I can
confirm that on FreeBSD-11, Syntax::Keyword::Try's test t/11loop.t hung
indefinitely and had to be Ctrl-C-ed for smoking to proceed. I was
consequently not able to get a definitive bisection for that module.

On Linux I was able to bisect the problem with Data::Alias to:

f23e164367e8b9494783181262bf4a1a16d26961 is the first bad commit
commit f23e164367e8b9494783181262bf4a1a16d26961
Author: David Mitchell <davem@iabyn.com>
Date: Tue Jun 18 15:11:12 2019 +0100

Perl_list() tail-call optimise

The part of this function that scans the children of e.g.

@a = do { void; void; list }

applying list context only to the last child, tail call
optimise that call to list().

(See also a few commits later entitled "Perl_scalar()
tail-call optimise" for a discourse on setting PL_curcop
(in)correctly.)

:100644 100644 77dc177ec9bfd8c488d2a62aacaaaedc4f2658b7
a30740f2a5a449b1644665331ba560cbc9c167ee M op.c
#####

No further diagnose yet attempted.

Thank you very much.
Jim Keenan

perl perl perl

@p5pRT
Copy link
Author

p5pRT commented Jul 2, 2019

From @jkeenan

On Tue, 02 Jul 2019 03​:02​:02 GMT, jkeenan@​pobox.com wrote​:

This was first reported to me off list by Carlos Guevara, based on his
smoke testing rigs.

http​://matrix.cpantesters.org/?dist=Data-Alias

http​://matrix.cpantesters.org/?dist=Syntax-Keyword-Try

Carlos also reported that test(s) in the latter distro hung. I can
confirm that on FreeBSD-11, Syntax​::Keyword​::Try's test t/11loop.t hung
indefinitely and had to be Ctrl-C-ed for smoking to proceed. I was
consequently not able to get a definitive bisection for that module.

Discussion of the hanging test in Syntax​::Keyword​::Try's test suite is moved to #17076.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Jul 2, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT p5pRT added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Severity Low distro-Linux distro-freebsd distro-netbsd labels Oct 19, 2019
@toddr toddr added this to the 5.32.0 milestone Oct 25, 2019
@toddr toddr removed the 5.32.0 label Oct 25, 2019
@toddr toddr added Closable? We might be able to close this ticket, but we need to check with the reporter and removed Closable? We might be able to close this ticket, but we need to check with the reporter labels Feb 17, 2020
@jkeenan
Copy link
Contributor

jkeenan commented Feb 17, 2020

@jkeenan Is there something left to discuss here then?

We reported the breakage to Data::Alias in its bugtracker. However, the author has not yet responded. So the ticket is not closable. We should review its status as we get closer to 5.32.0 release.

@xsawyerx
Copy link
Member

xsawyerx commented Apr 1, 2020

I reached out to the maintainer. I don't know if I'll get a response. Still not sure what decision to make here.

@xsawyerx
Copy link
Member

At the moment, I'm thinking of making this a non-blocker. The author is w5ill non-responsive, and there's only so far we can go without responsiveness.

A few modules are dependent on this, but not enough to break CPAN considerably.

@jkeenan
Copy link
Contributor

jkeenan commented Apr 15, 2020

At the moment, I'm thinking of making this a non-blocker. The author is w5ill non-responsive, and there's only so far we can go without responsiveness.

A few modules are dependent on this, but not enough to break CPAN considerably.

Has @iabyn (the original committer) commented on this yet?

@iabyn
Copy link
Contributor

iabyn commented Apr 17, 2020 via email

@jkeenan
Copy link
Contributor

jkeenan commented Apr 17, 2020 via email

@hvds
Copy link
Contributor

hvds commented Mar 17, 2022

This was eventually fixed, latest Data::Alias shows no problems. Closing ticket.

@hvds hvds closed this as completed Mar 17, 2022
@jkeenan
Copy link
Contributor

jkeenan commented Mar 17, 2022

This was eventually fixed, latest Data::Alias shows no problems. Closing ticket.

Confirmed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)
Projects
None yet
Development

No branches or pull requests

7 participants