Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/Devel-PPPort/t/uv.t: new failures in blead since 5.31.0 #17056

Closed
p5pRT opened this issue Jun 21, 2019 · 6 comments
Closed

dist/Devel-PPPort/t/uv.t: new failures in blead since 5.31.0 #17056

p5pRT opened this issue Jun 21, 2019 · 6 comments
Milestone

Comments

@p5pRT
Copy link

p5pRT commented Jun 21, 2019

Migrated from rt.perl.org#134217 (status was 'pending release')

Searchable as RT134217$

@p5pRT
Copy link
Author

p5pRT commented Jun 21, 2019

From @jkeenan

In https://rt-archive.perl.org/perl5/Ticket/Display.html?id=134215, Andreas reported
test failures in a number of files. Most of these turned out to be
porting or corelist-related tests and have been fixed as of commit
9965e49. However, there are still
failures in dist/Devel-PPPort/t/uv.t.

#####
  $ cd t;./perl harness ../dist/Devel-PPPort/t/uv.t; cd -
# Test 25 got​: "1" (t/uv.t at line 99)
# Expected​: "-1"
../dist/Devel-PPPort/t/uv.t .. 1/52 # Test 29 got​: "0" (t/uv.t at line 164)
# Expected​: "-1" (returned length utf8_to_uvchr_buf(""); warnings
enabled)
# Test 31 got​: "0" (t/uv.t at line 172)
# Expected​: "65533" (returned value utf8_to_uvchr_buf(""); warnings
disabled)
# Test 34 got​: "1" (t/uv.t at line 164 fail #2)
# Expected​: "-1" (returned length utf8_to_uvchr_buf("\xc4\xc5");
warnings enabled)
# Test 39 got​: "1" (t/uv.t at line 164 fail #3)
# Expected​: "-1" (returned length utf8_to_uvchr_buf("\xc4"); warnings
enabled)
# Test 44 got​: "2" (t/uv.t at line 164 fail #4)
# Expected​: "-1" (returned length utf8_to_uvchr_buf("\xc0\x81");
warnings enabled)
# Test 49 got​: "13" (t/uv.t at line 164 fail #5)
# Expected​: "-1" (returned length
utf8_to_uvchr_buf("\xff\x80\x90\x90\x90\xbf\xbf\xbf\xbf\xbf\xbf\xbf\xbf");
warnings enabled)
../dist/Devel-PPPort/t/uv.t .. Failed 7/52 subtests

Test Summary Report


../dist/Devel-PPPort/t/uv.t (Wstat​: 0 Tests​: 52 Failed​: 7)
  Failed tests​: 25, 29, 31, 34, 39, 44, 49
Files=1, Tests=52, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.03 cusr
0.01 csys = 0.05 CPU)
Result​: FAIL

#####

Bisection pointed to​:

#####
70bcccc is the first bad commit
commit 70bcccc
Author​: Karen Etheridge <ether@​cpan.org>
Date​: Thu Jun 20 13​:22​:45 2019 -0700 bump version to 5.31.2
#####

... but I'm not sure that's accurate as I can't understand why a commit
of version bumps would trigger these PPPort failures. But, in any
event, there have been extensive changes in Devel-PPPort since 5.31.0.

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Jun 21, 2019

From @jkeenan

Summary of my perl5 (revision 5 version 31 subversion 2) configuration​:
  Commit id​: 9965e49
  Platform​:
  osname=freebsd
  osvers=11.2-stable
  archname=amd64-freebsd-thread-multi
  uname='freebsd perlmonger.nycbug.org 11.2-stable freebsd 11.2-stable #0 r339445​: sat oct 20 00​:08​:11 utc 2018 root@​perlmonger.nycbug.org​:usrobjusrsrcsysgeneric amd64 '
  config_args='-des -Dusedevel -Duseithreads -Doptimize=-O2 -pipe -fstack-protector -fno-strict-aliasing'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=define
  usemultiplicity=define
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_FORTIFY_SOURCE=2'
  optimize='-O2 -pipe -fstack-protector -fno-strict-aliasing'
  cppflags='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='4.2.1 Compatible FreeBSD Clang 6.0.1 (tags/RELEASE_601/final 335540)'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags ='-pthread -Wl,-E -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/lib /usr/local/lib /usr/lib/clang/6.0.1/lib /usr/lib
  libs=-lpthread -lgdbm -ldl -lm -lcrypt -lutil
  perllibs=-lpthread -ldl -lm -lcrypt -lutil
  libc=
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags=' '
  cccdlflags='-DPIC -fPIC'
  lddlflags='-shared -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  MULTIPLICITY
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_IMPLICIT_CONTEXT
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_ITHREADS
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  USE_REENTRANT_API
  Built under freebsd
  Compiled at Jun 21 2019 17​:07​:27

@p5pRT
Copy link
Author

p5pRT commented Jun 21, 2019

From @atoomic

I'm currently working on a branch to import all changes from D​::P git repo to blead
this is probably going to fix that uv issue

On Fri, 21 Jun 2019 10​:29​:35 -0700, jkeenan@​pobox.com wrote​:

In https://rt-archive.perl.org/perl5/Ticket/Display.html?id=134215, Andreas reported
test failures in a number of files. Most of these turned out to be
porting or corelist-related tests and have been fixed as of commit
9965e49. However, there are still
failures in dist/Devel-PPPort/t/uv.t.

#####
$ cd t;./perl harness ../dist/Devel-PPPort/t/uv.t; cd -
# Test 25 got​: "1" (t/uv.t at line 99)
# Expected​: "-1"
../dist/Devel-PPPort/t/uv.t .. 1/52 # Test 29 got​: "0" (t/uv.t at line 164)
# Expected​: "-1" (returned length utf8_to_uvchr_buf(""); warnings
enabled)
# Test 31 got​: "0" (t/uv.t at line 172)
# Expected​: "65533" (returned value utf8_to_uvchr_buf(""); warnings
disabled)
# Test 34 got​: "1" (t/uv.t at line 164 fail #2)
# Expected​: "-1" (returned length utf8_to_uvchr_buf("\xc4\xc5");
warnings enabled)
# Test 39 got​: "1" (t/uv.t at line 164 fail #3)
# Expected​: "-1" (returned length utf8_to_uvchr_buf("\xc4"); warnings
enabled)
# Test 44 got​: "2" (t/uv.t at line 164 fail #4)
# Expected​: "-1" (returned length utf8_to_uvchr_buf("\xc0\x81");
warnings enabled)
# Test 49 got​: "13" (t/uv.t at line 164 fail #5)
# Expected​: "-1" (returned length
utf8_to_uvchr_buf("\xff\x80\x90\x90\x90\xbf\xbf\xbf\xbf\xbf\xbf\xbf\xbf");
warnings enabled)
../dist/Devel-PPPort/t/uv.t .. Failed 7/52 subtests

Test Summary Report
-------------------
../dist/Devel-PPPort/t/uv.t (Wstat​: 0 Tests​: 52 Failed​: 7)
Failed tests​: 25, 29, 31, 34, 39, 44, 49
Files=1, Tests=52, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.03 cusr
0.01 csys = 0.05 CPU)
Result​: FAIL

#####

Bisection pointed to​:

#####
70bcccc is the first bad commit
commit 70bcccc
Author​: Karen Etheridge <ether@​cpan.org>
Date​: Thu Jun 20 13​:22​:45 2019 -0700 bump version to 5.31.2
#####

... but I'm not sure that's accurate as I can't understand why a commit
of version bumps would trigger these PPPort failures. But, in any
event, there have been extensive changes in Devel-PPPort since 5.31.0.

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Jun 21, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 20, 2019

From @khwilliamson

This was fixed by 82651ab
and
3eaa759
--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Aug 20, 2019

@khwilliamson - Status changed from 'open' to 'pending release'

@p5pRT p5pRT closed this as completed Aug 20, 2019
@toddr toddr added this to the 5.32.0 milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants