Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Correct grammar in README.linux #17007

Closed
p5pRT opened this issue May 22, 2019 · 14 comments
Closed

[PATCH] Correct grammar in README.linux #17007

p5pRT opened this issue May 22, 2019 · 14 comments
Labels

Comments

@p5pRT
Copy link

p5pRT commented May 22, 2019

Migrated from rt.perl.org#134122 (status was 'open')

Searchable as RT134122$

@p5pRT
Copy link
Author

p5pRT commented May 22, 2019

From @shlomif

Perhaps the readme should be updated in a different way because I think sun
studio for linux fell out of favour.

--
Shlomi Fish http​://www.shlomifish.org/

Buddha has the Chuck Norris nature.

Please reply to list if it's a mailing list post - http​://shlom.in/reply .

@p5pRT
Copy link
Author

p5pRT commented May 22, 2019

From @shlomif

0001-Correct-some-broken-grammar-in-README.linux.patch
From 94e7426cafef796a901258c3b080603604f7c428 Mon Sep 17 00:00:00 2001
From: Shlomi Fish <shlomif@shlomifish.org>
Date: Wed, 22 May 2019 13:27:32 +0300
Subject: [PATCH] Correct some broken grammar in README.linux.

-----

I hereby disclaim any implicit or explicit ownership of my changes in this
changeset, and put them under a multiple licence consisting of your choice of
one of more of:

- The CC0 / Public Domain - https://creativecommons.org/choose/zero/ .

- The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License

- The default licence of your project

- The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version
2.1 or higher

- The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or
higher

- Any licence in the 2018-Aug-27 popular licenses list of
https://opensource.org/licenses

- The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later

- The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later

- The https://en.wikipedia.org/wiki/ISC_license

- The https://opensource.org/licenses/BSD-2-Clause

Crediting me will be nice, but not mandatory, and you can change the licence
of the project without needing my permission.
---
 README.linux | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/README.linux b/README.linux
index a191c52059..c527139be1 100644
--- a/README.linux
+++ b/README.linux
@@ -14,16 +14,16 @@ version 5 (hereafter just Perl) is compiled and/or runs.
 =head2 Experimental Support for Sun Studio Compilers for Linux OS
 
 Sun Microsystems has released a port of their Sun Studio compilers for
-Linux.  As of November 2005, only an alpha version has been released.  
+Linux.  As of November 2005, only an alpha version has been released.
 Until a release of these compilers is made, support for compiling Perl with
-these compiler experimental.
+these compilers is experimental.
 
-Also, some special instructions for building Perl with Sun Studio on Linux.
-Following the normal C<Configure>, you have to run make as follows:
+Also, there are some special instructions for building Perl with Sun Studio on
+Linux.  Following the normal C<Configure>, you have to run make as follows:
 
     LDLOADLIBS=-lc make
 
-C<LDLOADLIBS> is an environment variable used by the linker to link modules
+C<LDLOADLIBS> is an environment variable used by the linker to link
 C</ext> modules to glibc.  Currently, that environment variable is not getting
 populated by a combination of C<Config> entries and C<ExtUtil::MakeMaker>.
 While there may be a bug somewhere in Perl's configuration or
-- 
2.21.0

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2019

From @shlomif

On Tue, 28 May 2019 09​:53​:53 +0100
David Cantrell <david@​cantrell.org.uk> wrote​:

On Wed, May 22, 2019 at 03​:36​:46AM -0700, Shlomi Fish (via RT) wrote​:

Perhaps the readme should be updated in a different way because I think sun
studio for linux fell out of favour.
...
+Linux. As of November 2005, only an alpha version has been released.

The most recent release was in July 2017, and you can even buy a support
contract so it's very much not only an alpha version any more.

Thanks for the info. Perhaps an update is due.

--


Shlomi Fish http​://www.shlomifish.org/
Summer Glau Facts - http​://shlom.in/sglau-facts

Selina​: Quite a weird lot this supernatural underworld seems to be.
  — http​://www.shlomifish.org/humour/Selina-Mandrake/

Please reply to list if it's a mailing list post - http​://shlom.in/reply .

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2019

From david@cantrell.org.uk

On Wed, May 29, 2019 at 11​:25​:13AM +0300, Shlomi Fish wrote​:

David Cantrell <david@​cantrell.org.uk> wrote​:

Shlomi Fish (via RT) wrote​:

Perhaps the readme should be updated in a different way because I think sun
studio for linux fell out of favour.
...
+Linux. As of November 2005, only an alpha version has been released.
The most recent release was in July 2017, and you can even buy a support
contract so it's very much not only an alpha version any more.
Thanks for the info. Perhaps an update is due.

When I get a moment I'll see if I can build anything with it.

--
David Cantrell | A machine for turning tea into grumpiness

Only some sort of ghastly dehumanised moron would want to get
rid of Routemasters
  -- Ken Livingstone, four years before he got rid of 'em

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2019

From david@cantrell.org.uk

On Wed, May 22, 2019 at 03​:36​:46AM -0700, Shlomi Fish (via RT) wrote​:

Perhaps the readme should be updated in a different way because I think sun
studio for linux fell out of favour.
...
+Linux. As of November 2005, only an alpha version has been released.

The most recent release was in July 2017, and you can even buy a support
contract so it's very much not only an alpha version any more.

--
David Cantrell

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2019

From @shlomif

On Tue, May 28, 2019 at 12​:22 PM David Cantrell <david@​cantrell.org.uk>
wrote​:

On Wed, May 22, 2019 at 03​:36​:46AM -0700, Shlomi Fish (via RT) wrote​:

Perhaps the readme should be updated in a different way because I think
sun
studio for linux fell out of favour.
...
+Linux. As of November 2005, only an alpha version has been released.

The most recent release was in July 2017, and you can even buy a support
contract so it's very much not only an alpha version any more.

--
David Cantrell

I've attached a new patch - thanks!

--
Shlomi Fish http​://www.shlomifish.org/

Buddha has the Chuck Norris nature.

Please reply to list if it's a mailing list post - http​://shlom.in/reply .

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2019

From @shlomif

0001-Correct-some-grammar-in-README.linux-and-update-it.patch
From 4346bfc696c209ee0bd2f699cbe4b811f815d4a5 Mon Sep 17 00:00:00 2001
From: Shlomi Fish <shlomif@shlomifish.org>
Date: Wed, 22 May 2019 13:27:32 +0300
Subject: [PATCH] Correct some grammar in README.linux and update it

-----

I hereby disclaim any implicit or explicit ownership of my changes in this
changeset, and put them under a multiple licence consisting of your choice of
one of more of:

- The CC0 / Public Domain - https://creativecommons.org/choose/zero/ .

- The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License

- The default licence of your project

- The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version
2.1 or higher

- The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or
higher

- Any licence in the 2018-Aug-27 popular licenses list of
https://opensource.org/licenses

- The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later

- The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later

- The https://en.wikipedia.org/wiki/ISC_license

- The https://opensource.org/licenses/BSD-2-Clause

Crediting me will be nice, but not mandatory, and you can change the licence
of the project without needing my permission.
---
 README.linux | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/README.linux b/README.linux
index a191c52059..3721054cad 100644
--- a/README.linux
+++ b/README.linux
@@ -11,19 +11,30 @@ perllinux - Perl version 5 on Linux systems
 This document describes various features of Linux that will affect how Perl
 version 5 (hereafter just Perl) is compiled and/or runs.
 
+=head2 Deploying Perl on Linux
+
+Normally one can install C</usr/bin/perl> on Linux using your distribution's
+package manager (e.g: C<sudo apt-get install perl>, or
+C<sudo dnf install perl>). Note that sometimes one needs to install some
+extra system packages in order to be able to use CPAN frontends, and that
+messing with the system's perl is not always recommended. One can use
+L<perlbrew|https://perlbrew.pl/> to avoid such issues.
+
+Otherwise, perl should build fine on Linux using the mainstream compilers
+GCC and clang, while following the usual instructions.
+
 =head2 Experimental Support for Sun Studio Compilers for Linux OS
 
 Sun Microsystems has released a port of their Sun Studio compilers for
-Linux.  As of November 2005, only an alpha version has been released.  
-Until a release of these compilers is made, support for compiling Perl with
-these compiler experimental.
+Linux.  As of May 2019, the last stable release took place on 2017, and one can
+buy support contracts for them.
 
-Also, some special instructions for building Perl with Sun Studio on Linux.
-Following the normal C<Configure>, you have to run make as follows:
+There are some special instructions for building Perl with Sun Studio on
+Linux.  Following the normal C<Configure>, you have to run make as follows:
 
     LDLOADLIBS=-lc make
 
-C<LDLOADLIBS> is an environment variable used by the linker to link modules
+C<LDLOADLIBS> is an environment variable used by the linker to link
 C</ext> modules to glibc.  Currently, that environment variable is not getting
 populated by a combination of C<Config> entries and C<ExtUtil::MakeMaker>.
 While there may be a bug somewhere in Perl's configuration or
@@ -36,4 +47,3 @@ is needed to get this working better.
 Steve Peters <steve@fisharerojo.org>
 
 Please report any errors, updates, or suggestions to F<perlbug@perl.org>.
-
-- 
2.21.0

@shlomif
Copy link
Contributor

shlomif commented Mar 19, 2020

Can this be applied ? Is there anything you need?

atoomic pushed a commit to atoomic/perl5 that referenced this issue Mar 19, 2020
Fix GH Perl#17007

(cherry picked from commit b9677ee9a1dd1f5d79c5ab3e2e788eea65c20253)
Signed-off-by: Nicolas R <atoomic@cpan.org>
@atoomic
Copy link
Member

atoomic commented Mar 19, 2020

I opened a PR so this could give it more visibility and should be merged in the next days.
thanks for the patch

@shlomif
Copy link
Contributor

shlomif commented Mar 19, 2020 via email

@khwilliamson
Copy link
Contributor

khwilliamson commented Mar 19, 2020 via email

@atoomic
Copy link
Member

atoomic commented Mar 19, 2020

I will provide a fixup for it soon

@shlomif
Copy link
Contributor

shlomif commented Mar 19, 2020

Thanks @khwilliamson and @atoomic !

atoomic pushed a commit to atoomic/perl5 that referenced this issue Mar 19, 2020
Fix GH Perl#17007

(cherry picked from commit b9677ee9a1dd1f5d79c5ab3e2e788eea65c20253)
Signed-off-by: Nicolas R <atoomic@cpan.org>
khwilliamson pushed a commit that referenced this issue Mar 19, 2020
Fix GH #17007

(cherry picked from commit b9677ee9a1dd1f5d79c5ab3e2e788eea65c20253)
Signed-off-by: Nicolas R <atoomic@cpan.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants