New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] Devel::PPPort: Run make regen after regenerating Makefile #17003
Comments
From @paliThis would ensure that all auto-generated files are up-to-date after running configure phase. |
From @pali0001-Devel-PPPort-Run-make-regen-after-regenerating-Makef.patchFrom 8a037a891e54845dff21805dae30369e4dc1ac45 Mon Sep 17 00:00:00 2001
From: Pali <pali@cpan.org>
Date: Fri, 17 May 2019 12:41:03 +0200
Subject: [PATCH] Devel::PPPort: Run make regen after regenerating Makefile
This would ensure that all auto-generated files are up-to-date after running configure phase.
---
dist/Devel-PPPort/Makefile.PL | 2 ++
1 file changed, 2 insertions(+)
diff --git a/dist/Devel-PPPort/Makefile.PL b/dist/Devel-PPPort/Makefile.PL
index 62ba014cf6..4b86444613 100644
--- a/dist/Devel-PPPort/Makefile.PL
+++ b/dist/Devel-PPPort/Makefile.PL
@@ -17,6 +17,7 @@ require 5.003;
use strict;
use ExtUtils::MakeMaker;
+use Config;
use vars '%opt'; # needs to be global, and we can't use 'our'
@@ -37,6 +38,7 @@ my %mf = (
);
delete $mf{META_MERGE} unless eval { ExtUtils::MakeMaker->VERSION (6.46) };
WriteMakefile(%mf);
+system({$Config{make}} $Config{make}, 'regen');
sub configure
{
--
2.11.0
|
From @atoomicOn Fri, 17 May 2019 03:43:57 -0700, pali@cpan.org wrote:
great idea will apply it to our git repo waiting for the freeze to have this merge to blead |
The RT System itself - Status changed from 'new' to 'open' |
@atoomic is this applied? |
I think part of this was applied as Dual-Life/Devel-PPPort#83 |
As mentionned in Dual-Life/Devel-PPPort#77 We can close this case |
Migrated from rt.perl.org#134114 (status was 'open')
Searchable as RT134114$
The text was updated successfully, but these errors were encountered: