New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod::Perldoc 3.2801 no longer includes the 'term' formatter class by default #16992
Comments
From tlhackque@cpan.orgCreated by tlhackque@cpan.orgPod::Perldoc 3.28 is the latest on CPAN, but 3.2801 is released Prior to 3.2801 (corelist says this was released with 5.27.5), With 3.2801, users of perldoc now see a text rendition of pod, The code change that caused this is in Pod::Perldoc.pm: As far back as v3.24, the code was: sub init_formatter_class_list { # Remember, no switches have been read yet, when $self->opt_M_with('Pod::Perldoc::ToPod'); # the always-there fallthru return; In 3.2801, the penultimate statement is missing: sub init_formatter_class_list { # Remember, no switches have been read yet, when $self->opt_M_with('Pod::Perldoc::ToPod'); # the always-there fallthru The github repo (https://github.com/mrallen1/Pod-Perldoc) I can think of no good reason for this change, so I presume it was Please restore the original behavior. Here is my patch that does Inline Patch--- /opt/perlbrew/perls/perl-5.28.0/lib/5.28.1/Pod/Perldoc.pm~ 2019-04-15 15:50:04.000000000 -0400
+++ /opt/perlbrew/perls/perl-5.28.0/lib/5.28.1/Pod/Perldoc.pm 2019-05-09 12:31:08.000000000 -0400
@@ -10,11 +10,11 @@
use File::Spec::Functions qw(catfile catdir splitdir);
use vars qw($VERSION @Pagers $Bindir $Pod2man
$Temp_Files_Created $Temp_File_Lifetime
);
-$VERSION = '3.2801';
+$VERSION = '3.280101';
#..........................................................................
BEGIN { # Make a DEBUG constant very first thing...
unless(defined &DEBUG) {
@@ -484,10 +484,15 @@
# Remember, no switches have been read yet, when
# we've started this routine.
$self->opt_M_with('Pod::Perldoc::ToPod'); # the always-there fallthru
$self->opt_o_with('text');
+ $self->opt_o_with('term')
+ unless $self->is_mswin32 || $self->is_dos || $self->is_amigaos
+ || !($ENV{TERM} && (
+ ($ENV{TERM} || '') !~ /dumb|emacs|none|unknown/i
+ ));
return;
}
Thanks. Perl Info
|
From @khwilliamsonOn Thu, 09 May 2019 09:37:10 -0700, tlhackque@cpan.org wrote:
The change was intentional, and due to issues with the highlighting commit f2ee4cb customise Pod::Perldoc to fix output misbehaviour
|
The RT System itself - Status changed from 'new' to 'open' |
Migrated from rt.perl.org#134093 (status was 'open')
Searchable as RT134093$
The text was updated successfully, but these errors were encountered: