Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

858fc58a3 breaks ext/POSIX/t/mb.t on FreeBSD and NetBSD #16949

Closed
p5pRT opened this issue Apr 11, 2019 · 14 comments
Closed

858fc58a3 breaks ext/POSIX/t/mb.t on FreeBSD and NetBSD #16949

p5pRT opened this issue Apr 11, 2019 · 14 comments

Comments

@p5pRT
Copy link

p5pRT commented Apr 11, 2019

Migrated from rt.perl.org#134022 (status was 'resolved')

Searchable as RT134022$

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2019

From @jkeenan

A recent commit has broken ext/POSIX/t/mb.t on various versions of
FreeBSD. See, e.g.,

FreeBSD-11​: http​://perl5.test-smoke.org/report/84681
FreeBSD-12​: http​://perl5.test-smoke.org/report/84798
FreeBSD-13​: http​://perl5.test-smoke.org/report/84728

Bisection points to​:

#####
858fc58 is the first bad commit
commit 858fc58
Author​: Karl Williamson <khw@​cpan.org>
Date​: Wed Apr 3 13​:36​:40 2019 -0600

  ext/POSIX/t/mb.t​: Add test for MB_CUR_MAX

:040000 040000 7e2ebca7b3667c923f3e98a20c8a43f78c734d6e
1e5736c641351cf8443c31439dc13f38db9924fe M ext
#####

Some output from a run on FreeBSD-13​:

#####
  $ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at t/mb.t
line 41

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests

Test Summary Report


../ext/POSIX/t/mb.t (Wstat​: 0 Tests​: 4 Failed​: 1)
  Failed test​: 2
Files=1, Tests=4, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.09 cusr
0.07 csys = 0.16 CPU)
Result​: FAIL
#####

The test appears to fail on both threaded and unthreaded builds.

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2019

From @jkeenan

Summary of my perl5 (revision 5 version 29 subversion 10) configuration​:
  Commit id​: a719c52
  Platform​:
  osname=freebsd
  osvers=11.2-stable
  archname=amd64-freebsd-thread-multi
  uname='freebsd perlmonger.nycbug.org 11.2-stable freebsd 11.2-stable #0 r339445​: sat oct 20 00​:08​:11 utc 2018 root@​perlmonger.nycbug.org​:usrobjusrsrcsysgeneric amd64 '
  config_args='-des -Dusedevel -Duseithreads -Doptimize=-O2 -pipe -fstack-protector -fno-strict-aliasing'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=define
  usemultiplicity=define
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_FORTIFY_SOURCE=2'
  optimize='-O2 -pipe -fstack-protector -fno-strict-aliasing'
  cppflags='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='4.2.1 Compatible FreeBSD Clang 6.0.1 (tags/RELEASE_601/final 335540)'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags ='-pthread -Wl,-E -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/lib /usr/local/lib /usr/lib/clang/6.0.1/lib /usr/lib
  libs=-lpthread -lgdbm -ldl -lm -lcrypt -lutil
  perllibs=-lpthread -ldl -lm -lcrypt -lutil
  libc=
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags=' '
  cccdlflags='-DPIC -fPIC'
  lddlflags='-shared -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  MULTIPLICITY
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_IMPLICIT_CONTEXT
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_ITHREADS
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  USE_REENTRANT_API
  Built under freebsd
  Compiled at Apr 11 2019 18​:21​:21
  %ENV​:
  PERL2DIR="/home/jkeenan/gitwork/perl2"
  PERL_WORKDIR="/home/jkeenan/gitwork/perl"
  @​INC​:
  lib
  /usr/local/lib/perl5/site_perl/5.29.10/amd64-freebsd-thread-multi
  /usr/local/lib/perl5/site_perl/5.29.10
  /usr/local/lib/perl5/5.29.10/amd64-freebsd-thread-multi
  /usr/local/lib/perl5/5.29.10

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2019

From @jkeenan

On Thu, 11 Apr 2019 18​:25​:44 GMT, jkeenan@​pobox.com wrote​:

A recent commit has broken ext/POSIX/t/mb.t on various versions of
FreeBSD. See, e.g.,

FreeBSD-11​: http​://perl5.test-smoke.org/report/84681
FreeBSD-12​: http​://perl5.test-smoke.org/report/84798
FreeBSD-13​: http​://perl5.test-smoke.org/report/84728

Bisection points to​:

#####
858fc58 is the first bad commit
commit 858fc58
Author​: Karl Williamson <khw@​cpan.org>
Date​: Wed Apr 3 13​:36​:40 2019 -0600

 ext/POSIX/t/mb\.t&#8203;: Add test for MB\_CUR\_MAX

:040000 040000 7e2ebca7b3667c923f3e98a20c8a43f78c734d6e
1e5736c641351cf8443c31439dc13f38db9924fe M ext
#####

Some output from a run on FreeBSD-13​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at t/mb.t
line 41

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests

Test Summary Report
-------------------
../ext/POSIX/t/mb.t (Wstat​: 0 Tests​: 4 Failed​: 1)
Failed test​: 2
Files=1, Tests=4, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.09 cusr
0.07 csys = 0.16 CPU)
Result​: FAIL
#####

The test appears to fail on both threaded and unthreaded builds.

Thank you very much.
Jim Keenan

This test is also the subject of RT 133928.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2019

From [Unknown Contact. See original ticket]

On Thu, 11 Apr 2019 18​:25​:44 GMT, jkeenan@​pobox.com wrote​:

A recent commit has broken ext/POSIX/t/mb.t on various versions of
FreeBSD. See, e.g.,

FreeBSD-11​: http​://perl5.test-smoke.org/report/84681
FreeBSD-12​: http​://perl5.test-smoke.org/report/84798
FreeBSD-13​: http​://perl5.test-smoke.org/report/84728

Bisection points to​:

#####
858fc58 is the first bad commit
commit 858fc58
Author​: Karl Williamson <khw@​cpan.org>
Date​: Wed Apr 3 13​:36​:40 2019 -0600

 ext/POSIX/t/mb\.t&#8203;: Add test for MB\_CUR\_MAX

:040000 040000 7e2ebca7b3667c923f3e98a20c8a43f78c734d6e
1e5736c641351cf8443c31439dc13f38db9924fe M ext
#####

Some output from a run on FreeBSD-13​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at t/mb.t
line 41

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests

Test Summary Report
-------------------
../ext/POSIX/t/mb.t (Wstat​: 0 Tests​: 4 Failed​: 1)
Failed test​: 2
Files=1, Tests=4, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.09 cusr
0.07 csys = 0.16 CPU)
Result​: FAIL
#####

The test appears to fail on both threaded and unthreaded builds.

Thank you very much.
Jim Keenan

This test is also the subject of RT 133928.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2019

From @jkeenan

On Thu, 11 Apr 2019 18​:25​:44 GMT, jkeenan@​pobox.com wrote​:

A recent commit has broken ext/POSIX/t/mb.t on various versions of
FreeBSD. See, e.g.,

FreeBSD-11​: http​://perl5.test-smoke.org/report/84681
FreeBSD-12​: http​://perl5.test-smoke.org/report/84798
FreeBSD-13​: http​://perl5.test-smoke.org/report/84728

Bisection points to​:

#####
858fc58 is the first bad commit
commit 858fc58
Author​: Karl Williamson <khw@​cpan.org>
Date​: Wed Apr 3 13​:36​:40 2019 -0600

 ext/POSIX/t/mb\.t&#8203;: Add test for MB\_CUR\_MAX

:040000 040000 7e2ebca7b3667c923f3e98a20c8a43f78c734d6e
1e5736c641351cf8443c31439dc13f38db9924fe M ext
#####

Some output from a run on FreeBSD-13​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at t/mb.t
line 41

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests

Test Summary Report
-------------------
../ext/POSIX/t/mb.t (Wstat​: 0 Tests​: 4 Failed​: 1)
Failed test​: 2
Files=1, Tests=4, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.09 cusr
0.07 csys = 0.16 CPU)
Result​: FAIL
#####

The test appears to fail on both threaded and unthreaded builds.

Thank you very much.
Jim Keenan

Also being observed on NetBSD​:

http​://perl5.test-smoke.org/report/84746

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2019

From [Unknown Contact. See original ticket]

On Thu, 11 Apr 2019 18​:25​:44 GMT, jkeenan@​pobox.com wrote​:

A recent commit has broken ext/POSIX/t/mb.t on various versions of
FreeBSD. See, e.g.,

FreeBSD-11​: http​://perl5.test-smoke.org/report/84681
FreeBSD-12​: http​://perl5.test-smoke.org/report/84798
FreeBSD-13​: http​://perl5.test-smoke.org/report/84728

Bisection points to​:

#####
858fc58 is the first bad commit
commit 858fc58
Author​: Karl Williamson <khw@​cpan.org>
Date​: Wed Apr 3 13​:36​:40 2019 -0600

 ext/POSIX/t/mb\.t&#8203;: Add test for MB\_CUR\_MAX

:040000 040000 7e2ebca7b3667c923f3e98a20c8a43f78c734d6e
1e5736c641351cf8443c31439dc13f38db9924fe M ext
#####

Some output from a run on FreeBSD-13​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at t/mb.t
line 41

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests

Test Summary Report
-------------------
../ext/POSIX/t/mb.t (Wstat​: 0 Tests​: 4 Failed​: 1)
Failed test​: 2
Files=1, Tests=4, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.09 cusr
0.07 csys = 0.16 CPU)
Result​: FAIL
#####

The test appears to fail on both threaded and unthreaded builds.

Thank you very much.
Jim Keenan

Also being observed on NetBSD​:

http​://perl5.test-smoke.org/report/84746

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2019

From @jkeenan

On Thu, 11 Apr 2019 18​:25​:44 GMT, jkeenan@​pobox.com wrote​:

A recent commit has broken ext/POSIX/t/mb.t on various versions of
FreeBSD. See, e.g.,

FreeBSD-11​: http​://perl5.test-smoke.org/report/84681
FreeBSD-12​: http​://perl5.test-smoke.org/report/84798
FreeBSD-13​: http​://perl5.test-smoke.org/report/84728

Bisection points to​:

#####
858fc58 is the first bad commit
commit 858fc58
Author​: Karl Williamson <khw@​cpan.org>
Date​: Wed Apr 3 13​:36​:40 2019 -0600

 ext/POSIX/t/mb\.t&#8203;: Add test for MB\_CUR\_MAX

:040000 040000 7e2ebca7b3667c923f3e98a20c8a43f78c734d6e
1e5736c641351cf8443c31439dc13f38db9924fe M ext
#####

Some output from a run on FreeBSD-13​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at t/mb.t
line 41

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests

Test Summary Report
-------------------
../ext/POSIX/t/mb.t (Wstat​: 0 Tests​: 4 Failed​: 1)
Failed test​: 2
Files=1, Tests=4, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.09 cusr
0.07 csys = 0.16 CPU)
Result​: FAIL
#####

The test appears to fail on both threaded and unthreaded builds.

Thank you very much.
Jim Keenan

Some debugging from the above environment​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at t/mb.t line 41
AAA​: &POSIX​::MB_CUR_MAX​: 1

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests
#####

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 11, 2019

From @khwilliamson

On 4/11/19 12​:53 PM, James E Keenan via RT wrote​:

On Thu, 11 Apr 2019 18​:25​:44 GMT, jkeenan@​pobox.com wrote​:

A recent commit has broken ext/POSIX/t/mb.t on various versions of
FreeBSD. See, e.g.,

FreeBSD-11​: http​://perl5.test-smoke.org/report/84681
FreeBSD-12​: http​://perl5.test-smoke.org/report/84798
FreeBSD-13​: http​://perl5.test-smoke.org/report/84728

Bisection points to​:

#####
858fc58 is the first bad commit
commit 858fc58
Author​: Karl Williamson <khw@​cpan.org>
Date​: Wed Apr 3 13​:36​:40 2019 -0600

  ext/POSIX/t/mb\.t&#8203;: Add test for MB\_CUR\_MAX

:040000 040000 7e2ebca7b3667c923f3e98a20c8a43f78c734d6e
1e5736c641351cf8443c31439dc13f38db9924fe M ext
#####

Some output from a run on FreeBSD-13​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at t/mb.t
line 41

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests

Test Summary Report
-------------------
../ext/POSIX/t/mb.t (Wstat​: 0 Tests​: 4 Failed​: 1)
Failed test​: 2
Files=1, Tests=4, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.09 cusr
0.07 csys = 0.16 CPU)
Result​: FAIL
#####

The test appears to fail on both threaded and unthreaded builds.

Thank you very much.
Jim Keenan

Some debugging from the above environment​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at t/mb.t line 41
AAA​: &POSIX​::MB_CUR_MAX​: 1

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests
#####

We can simply remove the test. I did try it out on a netbsd and freebsd
box before pushing that to blead, but they were earlier OS versions

It appears to me that it's a bug in those OS versions, along with HP-UX.

@p5pRT
Copy link
Author

p5pRT commented Apr 12, 2019

From @jkeenan

On Thu, 11 Apr 2019 19​:49​:58 GMT, public@​khwilliamson.com wrote​:

On 4/11/19 12​:53 PM, James E Keenan via RT wrote​:

On Thu, 11 Apr 2019 18​:25​:44 GMT, jkeenan@​pobox.com wrote​:

A recent commit has broken ext/POSIX/t/mb.t on various versions of
FreeBSD. See, e.g.,

FreeBSD-11​: http​://perl5.test-smoke.org/report/84681
FreeBSD-12​: http​://perl5.test-smoke.org/report/84798
FreeBSD-13​: http​://perl5.test-smoke.org/report/84728

Bisection points to​:

#####
858fc58 is the first bad commit
commit 858fc58
Author​: Karl Williamson <khw@​cpan.org>
Date​: Wed Apr 3 13​:36​:40 2019 -0600

ext/POSIX/t/mb.t​: Add test for MB_CUR_MAX

:040000 040000 7e2ebca7b3667c923f3e98a20c8a43f78c734d6e
1e5736c641351cf8443c31439dc13f38db9924fe M ext
#####

Some output from a run on FreeBSD-13​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at
t/mb.t
line 41

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests

Test Summary Report
-------------------
../ext/POSIX/t/mb.t (Wstat​: 0 Tests​: 4 Failed​: 1)
Failed test​: 2
Files=1, Tests=4, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.09
cusr
0.07 csys = 0.16 CPU)
Result​: FAIL
#####

The test appears to fail on both threaded and unthreaded builds.

Thank you very much.
Jim Keenan

Some debugging from the above environment​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at
t/mb.t line 41
AAA​: &POSIX​::MB_CUR_MAX​: 1

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests
#####

We can simply remove the test. I did try it out on a netbsd and
freebsd
box before pushing that to blead, but they were earlier OS versions

It appears to me that it's a bug in those OS versions, along with HP-
UX.

The test was also failing on Cygwin and Darwin, and even on some Linux boxes. (See the reports at http​://perl.develop-help.com/ reported at commit a719c52.)

So I reverted the commit that applied the unit test in commit 8cc5417. I tested the result on FreeBSD, both threaded and unthreaded builds, before pushing.

Once most of our smoke-testers are again reporting green we can evaluate how best to proceed.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 13, 2019

From @khwilliamson

On 4/12/19 8​:12 AM, James E Keenan via RT wrote​:

On Thu, 11 Apr 2019 19​:49​:58 GMT, public@​khwilliamson.com wrote​:

On 4/11/19 12​:53 PM, James E Keenan via RT wrote​:

On Thu, 11 Apr 2019 18​:25​:44 GMT, jkeenan@​pobox.com wrote​:

A recent commit has broken ext/POSIX/t/mb.t on various versions of
FreeBSD. See, e.g.,

FreeBSD-11​: http​://perl5.test-smoke.org/report/84681
FreeBSD-12​: http​://perl5.test-smoke.org/report/84798
FreeBSD-13​: http​://perl5.test-smoke.org/report/84728

Bisection points to​:

#####
858fc58 is the first bad commit
commit 858fc58
Author​: Karl Williamson <khw@​cpan.org>
Date​: Wed Apr 3 13​:36​:40 2019 -0600

ext/POSIX/t/mb.t​: Add test for MB_CUR_MAX

:040000 040000 7e2ebca7b3667c923f3e98a20c8a43f78c734d6e
1e5736c641351cf8443c31439dc13f38db9924fe M ext
#####

Some output from a run on FreeBSD-13​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at
t/mb.t
line 41

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests

Test Summary Report
-------------------
../ext/POSIX/t/mb.t (Wstat​: 0 Tests​: 4 Failed​: 1)
Failed test​: 2
Files=1, Tests=4, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.09
cusr
0.07 csys = 0.16 CPU)
Result​: FAIL
#####

The test appears to fail on both threaded and unthreaded builds.

Thank you very much.
Jim Keenan

Some debugging from the above environment​:

#####
$ cd t;./perl harness -v ../ext/POSIX/t/mb.t; cd -
# Failed test 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale at
t/mb.t line 41
AAA​: &POSIX​::MB_CUR_MAX​: 1

ok 1 - mblen() basically works
not ok 2 - MB_CUR_MAX is at least 4 in a UTF-8 locale
ok 3 - mblen() recognizes invalid multibyte characters
ok 4 - mblen() works on UTF-8 characters
Failed 1/4 subtests
#####

We can simply remove the test. I did try it out on a netbsd and
freebsd
box before pushing that to blead, but they were earlier OS versions

It appears to me that it's a bug in those OS versions, along with HP-
UX.

The test was also failing on Cygwin and Darwin, and even on some Linux boxes. (See the reports at http​://perl.develop-help.com/ reported at commit a719c52.)

So I reverted the commit that applied the unit test in commit 8cc5417. I tested the result on FreeBSD, both threaded and unthreaded builds, before pushing.

Once most of our smoke-testers are again reporting green we can evaluate how best to proceed.

Thank you very much.

On further inspection, I realized I committed the non-final version of
the test, and have reinstated it with one that should work​:

commit 02b8575
  Author​: Karl Williamson <khw@​cpan.org>
  Date​: Fri Apr 12 15​:28​:54 2019 -0600

* Reinstate and fix failing POSIX mb.t test

  Somehow I had pushed to blead a draft version of the test, rather than
  the final one that actually should work. The draft is what got
reverted
  by 8cc5417. Reinstate the test,
  corrected.

@p5pRT
Copy link
Author

p5pRT commented Apr 24, 2019

From @iabyn

On Sat, Apr 13, 2019 at 12​:45​:50PM -0600, Karl Williamson wrote​:

On further inspection, I realized I committed the non-final version of the
test, and have reinstated it with one that should work​:

commit 02b8575
Author​: Karl Williamson <khw@​cpan.org>
Date​: Fri Apr 12 15​:28​:54 2019 -0600

* Reinstate and fix failing POSIX mb.t test

 Somehow I had pushed to blead a draft version of the test\, rather than
 the final one that actually should work\.  The draft is what got

reverted
by 8cc5417. Reinstate the test,
corrected.

Can this ticket be resolved then? I can't see any recent mb.t smoke
failures.

--
Hofstadter's Law​: It always takes longer than you expect, even when you
take into account Hofstadter's Law.

@p5pRT
Copy link
Author

p5pRT commented Apr 24, 2019

From @khwilliamson

Closed
--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Apr 24, 2019

@khwilliamson - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants