Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword diagnostic in 5.31 #16934

Closed
p5pRT opened this issue Apr 5, 2019 · 7 comments
Closed

Reword diagnostic in 5.31 #16934

p5pRT opened this issue Apr 5, 2019 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented Apr 5, 2019

Migrated from rt.perl.org#133996 (status was 'pending release')

Searchable as RT133996$

@p5pRT
Copy link
Author

p5pRT commented Apr 5, 2019

From @khwilliamson

This is a bug report for perl from khw@​khw-xps-8930.(none),
generated with the help of perlbug 1.41 running under perl 5.29.10.


As a result of changes to [perl #133988], a diagnostic should be
reworded to correspond, but it's too late to change in 5.31, so this is
deferred until 5.31.

The diagnostic should be something like

=item \N{} here is restricted to one character in regex; marked by <--
HERE in m/%s/



Flags​:
  category=core
  severity=low


Site configuration information for perl 5.29.10​:

Configured by khw at Fri Apr 5 10​:18​:23 MDT 2019.

Summary of my perl5 (revision 5 version 29 subversion 10) configuration​:
  Commit id​: 6894e6a
  Platform​:
  osname=linux
  osvers=4.15.0-47-generic
  archname=x86_64-linux-thread-multi
  uname='linux khw-xps-8930 4.15.0-47-generic #50-ubuntu smp wed mar
13 10​:44​:52 utc 2019 x86_64 x86_64 x86_64 gnulinux '
  config_args='-des -Uversiononly -Dprefix=/home/khw/blead -Dusedevel
-A'optimize=-ggdb3' -A'optimize=-O0' -Accflags='-Wno-deprecated'
-Dman1dir=none -Dman3dir=none -Dcc=g++ -DDEBUGGING -Dusecbacktrace
-Dusethreads'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=define
  usemultiplicity=define
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='g++'
  ccflags ='-D_REENTRANT -D_GNU_SOURCE -Wno-deprecated -fwrapv
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong
-I/usr/local/include -DUSE_C_BACKTRACE -g -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
  optimize='-O2 -ggdb3 -O0'
  cppflags='-D_REENTRANT -D_GNU_SOURCE -Wno-deprecated -fwrapv
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong
-I/usr/local/include'
  ccversion=''
  gccversion='7.3.0'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='g++'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/include/c++/7 /usr/include/x86_64-linux-gnu/c++/7
/usr/include/c++/7/backward /usr/local/lib
/usr/lib/gcc/x86_64-linux-gnu/7/include-fixed
/usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib
/usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.27.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.27'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -ggdb3 -O0 -L/usr/local/lib
-fstack-protector-strong'


@​INC for perl 5.29.10​:
  /home/khw/perl/blead/lib
  /home/khw/perl/blead/t
  /home/khw/blead/lib/perl5/site_perl/5.29.10/x86_64-linux-thread-multi
  /home/khw/blead/lib/perl5/site_perl/5.29.10
  /home/khw/blead/lib/perl5/5.29.10/x86_64-linux-thread-multi
  /home/khw/blead/lib/perl5/5.29.10
  /home/khw/blead/lib/perl5/site_perl/5.29.9
  /home/khw/blead/lib/perl5/site_perl/5.29.8
  /home/khw/blead/lib/perl5/site_perl/5.29.7
  /home/khw/blead/lib/perl5/site_perl/5.29.6
  /home/khw/blead/lib/perl5/site_perl/5.29.5
  /home/khw/blead/lib/perl5/site_perl/5.29.4
  /home/khw/blead/lib/perl5/site_perl/5.29.3
  /home/khw/blead/lib/perl5/site_perl/5.29.2
  /home/khw/blead/lib/perl5/site_perl/5.29.1
  /home/khw/blead/lib/perl5/site_perl/5.29.0
  /home/khw/blead/lib/perl5/site_perl/5.28.0
  /home/khw/blead/lib/perl5/site_perl/5.27.11
  /home/khw/blead/lib/perl5/site_perl/5.27.10
  /home/khw/blead/lib/perl5/site_perl/5.27.9
  /home/khw/blead/lib/perl5/site_perl/5.27.8
  /home/khw/blead/lib/perl5/site_perl/5.27.7
  /home/khw/blead/lib/perl5/site_perl/5.27.6
  /home/khw/blead/lib/perl5/site_perl/5.27.5
  /home/khw/blead/lib/perl5/site_perl/5.27.4
  /home/khw/blead/lib/perl5/site_perl/5.27.3
  /home/khw/blead/lib/perl5/site_perl/5.27.2
  /home/khw/blead/lib/perl5/site_perl/5.27.1
  /home/khw/blead/lib/perl5/site_perl/5.27.0
  /home/khw/blead/lib/perl5/site_perl/5.26.0
  /home/khw/blead/lib/perl5/site_perl/5.25.12
  /home/khw/blead/lib/perl5/site_perl/5.25.11
  /home/khw/blead/lib/perl5/site_perl/5.25.10
  /home/khw/blead/lib/perl5/site_perl/5.25.9
  /home/khw/blead/lib/perl5/site_perl/5.25.8
  /home/khw/blead/lib/perl5/site_perl/5.25.7
  /home/khw/blead/lib/perl5/site_perl/5.25.6
  /home/khw/blead/lib/perl5/site_perl/5.25.5
  /home/khw/blead/lib/perl5/site_perl/5.25.4
  /home/khw/blead/lib/perl5/site_perl/5.25.3
  /home/khw/blead/lib/perl5/site_perl/5.25.2
  /home/khw/blead/lib/perl5/site_perl/5.25.1
  /home/khw/blead/lib/perl5/site_perl/5.24.0
  /home/khw/blead/lib/perl5/site_perl/5.23.10
  /home/khw/blead/lib/perl5/site_perl/5.23.9
  /home/khw/blead/lib/perl5/site_perl/5.23.8
  /home/khw/blead/lib/perl5/site_perl/5.23.7
  /home/khw/blead/lib/perl5/site_perl/5.23.6
  /home/khw/blead/lib/perl5/site_perl/5.23.5
  /home/khw/blead/lib/perl5/site_perl/5.23.4
  /home/khw/blead/lib/perl5/site_perl/5.23.3
  /home/khw/blead/lib/perl5/site_perl/5.23.2
  /home/khw/blead/lib/perl5/site_perl/5.23.1
  /home/khw/blead/lib/perl5/site_perl/5.23.0
  /home/khw/blead/lib/perl5/site_perl/5.22.0
  /home/khw/blead/lib/perl5/site_perl/5.21.12
  /home/khw/blead/lib/perl5/site_perl/5.21.11
  /home/khw/blead/lib/perl5/site_perl/5.21.10
  /home/khw/blead/lib/perl5/site_perl/5.21.9
  /home/khw/blead/lib/perl5/site_perl/5.21.8
  /home/khw/blead/lib/perl5/site_perl/5.21.7
  /home/khw/blead/lib/perl5/site_perl/5.21.6
  /home/khw/blead/lib/perl5/site_perl/5.21.5
  /home/khw/blead/lib/perl5/site_perl/5.21.4
  /home/khw/blead/lib/perl5/site_perl/5.21.3
  /home/khw/blead/lib/perl5/site_perl/5.21.2
  /home/khw/blead/lib/perl5/site_perl/5.21.1
  /home/khw/blead/lib/perl5/site_perl/5.20.0
  /home/khw/blead/lib/perl5/site_perl/5.19.12
  /home/khw/blead/lib/perl5/site_perl/5.19.11
  /home/khw/blead/lib/perl5/site_perl/5.19.10
  /home/khw/blead/lib/perl5/site_perl


Environment for perl 5.29.10​:
  HOME=/home/khw
  LANG=en_US.UTF-8
  LANGUAGE=en
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)

PATH=/usr/lib/ccache​:/home/khw/bin​:/home/khw/perl5/perlbrew/bin​:/home/khw/print/bin​:/bin​:/usr/local/sbin​:/usr/local/bin​:/usr/sbin​:/usr/bin​:/sbin​:/usr/games​:/usr/local/games​:/snap/bin​:/home/khw/iands/www​:/home/khw/cxoffice/bin
  PERL5OPT=-w
  PERL_BADLANG (unset)
  PERL_DIFF_TOOL=wgdiff
  PERL_POD_PEDANTIC=1
  SHELL=/usr/bin/ksh

@p5pRT
Copy link
Author

p5pRT commented Apr 7, 2019

From @xsawyerx

On 4/6/19 1​:50 AM, karl williamson (via RT) wrote​:

# New Ticket Created by karl williamson
# Please include the string​: [perl #133996]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133996 >

This is a bug report for perl from khw@​khw-xps-8930.(none),
generated with the help of perlbug 1.41 running under perl 5.29.10.

-----------------------------------------------------------------
As a result of changes to [perl #133988], a diagnostic should be
reworded to correspond, but it's too late to change in 5.31, so this is
deferred until 5.31.

Do you mean "it's too late to change in 5.30" and "deferred until 5.30.1"?

The diagnostic should be something like

=item \N{} here is restricted to one character in regex; marked by <--
HERE in m/%s/

Patch/branch? (We could merge it later.)

@p5pRT
Copy link
Author

p5pRT commented Apr 7, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 7, 2019

From @khwilliamson

On 4/6/2019 11​:33 PM, Sawyer X wrote​:

On 4/6/19 1​:50 AM, karl williamson (via RT) wrote​:

# New Ticket Created by karl williamson
# Please include the string​: [perl #133996]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133996 >

This is a bug report for perl from khw@​khw-xps-8930.(none),
generated with the help of perlbug 1.41 running under perl 5.29.10.

-----------------------------------------------------------------
As a result of changes to [perl #133988], a diagnostic should be
reworded to correspond, but it's too late to change in 5.31, so this is
deferred until 5.31.

Do you mean "it's too late to change in 5.30" and "deferred until 5.30.1"?

We're not allowed to change things this late in the development process
that would harm a correctly functioning program. I view that as
including rewording diagnostics, as someone might be relying on the
precise wording.

The diagnostic should be something like

=item \N{} here is restricted to one character in regex; marked by <--
HERE in m/%s/

Patch/branch? (We could merge it later.)

@p5pRT
Copy link
Author

p5pRT commented Apr 8, 2019

From @xsawyerx

On 4/7/19 6​:21 PM, Karl Williamson wrote​:

On 4/6/2019 11​:33 PM, Sawyer X wrote​:

On 4/6/19 1​:50 AM, karl williamson (via RT) wrote​:

# New Ticket Created by  karl williamson
# Please include the string​:  [perl #133996]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133996 >

This is a bug report for perl from khw@​khw-xps-8930.(none),
generated with the help of perlbug 1.41 running under perl 5.29.10.

-----------------------------------------------------------------
As a result of changes to [perl #133988], a diagnostic should be
reworded to correspond, but it's too late to change in 5.31, so this is
deferred until 5.31.

Do you mean "it's too late to change in 5.30" and "deferred until
5.30.1"?

We're not allowed to change things this late in the development
process that would harm a correctly functioning program.  I view that
as including rewording diagnostics, as someone might be relying on the
precise wording.

It's not too late to change in 5.31, only in 5.30.

@p5pRT
Copy link
Author

p5pRT commented Jun 27, 2019

From @khwilliamson

Fixed by 1a7108f
--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Jun 27, 2019

@khwilliamson - Status changed from 'open' to 'pending release'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant