Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion failure in S_regmatch (regexec.c:6292) #16933

Closed
p5pRT opened this issue Apr 5, 2019 · 4 comments
Closed

Assertion failure in S_regmatch (regexec.c:6292) #16933

p5pRT opened this issue Apr 5, 2019 · 4 comments
Labels
type-core

Comments

@p5pRT
Copy link

p5pRT commented Apr 5, 2019

Migrated from rt.perl.org#133995 (status was 'resolved')

Searchable as RT133995$
@p5pRT
Copy link
Author

p5pRT commented Apr 5, 2019

From @dur-randir

Created by @dur-randir

While fuzzing perl v5.29.9-63-g2496d8f3f7 built with afl and run
under libdislocator, I found the following program

use utf8; "έδωσαν ελληνικήვე" =~ m/[^0](?=0)0?/

to cause an assertion failure

perl​: regexec.c​:6292​: S_regmatch​: Assertion `(((( (sizeof(*l) == 1) ||
!(((U64)((*l) | 0)) & ~0xFF))) ? (void) (0) : __assert_fail ("(
(sizeof(*l) == 1) || !(((U64)((*l) | 0)) & ~0xFF))", "regexec.c",
6292, __extension__ __PRETTY_FUNCTION__)), (((U8)((*l) | 0)) & 0xfe)
== 0xc2)' failed.

GDB stack trace is following

#0 __GI_raise (sig=sig@​entry=6) at ../sysdeps/unix/sysv/linux/raise.c​:50
#1 0x00007ffff7c25535 in __GI_abort () at abort.c​:79
#2 0x00007ffff7c2540f in __assert_fail_base (fmt=0x7ffff7d87ee0
"%s%s%s​:%u​: %s%sAssertion `%s' failed.\n%n",
  assertion=0x555555ae8da0 "(((( (sizeof(*l) == 1) || !(((U64)((*l)
| 0)) & ~0xFF))) ? (void) (0) : __assert_fail (\"( (sizeof(*l) == 1)
|| !(((U64)((*l) | 0)) & ~0xFF))\", \"regexec.c\", 6292, __extension__
__PRETTY_FUNCTION__)), ("..., file=0x555555ae0348 "regexec.c",
line=6292, function=<optimized out>)
  at assert.c​:92
#3 0x00007ffff7c330f2 in __GI___assert_fail (
  assertion=0x555555ae8da0 "(((( (sizeof(*l) == 1) || !(((U64)((*l)
| 0)) & ~0xFF))) ? (void) (0) : __assert_fail (\"( (sizeof(*l) == 1)
|| !(((U64)((*l) | 0)) & ~0xFF))\", \"regexec.c\", 6292, __extension__
__PRETTY_FUNCTION__)), ("..., file=0x555555ae0348 "regexec.c",
line=6292,
  function=0x555555af30b0 <__PRETTY_FUNCTION__.19772> "S_regmatch")
at assert.c​:101
#4 0x00005555558b663e in S_regmatch (reginfo=0x7fffffffdc80,
startpos=0x555555b78bae "\203\225ე", prog=0x555555b80f3c) at
regexec.c​:6292
#5 0x00005555558ae0bf in S_regtry (reginfo=0x7fffffffdc80,
startposp=0x7fffffffd788) at regexec.c​:3956
#6 0x00005555558a0ad3 in S_find_byclass (prog=0x555555b796b0,
c=0x555555b80f3c, s=0x555555b78bae "\203\225ე", strend=0x555555b78bb3
"",
  reginfo=0x7fffffffdc80) at regexec.c​:2166
#7 0x00005555558ad12a in Perl_regexec_flags (rx=0x555555b72e00,
stringarg=0x555555b78b90 "έδωσαν ελληνικήვე", strend=0x555555b78bb3
"",
  strbeg=0x555555b78b90 "έδωσαν ελληνικήვე", minend=0,
sv=0x555555b72dd0, data=0x0, flags=97) at regexec.c​:3701
#8 0x0000555555769960 in Perl_pp_match () at pp_hot.c​:3018
#9 0x000055555570b640 in Perl_runops_debug () at dump.c​:2537
#10 0x00005555555ed560 in S_run_body (oldscope=1) at perl.c​:2716
#11 0x00005555555ecade in perl_run (my_perl=0x555555b4c260) at perl.c​:2639
#12 0x00005555555a114e in main (argc=4, argv=0x7fffffffe168,
env=0x7fffffffe190) at perlmain.c​:127

This is a regression in blead, bisect points to

commit 3db0bcc
Author​: Karl Williamson <khw@​cpan.org>
Date​: Thu Nov 15 10​:57​:24 2018 -0700

  Add regnode NANYOFM

  This matches when the existing node ANYOFM would not match; i.e., they
  are complements.

Perl Info 

Flags:
    category=core
    severity=medium

Site configuration information for perl 5.29.9:

Configured by dur-randir at Wed Feb 27 14:51:01 MSK 2019.

Summary of my perl5 (revision 5 version 29 subversion 9) configuration:
  Commit id: c1e47bad34ce1d9c84ed57c9b8978bcbd5a02e98
  Platform:
    osname=darwin
    osvers=13.4.0
    archname=darwin-thread-multi-2level
    uname='darwin isengard.local 13.4.0 darwin kernel version 13.4.0:
mon jan 11 18:17:34 pst 2016; root:xnu-2422.115.15~1release_x86_64
x86_64 '
    config_args='-de -Dusedevel -DDEBUGGING -Dusethreads'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include -DPERL_USE_SAFE_PUTENV'
    optimize='-O3 -g'
    cppflags='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include'
    ccversion=''
    gccversion='4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56)'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -mmacosx-version-min=10.9 -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/6.0/lib
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib
/usr/lib
    libs=-lpthread -lgdbm -ldbm -ldl -lm -lutil -lc
    perllibs=-lpthread -ldl -lm -lutil -lc
    libc=
    so=dylib
    useshrplib=false
    libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=bundle
    d_dlsymun=undef
    ccdlflags=' '
    cccdlflags=' '
    lddlflags=' -mmacosx-version-min=10.9 -bundle -undefined
dynamic_lookup -L/usr/local/lib -fstack-protector'



@INC for perl 5.29.9:
    lib
    /usr/local/lib/perl5/site_perl/5.29.9/darwin-thread-multi-2level
    /usr/local/lib/perl5/site_perl/5.29.9
    /usr/local/lib/perl5/5.29.9/darwin-thread-multi-2level
    /usr/local/lib/perl5/5.29.9


Environment for perl 5.29.9:
    DYLD_LIBRARY_PATH (unset)
    HOME=/Users/dur-randir
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/Users/dur-randir/perlbrew/bin:/Users/dur-randir/perlbrew/perls/perl-5.22.1/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/texbin
    PERLBREW_HOME=/Users/dur-randir/.perlbrew
    PERLBREW_MANPATH=/Users/dur-randir/perlbrew/perls/perl-5.22.1/man
    PERLBREW_PATH=/Users/dur-randir/perlbrew/bin:/Users/dur-randir/perlbrew/perls/perl-5.22.1/bin
    PERLBREW_PERL=perl-5.22.1
    PERLBREW_ROOT=/Users/dur-randir/perlbrew
    PERLBREW_SHELLRC_VERSION=0.84
    PERLBREW_VERSION=0.84
    PERL_BADLANG (unset)
    SHELL=/usr/local/bin/zsh

@p5pRT
Copy link
Author

p5pRT commented Apr 10, 2019

From @khwilliamson

Thanks for finding this. Fixe by
commit 0a5ed81
Author​: Karl Williamson <khw@​cpan.org>
Date​: Tue Apr 9 18​:53​:53 2019 -0600

  PATCH​: [perl #133995], Assertion failure in regmatch
 
  This was due to my forgetting that when the positive operation can only
  match UTF-8 invariant characters, the complement of it can match
  variants. The only change needed is to pass the utf8ness to the macro
  that does the work.

--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Apr 10, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 10, 2019

@khwilliamson - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT