Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blead breaks CPAN: ff8b8b42 breaks Jcode #16919

Closed
p5pRT opened this issue Apr 3, 2019 · 6 comments
Closed

Blead breaks CPAN: ff8b8b42 breaks Jcode #16919

p5pRT opened this issue Apr 3, 2019 · 6 comments
Milestone

Comments

@p5pRT
Copy link

p5pRT commented Apr 3, 2019

Migrated from rt.perl.org#133978 (status was 'resolved')

Searchable as RT133978$

@p5pRT
Copy link
Author

p5pRT commented Apr 3, 2019

From @jkeenan

In the course of investigating the status of RT 132577 re
Module​::Install, I happened to notice that blead was breaking Jcode
version 2.07. With the following bisection command​:

#####
perl Porting/bisect.pl --start=9a15f8566d548de2162909bc3ee39a6486eb616f
--module=Jcode
#####

... I was able to identify the breaking commit​:

#####
ff8b8b4 is the first bad commit
commit ff8b8b4
Author​: Karl Williamson <khw@​cpan.org>
Date​: Fri Mar 29 12​:57​:40 2019 -0600

regexec.c​: Use first byte info in ANYOFH

Commit 765e6ec changed
ANYOFH regnodes to note if the first byte of all code
points matched is the same. When that is the case we can
potentially speed up matching by only trying to match at
points in the input where that byte occurs. Since ANYOFH
nodes match only UTF-8 encoded strings, that first byte is
going to be a UTF-8 start byte. If that is uncommon in the
target string, this is a real winner.

#####

Some test output​:

#####
t/perl581.t .. ok

# Failed test 'm//'
# at t/regex.t line 21.
# got​: '¤Ã¤¿'
# expected​: '¤Ò¤é¤¬¤Ê¤Î'
# Looks like you failed 1 test of 7.
t/regex.t ....
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests
t/tr.t ....... ok

Test Summary Report


t/regex.t (Wstat​: 256 Tests​: 7 Failed​: 1)
  Failed test​: 1
  Non-zero exit status​: 1
Files=11, Tests=244, 1 wallclock secs ( 0.05 usr 0.01 sys + 0.67 cusr
  0.06 csys = 0.79 CPU)
Result​: FAIL
#####

Karl, can you take a look?

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Apr 3, 2019

From @jkeenan

Summary of my perl5 (revision 5 version 29 subversion 10) configuration​:
  Commit id​: 06cbc31
  Platform​:
  osname=linux
  osvers=4.15.0-47-generic
  archname=x86_64-linux
  uname='linux zareason 4.15.0-47-generic #50-ubuntu smp wed mar 13 10​:44​:52 utc 2019 x86_64 x86_64 x86_64 gnulinux '
  config_args='-des -Dusedevel -Uversiononly -Dprefix=/home/jkeenan/testing/blead -Dman1dir=none -Dman3dir=none'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='7.3.0'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/7/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64
  libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.27.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.27'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Apr 3 2019 07​:41​:43
  %ENV​:
  PERL2DIR="/home/jkeenan/gitwork/perl2"
  PERLBREW_HOME="/home/jkeenan/.perlbrew"
  PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.28.0/man"
  PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.28.0/bin"
  PERLBREW_PERL="perl-5.28.0"
  PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew"
  PERLBREW_SHELLRC_VERSION="0.84"
  PERLBREW_VERSION="0.84"
  PERL_WORKDIR="/home/jkeenan/gitwork/perl"
  @​INC​:
  lib
  /home/jkeenan/testing/blead/lib/perl5/site_perl/5.29.10/x86_64-linux
  /home/jkeenan/testing/blead/lib/perl5/site_perl/5.29.10
  /home/jkeenan/testing/blead/lib/perl5/5.29.10/x86_64-linux
  /home/jkeenan/testing/blead/lib/perl5/5.29.10

@p5pRT
Copy link
Author

p5pRT commented Apr 3, 2019

From @khwilliamson

This is now fixed by

a8c6afd2d5a27331e819d971d2f0e23ae8f22ddb
--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Apr 3, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 3, 2019

@khwilliamson - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Apr 3, 2019
@p5pRT
Copy link
Author

p5pRT commented Apr 3, 2019

From @khwilliamson

Actually the commit was
0453256
--
Karl Williamson

@toddr toddr added this to the 5.30.0 milestone Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants