Blead breaks CPAN: 657ed7c1 breaks XML::Parser #16918
Comments
From @jkeenanIn the course of investigating the status of RT 132577 re With the following bisection command ... ##### ... I was able to identify this point of breakage ##### fix leak in package name lookup S_parse_gv_stash_name() mallocs a temporary buffer when Can be reproduced with e.g. &{"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx Similar code is already present in t/op/stash_parse_gv.t Here is the failing test: ##### Test Summary Report t/decl.t (Wstat: 134 Tests: 1 Failed: 0) I should note that for almost three years there has been a development Thank you very much. |
From @jkeenanSummary of my perl5 (revision 5 version 29 subversion 10) configuration: Characteristics of this binary (from libperl): |
From @jkeenanOn Wed, 03 Apr 2019 00:43:25 GMT, jkeenan@pobox.com wrote:
Also broken by this commit: SQL::Translator ##### t/23json.t (Wstat: 139 Tests: 0 Failed: 0) |
From [Unknown Contact. See original ticket]On Wed, 03 Apr 2019 00:43:25 GMT, jkeenan@pobox.com wrote:
Also broken by this commit: SQL::Translator ##### t/23json.t (Wstat: 139 Tests: 0 Failed: 0) |
From @jkeenanOn Wed, 03 Apr 2019 03:08:25 GMT, jkeenan wrote:
Also broken by this commit: Email::Abstract Thank you very much. -- |
|
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Tue, 02 Apr 2019 17:43:25 -0700, jkeenan@pobox.com wrote:
The attached fixes XML::Parser for me. It happens at this line in Expat/Expat.pm: $ioref = *{$arg}{IO} if defined *{$arg}; where $arg is the source of the document but I haven't been able to make a simple reproducer. Tony |
From @tonycoz0001-perl-133977-don-t-double-free-tmpfullbuf.patchFrom 58523c7c5079638aeffeafbc72642074fd6ad07c Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Wed, 3 Apr 2019 15:34:09 +1100
Subject: (perl #133977) don't double-free tmpfullbuf
---
gv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gv.c b/gv.c
index 61085f5c53..3b8759e88a 100644
--- a/gv.c
+++ b/gv.c
@@ -1665,7 +1665,6 @@ S_parse_gv_stash_name(pTHX_ HV **stash, GV **gv, const char **name,
gvp = (GV**)hv_fetch(*stash, key, is_utf8 ? -((I32)*len) : (I32)*len, add);
*gv = gvp ? *gvp : NULL;
if (!*gv || *gv == (const GV *)&PL_sv_undef) {
- Safefree(tmpfullbuf); /* free our tmpfullbuf if it was used */
goto notok;
}
/* here we know that *gv && *gv != &PL_sv_undef */
--
2.11.0
|
From @iabynOn Tue, Apr 02, 2019 at 09:58:03PM -0700, Tony Cook via RT wrote:
Thanks for the diagnosis. I've just pushed the following: commit 06cbc31 Fix recent double free in S_parse_gv_stash_name() M gv.c -- |
From @jkeenanOn Wed, 03 Apr 2019 10:44:47 GMT, davem wrote:
Thanks for the rapid response. All 3 modules I reported as failing are passing as of v5.29.9-54-g06cbc31722. Since Andreas and Slaven are likely to find other distros temporarily broken by the original commit, I'll monitor this ticket for a couple of weeks to make sure everything is cool. Thank you very much. -- |
From @jkeenanNo additional failures reported. Marking ticket Resolved. |
|
@jkeenan - Status changed from 'open' to 'resolved' |
p5pRT
added
BBC
Migrated from rt.perl.org#133977 (status was 'resolved')
Searchable as RT133977$
The text was updated successfully, but these errors were encountered: