Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtUtils::ParseXS release, plus bug with clang++ on 5.14-5.16 on EUPXS 3.04_01+ #16916

Closed
p5pRT opened this issue Apr 1, 2019 · 10 comments · Fixed by #18652
Closed

ExtUtils::ParseXS release, plus bug with clang++ on 5.14-5.16 on EUPXS 3.04_01+ #16916

p5pRT opened this issue Apr 1, 2019 · 10 comments · Fixed by #18652
Labels
cpan-dual-life issues regarding dual-life cpan-first distributions

Comments

@p5pRT
Copy link

p5pRT commented Apr 1, 2019

Migrated from rt.perl.org#133973 (status was 'open')

Searchable as RT133973$

@p5pRT
Copy link
Author

p5pRT commented Apr 1, 2019

From ej_zg@hotmail.com

ExtUtils​::ParseXS is 3.40 in perl blead, 3.35 on CPAN. Can someone release it?

Also, there is a problem with v3.04_01+ on 5.14-5.16 on clang++, which I will expand on using the web UI.

@p5pRT
Copy link
Author

p5pRT commented Apr 1, 2019

From @mohawk2

On Mon, 01 Apr 2019 10​:09​:03 -0700, ej_zg@​hotmail.com wrote​:

ExtUtils​::ParseXS is 3.40 in perl blead, 3.35 on CPAN. Can someone
release it?

I'm content to be co-maint on this if wished, by the way, to go with EU​::CppGuess etc.

Also, there is a problem with v3.04_01+ on 5.14-5.16 on clang++, which
I will expand on using the web UI.

To expand slightly​: the problem was exposed by this CPANTesters report​: http​://www.cpantesters.org/cpan/report/4d4205da-541f-11e9-9066-e374b0ba08e8

Basically, perl.h on 5.14 didn't correctly detect that dNOOP should use a C++-style thing for clang, but the right thing happens if HASATTRIBUTE_UNUSED is manually undefined after config.h, and before perl.h​: see tsee/extutils-cppguess@07ec6d7

On 5.16, that didn't work, but redefining dNOOP after perl.h does work​: tsee/extutils-cppguess@c622bb7

On 5.18, nothing is necessary.

If it is desired, I can look at making EUPXS do the right thing (obviously that would require further checking for C++, which is redundant for this already-guaranteed-C++ bit of XS). Let me know.

@p5pRT
Copy link
Author

p5pRT commented Apr 1, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 21, 2019

From @mohawk2

Deafening silence on this so far.

I attach a bug-fix for when a typemap does not have the type. In trying to create the error message, it currently calls $type->xstype. Unfortunately, as shown by my making the patch with 4 lines of context not 3, $type is a string. This therefore blows up.

Please apply it.

Please release ExtUtils​::ParseXS on CPAN.

@p5pRT
Copy link
Author

p5pRT commented Apr 21, 2019

From @mohawk2

0001-fix-obvious-error-message-bug.patch
From f29a139cef1a63ec5b3d3a7b5d0448aa99fe06ad Mon Sep 17 00:00:00 2001
From: Ed J <mohawk2@users.noreply.github.com>
Date: Sun, 21 Apr 2019 22:18:13 +0100
Subject: [PATCH] fix obvious error-message bug

---
 dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
index fba7f4d73d..05030a4d94 100644
--- a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
+++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
@@ -1903,9 +1903,9 @@ sub generate_init {
   $type =~ tr/:/_/ unless $self->{RetainCplusplusHierarchicalTypes};
 
   my $inputmap = $typemaps->get_inputmap(xstype => $xstype);
   if (not defined $inputmap) {
-    $self->blurt("Error: No INPUT definition for type '$type', typekind '" . $type->xstype . "' found");
+    $self->blurt("Error: No INPUT definition for type '$type', typekind '" . $xstype . "' found");
     return;
   }
 
   my $expr = $inputmap->cleaned_code;
-- 
2.17.1

@jkeenan jkeenan added the cpan-dual-life issues regarding dual-life cpan-first distributions label Mar 20, 2021
@mohawk2
Copy link
Contributor

mohawk2 commented Mar 25, 2021

@jkeenan Thanks for your attention on this! What would be the process on getting ExtUtils::ParseXS released on CPAN, which doesn't seem to have happened yet?

@jkeenan
Copy link
Contributor

jkeenan commented Mar 25, 2021

@jkeenan Thanks for your attention on this! What would be the process on getting ExtUtils::ParseXS released on CPAN, which doesn't seem to have happened yet?

@rjbs @xsawyerx

@mohawk2
Copy link
Contributor

mohawk2 commented Dec 20, 2021

Please can the current EUPXS be released on CPAN?

@xsawyerx
Copy link
Member

xsawyerx commented Jan 1, 2022

I'm willing to cut a release.

@mohawk2
Copy link
Contributor

mohawk2 commented Jan 1, 2022

I'm willing to cut a release.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpan-dual-life issues regarding dual-life cpan-first distributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants