Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBC: 1ed4b7762a breaks MIKIHOSHI/File-Stamped-0.08.tar.gz et al. #16720

Closed
p5pRT opened this issue Oct 13, 2018 · 15 comments
Closed

BBC: 1ed4b7762a breaks MIKIHOSHI/File-Stamped-0.08.tar.gz et al. #16720

p5pRT opened this issue Oct 13, 2018 · 15 comments
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)
Milestone

Comments

@p5pRT
Copy link

p5pRT commented Oct 13, 2018

Migrated from rt.perl.org#133585 (status was 'resolved')

Searchable as RT133585$

@p5pRT
Copy link
Author

p5pRT commented Oct 13, 2018

From @andk

BBC candidate​: https://rt.cpan.org/Ticket/Display.html?id=127361
--
andreas
PS​: perl, perl, perl

@p5pRT
Copy link
Author

p5pRT commented Oct 13, 2018

From @jkeenan

On Sat, 13 Oct 2018 06​:59​:09 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

BBC candidate​: https://rt.cpan.org/Ticket/Display.html?id=127361

Since breakage from this commit was anticipated, I'm placing the SHA in the ticket Subject for easier reference.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 13, 2018

From [Unknown Contact. See original ticket]

On Sat, 13 Oct 2018 06​:59​:09 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

BBC candidate​: https://rt.cpan.org/Ticket/Display.html?id=127361

Since breakage from this commit was anticipated, I'm placing the SHA in the ticket Subject for easier reference.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 13, 2018

From @jkeenan

On Sat, 13 Oct 2018 06​:59​:09 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

BBC candidate​: https://rt.cpan.org/Ticket/Display.html?id=127361

TonyC, list​:

In this case the CPAN author is tie-ing a filehandle and creating a WRITE method which internally invokes CORE​::syswrite​:

#####
sub TIEHANDLE {
  (
  ( defined( $_[1] ) && UNIVERSAL​::isa( $_[1], __PACKAGE__ ) )
  ? $_[1]
  : shift->new(@​_)
  );
}

sub PRINT { shift->print(@​_) }

sub WRITE { shift->syswrite(@​_) }
#####

Is there a way to adapt this that we can recommend to CPAN authors as best practice/standard operating procedure?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 13, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Oct 14, 2018

From @andk

Also affected​: ETHER/Catalyst-Runtime-5.90119.tar.gz https://rt.cpan.org/Ticket/Display.html?id=133585
--
andreas

@p5pRT
Copy link
Author

p5pRT commented Oct 14, 2018

From @jkeenan

On Sun, 14 Oct 2018 02​:25​:16 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​: ETHER/Catalyst-Runtime-5.90119.tar.gz
https://rt.cpan.org/Ticket/Display.html?id=133585

You probably mean​:
https://rt.cpan.org/Ticket/Display.html?id=125843
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 14, 2018

From @andk

On Sat, 13 Oct 2018 19​:40​:15 -0700, "James E Keenan via RT" <perlbug-followup@​perl.org> said​:

  > On Sun, 14 Oct 2018 02​:25​:16 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​: ETHER/Catalyst-Runtime-5.90119.tar.gz
https://rt.cpan.org/Ticket/Display.html?id=133585

  > You probably mean​:
  > https://rt.cpan.org/Ticket/Display.html?id=125843

Ooops, yes, thanks, this was what I meant.

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Oct 15, 2018

From @tonycoz

On Sat, Oct 13, 2018 at 05​:30​:55AM -0700, James E Keenan via RT wrote​:

On Sat, 13 Oct 2018 06​:59​:09 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

BBC candidate​: https://rt.cpan.org/Ticket/Display.html?id=127361

TonyC, list​:

In this case the CPAN author is tie-ing a filehandle and creating a WRITE method which internally invokes CORE​::syswrite​:

#####
sub TIEHANDLE {
(
( defined( $_[1] ) && UNIVERSAL​::isa( $_[1], __PACKAGE__ ) )
? $_[1]
: shift->new(@​_)
);
}

sub PRINT { shift->print(@​_) }

sub WRITE { shift->syswrite(@​_) }
#####

Is there a way to adapt this that we can recommend to CPAN authors as best practice/standard operating procedure?

File​::Stamped accepts a iomode parameter which defaults to ">>​:utf8"
and that's in use in the test case.

Simplest in this case would be for the test case to use ">>​:raw" or
something similar.

Tony

@p5pRT
Copy link
Author

p5pRT commented Oct 15, 2018

From @jkeenan

On Sun, 14 Oct 2018 06​:43​:23 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Sat, 13 Oct 2018 19​:40​:15 -0700, "James E Keenan via RT"
<perlbug-followup@​perl.org> said​:

On Sun, 14 Oct 2018 02​:25​:16 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​: ETHER/Catalyst-Runtime-5.90119.tar.gz
https://rt.cpan.org/Ticket/Display.html?id=133585

You probably mean​:
https://rt.cpan.org/Ticket/Display.html?id=125843

Ooops, yes, thanks, this was what I meant.

I have submitted patches for each of File-Stamped and Catalyst-Runtime.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 17, 2018

From @andk

Also affected​: CAPOEIRAB/File-Slurp-9999.22.tar.gz https://rt.cpan.org/Ticket/Display.html?id=117005
--
andreas

@p5pRT
Copy link
Author

p5pRT commented Apr 14, 2019

From @jkeenan

On Mon, 15 Oct 2018 13​:55​:14 GMT, jkeenan wrote​:

On Sun, 14 Oct 2018 06​:43​:23 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Sat, 13 Oct 2018 19​:40​:15 -0700, "James E Keenan via RT"
<perlbug-followup@​perl.org> said​:

On Sun, 14 Oct 2018 02​:25​:16 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​: ETHER/Catalyst-Runtime-5.90119.tar.gz
https://rt.cpan.org/Ticket/Display.html?id=133585

You probably mean​:
https://rt.cpan.org/Ticket/Display.html?id=125843

Ooops, yes, thanks, this was what I meant.

I have submitted patches for each of File-Stamped and Catalyst-
Runtime.

Thank you very much.

Requested new CPAN release of File-Stamped in https://rt.cpan.org/Ticket/Display.html?id=127361

Catalyst-Runtime looks good.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 23, 2019

From @iabyn

On Sat, Apr 13, 2019 at 07​:12​:16PM -0700, James E Keenan via RT wrote​:

On Mon, 15 Oct 2018 13​:55​:14 GMT, jkeenan wrote​:

On Sun, 14 Oct 2018 06​:43​:23 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Sat, 13 Oct 2018 19​:40​:15 -0700, "James E Keenan via RT"
<perlbug-followup@​perl.org> said​:

On Sun, 14 Oct 2018 02​:25​:16 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​: ETHER/Catalyst-Runtime-5.90119.tar.gz
https://rt.cpan.org/Ticket/Display.html?id=133585

You probably mean​:
https://rt.cpan.org/Ticket/Display.html?id=125843

Ooops, yes, thanks, this was what I meant.

I have submitted patches for each of File-Stamped and Catalyst-
Runtime.

Thank you very much.

Requested new CPAN release of File-Stamped in https://rt.cpan.org/Ticket/Display.html?id=127361

Catalyst-Runtime looks good.

Since all three rt.cpna.org tickets mentioned in this BBC ticket have been
marked resolved with new CPAN releases, I propose that we close this
ticket;

--
"I do not resent criticism, even when, for the sake of emphasis,
it parts for the time with reality".
  -- Winston Churchill, House of Commons, 22nd Jan 1941.

@p5pRT
Copy link
Author

p5pRT commented Apr 23, 2019

From @jkeenan

On Tue, 23 Apr 2019 15​:31​:38 GMT, davem wrote​:

On Sat, Apr 13, 2019 at 07​:12​:16PM -0700, James E Keenan via RT wrote​:

On Mon, 15 Oct 2018 13​:55​:14 GMT, jkeenan wrote​:

On Sun, 14 Oct 2018 06​:43​:23 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Sat, 13 Oct 2018 19​:40​:15 -0700, "James E Keenan via RT"
<perlbug-followup@​perl.org> said​:

On Sun, 14 Oct 2018 02​:25​:16 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​: ETHER/Catalyst-Runtime-5.90119.tar.gz
https://rt.cpan.org/Ticket/Display.html?id=133585

You probably mean​:
https://rt.cpan.org/Ticket/Display.html?id=125843

Ooops, yes, thanks, this was what I meant.

I have submitted patches for each of File-Stamped and Catalyst-
Runtime.

Thank you very much.

Requested new CPAN release of File-Stamped in
https://rt.cpan.org/Ticket/Display.html?id=127361

Catalyst-Runtime looks good.

Since all three rt.cpna.org tickets mentioned in this BBC ticket have
been
marked resolved with new CPAN releases, I propose that we close this
ticket;

+1

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 24, 2019

@iabyn - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Apr 24, 2019
@p5pRT p5pRT added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Severity Low labels Oct 19, 2019
@toddr toddr added this to the 5.30.0 milestone Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)
Projects
None yet
Development

No branches or pull requests

2 participants